From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] checkpatch: fix a false check against wchar/utf-16 string
Date: Tue, 16 Jun 2020 10:17:46 -0400 [thread overview]
Message-ID: <20200616141746.GU24893@bill-the-cat> (raw)
In-Reply-To: <20200616054307.6017-1-takahiro.akashi@linaro.org>
On Tue, Jun 16, 2020 at 02:43:07PM +0900, AKASHI Takahiro wrote:
> UEFI subsystem uses utf-16 string, but checkpatch.pl complains
> about any occurrences of L"xxx" which is definitely legal.
> So just suppress this kind of warning.
> Precautiously, we will check u"xxx" as well.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index edba36565167..b3697720787c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5462,7 +5462,7 @@ sub process {
> }
>
> # concatenated string without spaces between elements
> - if ($line =~ /$String[A-Za-z0-9_]/ || $line =~ /[A-Za-z0-9_]$String/) {
> + if ($line =~ /$String[A-Za-z0-9_]/ || $line =~ /([A-Za-z0-9_]+[Lu]|[A-Za-z0-9_]*[A-KM-Za-tv-z0-9_])$String/) {
> if (CHK("CONCATENATED_STRING",
> "Concatenated strings should use spaces between elements\n" . $herecurr) &&
> $fix) {
This looks like a generic checkpatch issue. I think we're a little out
of sync with the kernel's v5.7 but this doesn't look to be fixed there
either. Can you please submit it upstream? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200616/ab334128/attachment.sig>
next prev parent reply other threads:[~2020-06-16 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 5:43 [PATCH] checkpatch: fix a false check against wchar/utf-16 string AKASHI Takahiro
2020-06-16 14:17 ` Tom Rini [this message]
2020-07-02 17:00 ` Heinrich Schuchardt
2020-07-02 20:26 ` Tom Rini
2020-07-03 5:45 ` AKASHI Takahiro
2020-07-03 6:08 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616141746.GU24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.