From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72BEC433DF for ; Tue, 16 Jun 2020 15:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9396F208B3 for ; Tue, 16 Jun 2020 15:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728919AbgFPPar (ORCPT ); Tue, 16 Jun 2020 11:30:47 -0400 Received: from muru.com ([72.249.23.125]:57974 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728809AbgFPPaq (ORCPT ); Tue, 16 Jun 2020 11:30:46 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2F8D88123; Tue, 16 Jun 2020 15:31:37 +0000 (UTC) Date: Tue, 16 Jun 2020 08:30:42 -0700 From: Tony Lindgren To: Tomi Valkeinen Cc: Grygorii Strashko , linux-omap@vger.kernel.org, "Andrew F . Davis" , Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Keerthy , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Suman Anna , Tero Kristo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Laurent Pinchart Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal Message-ID: <20200616153042.GZ37466@atomide.com> References: <20200531193941.13179-1-tony@atomide.com> <20200531193941.13179-2-tony@atomide.com> <16ba1808-5c7f-573d-8dd0-c80cac2f476e@ti.com> <20200603140639.GG37466@atomide.com> <47e286dd-f87a-4440-5bde-1f7b53e8b672@ti.com> <20200609151943.GL37466@atomide.com> <9ed70121-2a53-d2b3-051a-88eb83e6c53f@ti.com> <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tomi Valkeinen [200616 13:02]: > On 11/06/2020 17:00, Grygorii Strashko wrote: > > I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do > > pm_runtime_force_xxx() calls at noirq suspend stage by adding: > > > >     SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > >                       pm_runtime_force_resume) > > > > Am I missing smth? > > Isn't this almost exactly the same my patch does? I just used suspend_late > and resume_early. Is noirq phase better than late & early? Well up to you as far as I'm concerned. The noirq phase comes with serious limitations, for let's say i2c bus usage if needed. Probably also harder to debug for suspend and resume. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F833C433E0 for ; Tue, 16 Jun 2020 15:31:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBBDD208B3 for ; Tue, 16 Jun 2020 15:31:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C1g6UI5e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBBDD208B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0h3qQrvyhGU8mRiPgATOiWxoQaKywL82Rd5xhtLsVsQ=; b=C1g6UI5eTJwkGr 6MzcjyXicYnUNzSt8TsEKt1wLepEQJI/+XUnInO+eRzvN24OVhx8iCRh+0iK8R9DcClA+iFIA6KvC Yap488xzNtl2odDcFrn1Vl41qt3Whc1L2Q7XM1TE4rUHbi45tETNtfcc0YkNW+Puw2Eh7PgWyaPOh 6UUQV2cS8DxhrtPpmcwfNXBBK+aF6jcCCAMTm3PoRMw9oXxEjFvwPszgHyuxjWTPPpC3aj/EaUzze 3a4pI3ivTC7lR8KOjebA2PeqQ9uB6NOi+WZJKczT7IhNyNqzGX/12IKQU1j9U/Zsm6WmNKlguB0wu ewTfTbwWycz7ee7TlqIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlDY8-0000Cp-MS; Tue, 16 Jun 2020 15:30:56 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlDY4-0000AS-LP for linux-arm-kernel@lists.infradead.org; Tue, 16 Jun 2020 15:30:54 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2F8D88123; Tue, 16 Jun 2020 15:31:37 +0000 (UTC) Date: Tue, 16 Jun 2020 08:30:42 -0700 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal Message-ID: <20200616153042.GZ37466@atomide.com> References: <20200531193941.13179-1-tony@atomide.com> <20200531193941.13179-2-tony@atomide.com> <16ba1808-5c7f-573d-8dd0-c80cac2f476e@ti.com> <20200603140639.GG37466@atomide.com> <47e286dd-f87a-4440-5bde-1f7b53e8b672@ti.com> <20200609151943.GL37466@atomide.com> <9ed70121-2a53-d2b3-051a-88eb83e6c53f@ti.com> <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_083052_750035_FBE8A783 X-CRM114-Status: UNSURE ( 6.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Grygorii Strashko , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Andrew F . Davis" , Peter Ujfalusi , Faiz Abbas , Laurent Pinchart , Keerthy , Suman Anna , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPiBbMjAwNjE2IDEzOjAyXToK PiBPbiAxMS8wNi8yMDIwIDE3OjAwLCBHcnlnb3JpaSBTdHJhc2hrbyB3cm90ZToKPiA+IEkgdGhp bmssIHN1c3BlbmQgbWlnaHQgYmUgZml4ZWQgaWYgYWxsIGRldmljZXMsIHdoaWNoIGFyZSBub3cg Y2hpbGQgb2YgdGktc3lzYywgd2lsbCBkbwo+ID4gcG1fcnVudGltZV9mb3JjZV94eHgoKSBjYWxs cyBhdCBub2lycSBzdXNwZW5kIHN0YWdlIGJ5IGFkZGluZzoKPiA+IAo+ID4gIMKgwqDCoMKgU0VU X05PSVJRX1NZU1RFTV9TTEVFUF9QTV9PUFMocG1fcnVudGltZV9mb3JjZV9zdXNwZW5kLAo+ID4g IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwbV9ydW50aW1lX2Zv cmNlX3Jlc3VtZSkKPiA+IAo+ID4gQW0gSSBtaXNzaW5nIHNtdGg/Cj4gCj4gSXNuJ3QgdGhpcyBh bG1vc3QgZXhhY3RseSB0aGUgc2FtZSBteSBwYXRjaCBkb2VzPyBJIGp1c3QgdXNlZCBzdXNwZW5k X2xhdGUKPiBhbmQgcmVzdW1lX2Vhcmx5LiBJcyBub2lycSBwaGFzZSBiZXR0ZXIgdGhhbiBsYXRl ICYgZWFybHk/CgpXZWxsIHVwIHRvIHlvdSBhcyBmYXIgYXMgSSdtIGNvbmNlcm5lZC4gVGhlIG5v aXJxIHBoYXNlIGNvbWVzIHdpdGggc2VyaW91cwpsaW1pdGF0aW9ucywgZm9yIGxldCdzIHNheSBp MmMgYnVzIHVzYWdlIGlmIG5lZWRlZC4gUHJvYmFibHkgYWxzbyBoYXJkZXIKdG8gZGVidWcgZm9y IHN1c3BlbmQgYW5kIHJlc3VtZS4KClJlZ2FyZHMsCgpUb255CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A90AC433E1 for ; Wed, 17 Jun 2020 07:26:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF7F720786 for ; Wed, 17 Jun 2020 07:26:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF7F720786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49FF66EA8B; Wed, 17 Jun 2020 07:26:06 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id AB53B6E8F1 for ; Tue, 16 Jun 2020 15:30:47 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2F8D88123; Tue, 16 Jun 2020 15:31:37 +0000 (UTC) Date: Tue, 16 Jun 2020 08:30:42 -0700 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal Message-ID: <20200616153042.GZ37466@atomide.com> References: <20200531193941.13179-1-tony@atomide.com> <20200531193941.13179-2-tony@atomide.com> <16ba1808-5c7f-573d-8dd0-c80cac2f476e@ti.com> <20200603140639.GG37466@atomide.com> <47e286dd-f87a-4440-5bde-1f7b53e8b672@ti.com> <20200609151943.GL37466@atomide.com> <9ed70121-2a53-d2b3-051a-88eb83e6c53f@ti.com> <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> X-Mailman-Approved-At: Wed, 17 Jun 2020 07:26:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Grygorii Strashko , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Andrew F . Davis" , Peter Ujfalusi , Faiz Abbas , Laurent Pinchart , Keerthy , Suman Anna , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" KiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPiBbMjAwNjE2IDEzOjAyXToK PiBPbiAxMS8wNi8yMDIwIDE3OjAwLCBHcnlnb3JpaSBTdHJhc2hrbyB3cm90ZToKPiA+IEkgdGhp bmssIHN1c3BlbmQgbWlnaHQgYmUgZml4ZWQgaWYgYWxsIGRldmljZXMsIHdoaWNoIGFyZSBub3cg Y2hpbGQgb2YgdGktc3lzYywgd2lsbCBkbwo+ID4gcG1fcnVudGltZV9mb3JjZV94eHgoKSBjYWxs cyBhdCBub2lycSBzdXNwZW5kIHN0YWdlIGJ5IGFkZGluZzoKPiA+IAo+ID4gIMKgwqDCoMKgU0VU X05PSVJRX1NZU1RFTV9TTEVFUF9QTV9PUFMocG1fcnVudGltZV9mb3JjZV9zdXNwZW5kLAo+ID4g IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwbV9ydW50aW1lX2Zv cmNlX3Jlc3VtZSkKPiA+IAo+ID4gQW0gSSBtaXNzaW5nIHNtdGg/Cj4gCj4gSXNuJ3QgdGhpcyBh bG1vc3QgZXhhY3RseSB0aGUgc2FtZSBteSBwYXRjaCBkb2VzPyBJIGp1c3QgdXNlZCBzdXNwZW5k X2xhdGUKPiBhbmQgcmVzdW1lX2Vhcmx5LiBJcyBub2lycSBwaGFzZSBiZXR0ZXIgdGhhbiBsYXRl ICYgZWFybHk/CgpXZWxsIHVwIHRvIHlvdSBhcyBmYXIgYXMgSSdtIGNvbmNlcm5lZC4gVGhlIG5v aXJxIHBoYXNlIGNvbWVzIHdpdGggc2VyaW91cwpsaW1pdGF0aW9ucywgZm9yIGxldCdzIHNheSBp MmMgYnVzIHVzYWdlIGlmIG5lZWRlZC4gUHJvYmFibHkgYWxzbyBoYXJkZXIKdG8gZGVidWcgZm9y IHN1c3BlbmQgYW5kIHJlc3VtZS4KClJlZ2FyZHMsCgpUb255Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=