From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25606C433DF for ; Tue, 16 Jun 2020 16:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00BEC2071A for ; Tue, 16 Jun 2020 16:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592323739; bh=IjT3crjofXBEWl5YFK02GjcaGpsi+bu/BrXFmNZ2GZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tb+xe7Z3q/Ugtx9QUKuUTzTzPcVocEQ3PZeuR7RmfDfzFwjPfgKaUelSq3ya8sTsU WoaVGAB7wPo7hXZq/0Ipn67N5MtkYr0m8+M0WX+qTvSgKjECnt7emvojqMee3FuU3Y u8Fw9fN2w3j3DmQcbHINlxldr9WnONyKfJNkLcAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730899AbgFPPpk (ORCPT ); Tue, 16 Jun 2020 11:45:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:36976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731071AbgFPPpe (ORCPT ); Tue, 16 Jun 2020 11:45:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20B162071A; Tue, 16 Jun 2020 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592322334; bh=IjT3crjofXBEWl5YFK02GjcaGpsi+bu/BrXFmNZ2GZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHUaJKIt4J/+X4FhtPbe8o26OdH9WLEfFPIKbeCR2xz3CkDrPO9opAjXI7cVkUjXr OehfOmZ99f75cqxiDASqx23j2AKJE1Iwc/RxCIZSUkxqV02HayJXKSaZ1/kKUyLHal 1QxRxWH8adMdswwh6FWuwwk04g9ll9jEaNhyaofo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guenter Roeck , Andy Shevchenko Subject: [PATCH 5.7 061/163] serial: imx: Initialize lock for non-registered console Date: Tue, 16 Jun 2020 17:33:55 +0200 Message-Id: <20200616153109.772076964@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153106.849127260@linuxfoundation.org> References: <20200616153106.849127260@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko commit 8f065acec7573672dd15916e31d1e9b2e785566c upstream. The commit a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") changed a bit logic behind lock initialization since for most of the console driver it's supposed to have lock already initialized even if console is not enabled. However, it's not the case for Freescale IMX console. Initialize lock explicitly in the ->probe(). Note, there is still an open question should or shouldn't not this driver register console properly. Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") Reported-by: Guenter Roeck Cc: stable Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200525105952.13744-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/imx.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2398,6 +2398,9 @@ static int imx_uart_probe(struct platfor } } + /* We need to initialize lock even for non-registered console */ + spin_lock_init(&sport->port.lock); + imx_uart_ports[sport->port.line] = sport; platform_set_drvdata(pdev, sport);