From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: U-Boot atheros PHY support and cubox ethernet
Date: Tue, 16 Jun 2020 17:57:35 -0400 [thread overview]
Message-ID: <20200616215735.GG24893@bill-the-cat> (raw)
In-Reply-To: <CA+h21ho_EsqkogrL2jDdCSg+ohZo9wtoogVkyMB_6+Ke0Fyryw@mail.gmail.com>
On Wed, Jun 17, 2020 at 12:04:16AM +0300, Vladimir Oltean wrote:
> On Wed, 17 Jun 2020 at 00:01, Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > On Tue, 16 Jun 2020 at 23:58, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote:
> > > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > > Ah. So this is probably why the DT being right isn't helping then. If
> > > > > you want to blind-convert I'm happy to test, otherwise do you have a
> > > > > similar board conversion for me to look at? Thanks!
> > > >
> > > > Please try Vladimir's suggestion as it seems to be the less intrusive approach:
> > > >
> > > > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > > > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > > > @@ -321,7 +321,7 @@ int board_eth_init(bd_t *bis)
> > > > if (!bus)
> > > > return -EINVAL;
> > > >
> > > > - phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII);
> > > > + phydev = phy_find_by_mask(bus, ETH_PHY_MASK,
> > > > PHY_INTERFACE_MODE_RGMII_ID);
> > > > if (!phydev) {
> > > > ret = -EINVAL;
> > > > goto free_bus;
> > > >
> > >
> > > OK, tried that and not enough. Console says PHY autoneg completes, but
> > > DHCP still doesn't reply.
> > >
> >
> > What about with the manual revert in place? What does
> > phydev->interface print? Not only in atheros.c, but also in
> > mx6cuboxi.c, right below this phy_find_by_mask call.
> > Trying to understand if this is your only problem or if there are more.
>
> In fact there's one more 'manual' thing you can do.
For this test, based on your previous email and the kernel dts files, I
made the change to mx6cuboxi.c to pass PHY_INTERFACE_MODE_RGMII_ID to
phy_find_by_mask(...).
> Check if RX delay is enabled (bit 15 of debug register 0):
> => mdio write eTSEC1 0x1D 0
> => mdio read eTSEC1 0x1E
> => mdio write eTSEC1 0x1E <new value>
=> mdio list
FEC:
0 - AR8035 <--> FEC
=> mdio write FEC 0x1D 0
=> mdio read FEC 0x1E
Reading from bus FEC
PHY at address 0:
30 - 0x82ee
... so it's enabled already.
> Check if TX delay is enabled (bit 8 of debug register 5):
> => mdio write eTSEC1 0x1D 5
> => mdio read eTSEC1 0x1E
> => mdio write eTSEC1 0x1E <new value>
=> mdio write FEC 0x1D 5
=> mdio read FEC 0x1E
Reading from bus FEC
PHY at address 0:
30 - 0x2d47
... so it's enabled already.
Or did I make a mistake? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200616/99df041a/attachment.sig>
next prev parent reply other threads:[~2020-06-16 21:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 19:55 U-Boot atheros PHY support and cubox ethernet Tom Rini
2020-06-16 19:58 ` Vladimir Oltean
2020-06-16 20:10 ` Tom Rini
2020-06-16 20:21 ` Vladimir Oltean
2020-06-16 20:31 ` Tom Rini
2020-06-16 20:37 ` Vladimir Oltean
2020-06-16 21:35 ` Tom Rini
2020-06-16 21:57 ` Vladimir Oltean
2020-06-17 7:19 ` Michael Walle
2020-06-16 21:30 ` Michael Walle
2020-06-16 21:37 ` Tom Rini
2020-06-16 20:42 ` Fabio Estevam
2020-06-16 20:48 ` Vladimir Oltean
2020-06-16 20:51 ` Tom Rini
2020-06-16 20:55 ` Fabio Estevam
2020-06-16 20:58 ` Tom Rini
2020-06-16 21:01 ` Fabio Estevam
2020-06-16 22:30 ` Tom Rini
2020-06-17 12:04 ` Fabio Estevam
2020-06-17 13:06 ` Fabio Estevam
2020-06-17 13:23 ` Tom Rini
2020-06-17 17:31 ` Fabio Estevam
2020-06-17 19:00 ` Tom Rini
2020-06-17 19:09 ` Fabio Estevam
2020-06-17 19:18 ` Fabio Estevam
2020-06-17 19:24 ` Tom Rini
2020-06-17 19:19 ` Tom Rini
2020-06-17 21:28 ` Fabio Estevam
2020-06-17 21:30 ` Tom Rini
2020-06-18 0:41 ` Fabio Estevam
2020-06-18 13:39 ` Tom Rini
2020-06-20 2:14 ` Fabio Estevam
2020-06-24 19:20 ` Soeren Moch
2020-06-24 19:39 ` Fabio Estevam
2020-06-24 20:13 ` Soeren Moch
2020-06-24 20:29 ` Fabio Estevam
2020-06-24 20:45 ` Sören Moch
2020-06-24 21:35 ` Fabio Estevam
2020-06-24 22:29 ` Soeren Moch
2020-06-24 23:19 ` Fabio Estevam
2020-06-24 23:44 ` Fabio Estevam
2020-06-25 9:56 ` Soeren Moch
2020-06-25 10:26 ` Fabio Estevam
2020-06-18 3:05 ` Fabio Estevam
2020-06-16 21:01 ` Vladimir Oltean
2020-06-16 21:04 ` Vladimir Oltean
2020-06-16 21:57 ` Tom Rini [this message]
2020-06-16 21:59 ` Vladimir Oltean
2020-06-16 21:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616215735.GG24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.