From: Jacky Hu <hengqing.hu@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
x86@kernel.org, yazen.ghannam@amd.com, bp@alien8.de,
clemens@ladisch.de
Subject: Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe
Date: Wed, 17 Jun 2020 15:19:27 +0800 [thread overview]
Message-ID: <20200617071927.GA398128@i716> (raw)
In-Reply-To: <20200617034028.GA1614@roeck-us.net>
Hi Guenter,
By increasing the regs count from 32 to 256 and looking into the output of `cat /sys/kernel/debug/k10temp-0000\:00\:18.3/svi`
There is some data from 0x05a300 - 0x05a330
Do you have any idea how we can guess the offset for this model?
0x05a000: 00000000 00000000 00000000 00000000
0x05a010: 00000000 00000000 00000000 00000000
0x05a020: 00000000 00000000 00000000 00000000
0x05a030: 00000000 00000000 00000000 00000000
0x05a040: 00000000 00000000 00000000 00000000
0x05a050: 00000000 00000000 00000000 00000000
0x05a060: 00000000 00000000 00000000 00000000
0x05a070: 00000000 00000000 00000000 00000000
0x05a080: 00000000 00000000 00000000 00000000
0x05a090: 00000000 00000000 00000000 00000000
0x05a0a0: 00000000 00000000 00000000 00000000
0x05a0b0: 00000000 00000000 00000000 00000000
0x05a0c0: 00000000 00000000 00000000 00000000
0x05a0d0: 00000000 00000000 00000000 00000000
0x05a0e0: 00000000 00000000 00000000 00000000
0x05a0f0: 00000000 00000000 00000000 00000000
0x05a100: 00000000 00000000 00000000 00000000
0x05a110: 00000000 00000000 00000000 00000000
0x05a120: 00000000 00000000 00000000 00000000
0x05a130: 00000000 00000000 00000000 00000000
0x05a140: 00000000 00000000 00000000 00000000
0x05a150: 00000000 00000000 00000000 00000000
0x05a160: 00000000 00000000 00000000 00000000
0x05a170: 00000000 00000000 00000000 00000000
0x05a180: 00000000 00000000 00000000 00000000
0x05a190: 00000000 00000000 00000000 00000000
0x05a1a0: 00000000 00000000 00000000 00000000
0x05a1b0: 00000000 00000000 00000000 00000000
0x05a1c0: 00000000 00000000 00000000 00000000
0x05a1d0: 00000000 00000000 00000000 00000000
0x05a1e0: 00000000 00000000 00000000 00000000
0x05a1f0: 00000000 00000000 00000000 00000000
0x05a200: 00000000 00000000 00000000 00000000
0x05a210: 00000000 00000000 00000000 00000000
0x05a220: 00000000 00000000 00000000 00000000
0x05a230: 00000000 00000000 00000000 00000000
0x05a240: 00000000 00000000 00000000 00000000
0x05a250: 00000000 00000000 00000000 00000000
0x05a260: 00000000 00000000 00000000 00000000
0x05a270: 00000000 00000000 00000000 00000000
0x05a280: 00000000 00000000 00000000 00000000
0x05a290: 00000000 00000000 00000000 00000000
0x05a2a0: 00000000 00000000 00000000 00000000
0x05a2b0: 00000000 00000000 00000000 00000000
0x05a2c0: 00000000 00000000 00000000 00000000
0x05a2d0: 00000000 00000000 00000000 00000000
0x05a2e0: 00000000 00000000 00000000 00000000
0x05a2f0: 00000000 00000000 00000000 00000000
0x05a300: 00000000 00000001 00000000 00002710
0x05a310: 00000000 00000008 0000000e 00000000
0x05a320: 00000001 0000c000 00000000 0000000b
0x05a330: 00000001 00000000 00000000 00000000
0x05a340: 00000000 00000000 00000000 00000000
0x05a350: 00000000 00000000 00000000 00000000
0x05a360: 00000000 00000000 00000000 00000000
0x05a370: 00000000 00000000 00000000 00000000
0x05a380: 00000000 00000000 00000000 00000000
0x05a390: 00000000 00000000 00000000 00000000
0x05a3a0: 00000000 00000000 00000000 00000000
0x05a3b0: 00000000 00000000 00000000 00000000
0x05a3c0: 00000000 00000000 00000000 00000000
0x05a3d0: 00000000 00000000 00000000 00000000
0x05a3e0: 00000000 00000000 00000000 00000000
0x05a3f0: 00000000 00000000 00000000 00000000
Thanks.
Jacky
On Tue, Jun 16, 2020 at 08:40:28PM -0700, Guenter Roeck wrote:
> On Wed, Jun 17, 2020 at 09:32:55AM +0800, Jacky Hu wrote:
> > With this patch applied, output from 4800H (idle) looks as follows:
> >
> > k10temp-pci-00c3
> > Adapter: PCI adapter
> > Vcore: 1.55 V
> > Vsoc: 1.55 V
> > Tctl: +49.6°C
> > Tdie: +49.6°C
> > Icore: 0.00 A
> > Isoc: 0.00 A
> >
> > Signed-off-by: Jacky Hu <hengqing.hu@gmail.com>
> > ---
> > drivers/hwmon/k10temp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> > index 8f12995ec133..287e9cf2aab9 100644
> > --- a/drivers/hwmon/k10temp.c
> > +++ b/drivers/hwmon/k10temp.c
> > @@ -583,6 +583,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > k10temp_get_ccd_support(pdev, data, 4);
> > break;
> > case 0x31: /* Zen2 Threadripper */
> > + case 0x60: /* Zen2 APU */
>
> Unfortunately it is not that simple. Output above and the little data I have
> available suggests that current and voltage measurements are different on the
> APU. That means that show_current must remain false.
> This will require a separate case statement which doesn't set any flags.
>
> Guenter
>
> > case 0x71: /* Zen2 */
> > data->show_current = !is_threadripper() && !is_epyc();
> > data->cfactor[0] = CFACTOR_ICORE;
> > --
> > 2.27.0
> >
next prev parent reply other threads:[~2020-06-17 7:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 4:37 [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Jacky Hu
2020-06-07 4:37 ` [PATCH 1/2] x86/amd_nb: Add Family 17h, Model 60h PCI IDs Jacky Hu
2020-06-16 18:08 ` Borislav Petkov
2020-06-07 4:37 ` [PATCH 2/2] EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh Jacky Hu
2020-06-16 18:09 ` Borislav Petkov
2020-06-17 1:32 ` [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe Jacky Hu
2020-06-17 3:40 ` Guenter Roeck
2020-06-17 7:19 ` Jacky Hu [this message]
2020-06-17 14:33 ` Guenter Roeck
2020-06-17 14:55 ` Jacky Hu
2020-06-17 14:54 ` Alexander Monakov
2020-06-17 15:07 ` Jacky Hu
2020-06-17 15:22 ` Borislav Petkov
2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
2020-06-15 15:01 ` Guenter Roeck
2020-06-16 14:35 ` Borislav Petkov
2020-06-16 14:46 ` Guenter Roeck
2020-06-16 14:55 ` Borislav Petkov
2020-06-16 14:11 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617071927.GA398128@i716 \
--to=hengqing.hu@gmail.com \
--cc=bp@alien8.de \
--cc=clemens@ladisch.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.