From: Greg KH <greg@kroah.com>
To: Tomek The Messenger <tomekthemessenger@gmail.com>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: the cost of EXPORT_SYMBOL_GPL
Date: Wed, 17 Jun 2020 10:55:34 +0200 [thread overview]
Message-ID: <20200617085534.GA1732069@kroah.com> (raw)
In-Reply-To: <CAA4NGyvPPWrMPnP1SY_OVfhQSANMaL_DOs+t6M+vKFWXhOzpWA@mail.gmail.com>
On Wed, Jun 17, 2020 at 09:58:03AM +0200, Tomek The Messenger wrote:
> Hi
> Thanks for reply.
> We make some proxy layer in linux /sys. So for example we have directories:
> /sys/resets
> /sys/routers
Really? That's a total abuse of sysfs, don't do that.
Seriously, that's not ok at all.
> etc.
> So if user wants to get to know what is the reset reason he doesn't use
> devmem 0xfff...., he just read the file in /sys/resets/..
> If user wants to know some routing path he doesn't read registers via
> devmem, he only reads some file in /sys/routers which gives him output.
> So this is in order to facilitate reading/writing to registers. Instead of
> searching in documentation concrete registers users have some helper proxy
> layer in sysfs. And for each directory in /sys there is separate kernel
> module. Division is based on some functionalities like resets, routing etc.
> And the problem is should this 6th kernel module perform role of getting
> access to all registers or only to parts which are used by more than one
> kernel module? Now I am using second approach but when I am looking at the
> code it looks terrible. For example #define for register X and function to
> access it, is in module A, for egister Y in module B, for register Z in 6th
> kernel module. There is mess I think and maybe better approach is to put
> all API to 6th kernel module?
I really do not understand at all, sorry. Why are you using sysfs for
something that it is not designed for? And sysfs directory structure
has nothing to do with kernel module names/structures.
Do you have a pointer to your code somewhere so that we can review it
and suggest the correct apis you should be using instead?
thanks,
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2020-06-17 8:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 13:18 the cost of EXPORT_SYMBOL_GPL Tomek The Messenger
2020-06-16 13:27 ` Greg KH
2020-06-17 7:58 ` Tomek The Messenger
2020-06-17 8:55 ` Greg KH [this message]
2020-06-17 9:17 ` Tomek The Messenger
2020-06-17 9:28 ` Tomek The Messenger
2020-06-17 9:41 ` Greg KH
2020-06-17 10:39 ` Tomek The Messenger
2020-06-17 12:24 ` Valdis Klētnieks
2020-06-17 12:31 ` Greg KH
2020-06-17 12:35 ` Martin Kaiser
2020-06-17 12:48 ` Tomek The Messenger
2020-06-17 13:20 ` Valdis Klētnieks
2020-06-17 13:34 ` Ahmad Fatoum
2020-06-17 14:26 ` Tomek The Messenger
2020-06-17 15:08 ` Greg KH
2020-06-17 18:33 ` Valdis Klētnieks
2020-06-17 13:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617085534.GA1732069@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=tomekthemessenger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.