All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v9 09/12] s390x: Library resources for CSS tests
Date: Wed, 17 Jun 2020 10:42:55 +0200	[thread overview]
Message-ID: <20200617104255.607b670a.cohuck@redhat.com> (raw)
In-Reply-To: <c424e6fe-a2f1-65fe-7ed1-2f26bc58587c@redhat.com>

On Tue, 16 Jun 2020 12:31:40 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 15/06/2020 11.31, Pierre Morel wrote:
> > Provide some definitions and library routines that can be used by
> > tests targeting the channel subsystem.
> > 
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---
> >  lib/s390x/css.h      | 256 +++++++++++++++++++++++++++++++++++++++++++
> >  lib/s390x/css_dump.c | 153 ++++++++++++++++++++++++++
> >  s390x/Makefile       |   1 +
> >  3 files changed, 410 insertions(+)
> >  create mode 100644 lib/s390x/css.h
> >  create mode 100644 lib/s390x/css_dump.c  
> 
> I can't say much about the gory IO details, but at least the inline
> assembly looks fine to me now.
> 
> Acked-by: Thomas Huth <thuth@redhat.com>

I've looked at the gory I/O details, and they seem fine to me.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

  parent reply	other threads:[~2020-06-17  8:43 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15  9:31 [kvm-unit-tests PATCH v9 00/12] s390x: Testing the Channel Subsystem I/O Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 01/12] s390x: Use PSW bits definitions in cstart Pierre Morel
2020-06-16  9:31   ` Thomas Huth
2020-06-16  9:39     ` Pierre Morel
2020-06-16 13:13   ` Thomas Huth
2020-06-16 13:58     ` Pierre Morel
2020-06-16 14:01       ` Pierre Morel
2020-06-16 15:14       ` Thomas Huth
2020-06-16 16:08     ` Pierre Morel
2020-06-16 16:11       ` Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 02/12] s390x: Move control register bit definitions and add AFP to them Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 03/12] s390x: saving regs for interrupts Pierre Morel
2020-06-17  8:13   ` Cornelia Huck
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 04/12] s390x: interrupt registration Pierre Morel
2020-06-17  8:20   ` Cornelia Huck
2020-06-17 11:01     ` Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 05/12] s390x: export the clock get_clock_ms() utility Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 06/12] s390x: clock and delays caluculations Pierre Morel
2020-06-16  9:35   ` Thomas Huth
2020-06-16  9:40     ` Pierre Morel
2020-06-17  8:27   ` Cornelia Huck
2020-06-17 11:04     ` Pierre Morel
2020-06-22  9:09   ` Janosch Frank
2020-06-30 16:13     ` Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 07/12] s390x: define function to wait for interrupt Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 08/12] s390x: retrieve decimal and hexadecimal kernel parameters Pierre Morel
2020-06-16  9:47   ` Thomas Huth
2020-06-16 13:43     ` Pierre Morel
2020-06-17  8:37   ` Cornelia Huck
2020-06-17 11:05     ` Pierre Morel
2020-06-22  9:33   ` Janosch Frank
2020-06-22 10:57     ` Andrew Jones
2020-07-02 12:53       ` Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 09/12] s390x: Library resources for CSS tests Pierre Morel
2020-06-16 10:31   ` Thomas Huth
2020-06-16 13:42     ` Pierre Morel
2020-06-17  8:42     ` Cornelia Huck [this message]
2020-06-17 11:08       ` Pierre Morel
2020-06-22  9:35   ` Janosch Frank
2020-06-24 12:26   ` Thomas Huth
2020-06-30 16:30     ` Pierre Morel
2020-06-15  9:31 ` [kvm-unit-tests PATCH v9 10/12] s390x: css: stsch, enumeration test Pierre Morel
2020-06-16 11:37   ` Thomas Huth
2020-06-16 13:42     ` Pierre Morel
2020-06-17  8:48   ` Cornelia Huck
2020-06-17 11:14     ` Pierre Morel
2020-06-15  9:32 ` [kvm-unit-tests PATCH v9 11/12] s390x: css: msch, enable test Pierre Morel
2020-06-16 11:43   ` Thomas Huth
2020-06-16 13:43     ` Pierre Morel
2020-06-17  8:54   ` Cornelia Huck
2020-06-17 11:25     ` Pierre Morel
2020-06-15  9:32 ` [kvm-unit-tests PATCH v9 12/12] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2020-06-17  9:54   ` Cornelia Huck
2020-06-17 11:55     ` Pierre Morel
2020-06-19  6:57       ` Cornelia Huck
2020-07-02 12:56         ` Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617104255.607b670a.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.