From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767B2C433E0 for ; Wed, 17 Jun 2020 15:08:52 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0326120707 for ; Wed, 17 Jun 2020 15:08:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="k0g5FCMM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="sQ57OcEA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0326120707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.93) (envelope-from ) id 1jlZfl-000343-65; Wed, 17 Jun 2020 11:08:17 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jlZfj-00033x-N2 for kernelnewbies@kernelnewbies.org; Wed, 17 Jun 2020 11:08:16 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1578A5C00FE; Wed, 17 Jun 2020 11:08:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 17 Jun 2020 11:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=I96JlcLfzbB/GL5gwfFxYoAX+kb DunU4LSrxj+gJGZ0=; b=k0g5FCMMMRdGPnB3iHyZL66BsOdmpfZ12ljbD+PF5gR 9q8igpdV+cuXPGIkHWJ9SoBihkOlSfqGCE6Ki6fW/HUvgXmXeQgf0gpIhuVoWJHw VG3TsMI2a2x3hrx/GPjjshhq/sgGZOTyIzzKlNC0CTsG2YAOck/88zgveXyW14n3 wfUuORCesKL0/V6KEKmqq3F48Whm7iQBG6I3KhgiK21w0Ummg+p3zSz02Vgtd6Zv TxuUNPmnJr5R/QBj+vinQoxoOXP7Zl22ZC8w4kHCdP0+XaNfwzXl7eQgEgcBix9S vtkQYz4V/R8zQWUYC2h0pe/0v4IFzunC2xiCEPYritg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=I96Jlc LfzbB/GL5gwfFxYoAX+kbDunU4LSrxj+gJGZ0=; b=sQ57OcEApstRbYUeZnCuNn m6rNAtF54gJ1GTiyaU5djgODFS3xnIjMiJJu7Fy2owXlHcl5m4C72VD5uEoCfedh nW29ns+JzNmpb+tDdTZHoLLzCt63s+t2r0KRrAJxeyjudM/UfPvLYSF80ICeGfVd 5R5AM4ZX9L0lcp5XpXwhiMNBEwZmJsKi+DR89DsGLf9VK+506GxZBT+DayPyyt9k KDQ4NLBVoIor3WbMVXluYB2WlP+ktjQD4a+6A01Koqzo5ix2rte5HoQfgbhClNC7 pGZQMXAdLb7YnDaolvc0Xzfz9bIGCef0svIlXUYyYjvp4VjdpRkr1N9GyExVr2pQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucfkphepkeef rdekiedrkeelrddutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A431328005D; Wed, 17 Jun 2020 11:08:12 -0400 (EDT) Date: Wed, 17 Jun 2020 17:08:04 +0200 From: Greg KH To: Tomek The Messenger Subject: Re: the cost of EXPORT_SYMBOL_GPL Message-ID: <20200617150804.GA2699137@kroah.com> References: <20200616132714.GA4019625@kroah.com> <20200617085534.GA1732069@kroah.com> <20200617094119.GA1940079@kroah.com> <20200617123528.vyxryhhfh7n5f33p@viti.kaiser.cx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Ahmad Fatoum , kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, Jun 17, 2020 at 04:26:49PM +0200, Tomek The Messenger wrote: > > If we have one unique sysfs interface then it is easier for > > everyone: tester, developer to proceed with such device, testing or > > debugging. > > >>No - not really. Because if you're mapping 3 or 4 SOC resets reasons to > >>one thing, you then have to write code that says "If it's SoC 1, then > >>a bit 12 being set was a memory error, but if it's SOC 2 bit 12 means a > >>PCI bus reset and a memory parity error is bit 17, but a memory ECC > >>error is bit 4." > > >>And if the meaning of the reset register is different, a lot of *other* > things > >>are probably different too, which is an argument for just having separate > >>drivers for each SoC. > > Yes separate drivers but the actions do by them is to create the same files > in sysfs. So if somebody use intel, texas instrument or xilinx soc then in > order to read reset reason or other stuff he will use sysfs. So this will > look likes: > /sys/resetreg - 3 separate drivers plus one core driver where there is > common part > /sys/otherfunctionality- as Above > Apart from above 3 drivers where there is api to access registers from > ti, Intel, xilinx. This was original question if place here all api > reads/writes or only common between sysfs kernel modules. > ... > /sys/functionalityN -> separate driver for intel, TI, Xilinx Again, use the specific subsystem for these values, don't try to expose your own mess in sysfs, especially with "raw" kobjects. You will run into loads of problems that way. greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies