From: Vishal Kulkarni <vishal@chelsio.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
dt <dt@chelsio.com>
Subject: Re: [PATCH net-next 3/5] cxgb4: add support to flash boot image
Date: Thu, 18 Jun 2020 10:38:33 +0530 [thread overview]
Message-ID: <20200618050833.GA10675@chelsio.com> (raw)
In-Reply-To: <20200617092527.30333c1f@kicinski-fedora-PC1C0HJN>
On Wednesday, June 06/17/20, 2020 at 21:55:27 +0530, Jakub Kicinski wrote:
> On Wed, 17 Jun 2020 11:59:05 +0530 Vishal Kulkarni wrote:
> > Update set_flash to flash boot image to flash region
> >
> > Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>
>
> This patch adds 4 new warnings to the plethora of warnings in
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c when built with W=1 C=1 flags.
>
> Please don't add new ones. And preferably address the existing
> hundreds of warnings in your driver.
Hi Jakub,
Thank you for feedback. I will fix those 4 new warnings and post v2.
As for old ones, We have already started on addressing them
and will post patches soon.
-Vishal
next prev parent reply other threads:[~2020-06-18 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 6:29 [PATCH net-next 0/5] cxgb4: add support to read/write flash Vishal Kulkarni
2020-06-17 6:29 ` [PATCH net-next 1/5] cxgb4: update set_flash to flash different images Vishal Kulkarni
2020-06-17 6:29 ` [PATCH net-next 2/5] cxgb4: add support to flash PHY image Vishal Kulkarni
2020-06-17 6:29 ` [PATCH net-next 3/5] cxgb4: add support to flash boot image Vishal Kulkarni
2020-06-17 16:25 ` Jakub Kicinski
2020-06-18 5:08 ` Vishal Kulkarni [this message]
2020-06-17 6:29 ` [PATCH net-next 4/5] cxgb4: add support to flash boot cfg image Vishal Kulkarni
2020-06-17 6:29 ` [PATCH net-next 5/5] cxgb4: add support to read serial flash Vishal Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618050833.GA10675@chelsio.com \
--to=vishal@chelsio.com \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.