Re: [PATCH v9 1/5] Allow vu_message_read to be replaced

[Kevin Wolf <kwolf@redhat.com>]

Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben:
> Allow vu_message_read to be replaced by one which will make use of the
> QIOChannel functions. Thus reading vhost-user message won't stall the
> guest.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>

_vu_queue_notify() still has a direct call of vu_message_read() instead
of using the pointer. Is this intentional?

Renaming the function would make sure that such semantic merge conflicts
don't stay unnoticed.

> @@ -1704,6 +1702,7 @@ vu_deinit(VuDev *dev)
>          }
>  
>          if (vq->kick_fd != -1) {
> +            dev->remove_watch(dev, vq->kick_fd);
>              close(vq->kick_fd);
>              vq->kick_fd = -1;
>          }

This hunk looks unrelated.

Kevin