From: Kees Cook <keescook@chromium.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <guro@fb.com>,
Christoph Lameter <cl@linux.com>,
Alexander Popov <alex.popov@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
vinmenon@codeaurora.org, Matthew Garrett <mjg59@google.com>,
Jann Horn <jannh@google.com>,
Vijayanand Jitta <vjitta@codeaurora.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB and SLOB
Date: Thu, 18 Jun 2020 13:37:24 -0700 [thread overview]
Message-ID: <202006181330.2FDF47E03D@keescook> (raw)
In-Reply-To: <20200617200151.GM8681@bombadil.infradead.org>
On Wed, Jun 17, 2020 at 01:01:51PM -0700, Matthew Wilcox wrote:
> On Wed, Jun 17, 2020 at 12:53:48PM -0700, Kees Cook wrote:
> > Include SLAB and SLOB caches when performing kmem_cache pointer
>
> ... SLOB? Really? Objects from different kmem caches are mixed together
> on the same page with SLOB (at least last time I looked). So how does
> this work?
Hmm. I'm not sure. I can't even boot a SLOB kernel these days (even
without these patches). But, pages are shared between kmem caches on
SLOB, then I certainly can't add this check for it. :) I'll adjust this
patch.
--
Kees Cook
next prev parent reply other threads:[~2020-06-18 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 19:53 [PATCH 0/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB and SLOB Kees Cook
2020-06-17 19:53 ` [PATCH 1/2] " Kees Cook
2020-06-17 20:01 ` Matthew Wilcox
2020-06-18 20:37 ` Kees Cook [this message]
2020-06-17 19:53 ` [PATCH 2/2] slab: Add naive detection of double free Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006181330.2FDF47E03D@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjg59@google.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.