All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/omap: force runtime PM suspend on system suspend
Date: Thu, 18 Jun 2020 07:41:58 -0700	[thread overview]
Message-ID: <20200618144158.GE43721@atomide.com> (raw)
In-Reply-To: <b351785a-5be4-edd2-2907-c9b091cbb481@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [200618 14:03]:
> On 18/06/2020 16:16, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [200618 09:53]:
> > > Use SET_LATE_SYSTEM_SLEEP_PM_OPS in DSS submodules to force runtime PM
> > > suspend and resume.
> > > 
> > > We use suspend late version so that omapdrm's system suspend callback is
> > > called first, as that will disable all the display outputs after which
> > > it's safe to force DSS into suspend.
> > 
> > This looks like a nice way of doing it, would be good to have as a
> > regression fix for the -rc cycle:
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Thanks. Did you get the full suspend working? I still can't resume, unless I
> use pm_test to avoid the full suspend. So I'm still not sure if things
> really work.

I just tested my fixes branch at commit 80bf72598663 ("ARM: dts: am5729:
beaglebone-ai: fix rgmii phy-mode") with your patch and HDMI cable
attached and suspend and resume works for me:

Tested-by: Tony Lindgren <tony@atomide.com>

I did not have luck the last time I tried am437x-sk-evm, but that
seems like some separate regression that's been around for awhile.
I recall testing it successfully last fall at some point.

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-19  6:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  9:51 [PATCH v2] drm/omap: force runtime PM suspend on system suspend Tomi Valkeinen
2020-06-18 13:16 ` Tony Lindgren
2020-06-18 14:01   ` Tomi Valkeinen
2020-06-18 14:41     ` Tony Lindgren [this message]
2020-06-18 16:24       ` Tony Lindgren
2020-06-18 16:24         ` Tony Lindgren
2020-07-17 16:28 ` Tony Lindgren
2020-08-04  8:22   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618144158.GE43721@atomide.com \
    --to=tony@atomide.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=grygorii.strashko@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.