From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16D4C433E0 for ; Thu, 18 Jun 2020 14:56:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABEAF2075E for ; Thu, 18 Jun 2020 14:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABEAF2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlvxk-0003d8-3Q; Thu, 18 Jun 2020 14:56:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlvxi-0003d2-TJ for xen-devel@lists.xenproject.org; Thu, 18 Jun 2020 14:56:18 +0000 X-Inumbo-ID: dd4588f2-b173-11ea-baa8-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd4588f2-b173-11ea-baa8-12813bfff9fa; Thu, 18 Jun 2020 14:56:18 +0000 (UTC) Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: RrLxoiyedqh8lE2oi+FyysfBzYSjYD/jI5T7A8N1IHFW0tCCAxkEAJ9kWGUYR4898bA4eJX0MS BlGOUoKFy9PObVxDadkrna4XO+T8R85vmgYDP7VS2sRXz5CIepuvA6PAcO6sTL65nkhY0eHitn Tf+pYxsPURNgxJO7bgM6f6q5hdSeMZb6xD4NjP16TcrbgLLJSg+eQusEybIaIEuDe8ntSZIM8O 0ySClCj5xVKNbvE3jESrw9RGCdCnqcDc2/HEJxOWKgSVN85U1h3ILR57rOzJhtp76eCE4Qk5K+ E64= X-SBRS: 2.7 X-MesageID: 20681338 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,251,1589256000"; d="scan'208";a="20681338" Date: Thu, 18 Jun 2020 16:56:10 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH for-4.14 4/8] x86/vpt: only try to resume timers belonging to enabled devices Message-ID: <20200618145610.GU735@Air-de-Roger> References: <20200612155640.4101-1-roger.pau@citrix.com> <20200612155640.4101-5-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu , paul@xen.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Jun 18, 2020 at 04:37:57PM +0200, Jan Beulich wrote: > On 12.06.2020 17:56, Roger Pau Monne wrote: > > Check whether the emulated device is actually enabled before trying to > > resume the associated timers. > > > > Thankfully all those structures are zeroed at initialization, and > > since the devices are not enabled they are never populated, which > > triggers the pt->vcpu check at the beginning of pt_resume forcing an > > exit from the function. > > So really this is a benign transformation then, rather than fixing > anything? If that's correct understanding of mine ... Yes, that's my understanding also. > > While there limit the scope of i and make it unsigned. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich Thanks, Roger.