Re: [PATCH] ASoC: codecs: Added MAX98373 Soundwire Driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On Thu, Jun 18, 2020 at 07:42:25AM -0500, Pierre-Louis Bossart wrote:

> > The DT bindings need updating to add SoundWire support.

> Interesting. The properties are the same in I2C and SoundWire mode, so would
> we need a completely different file that just specifies the SoundWire
> DeviceID, e.g.

> properties:
>   compatible:
>     const: sdw10217201000

> What's the process for such dual-mode devices?

I'd hope it could be added to the existing bindings document like for
other dual bus devices.

> > > +	regmap_write(max98373->regmap,
> > > +		     MAX98373_R203D_AMP_DIG_VOL_CTRL,
> > > +		     0x00);
> > > +	regmap_write(max98373->regmap,
> > > +		     MAX98373_R203E_AMP_PATH_GAIN,
> > > +		     0x00);

> > I'd expect these to be chip defaults, especially the volumes.

> The same sequence is already used in the I2C probe. if this needs to change,
> it's got to be applied for both cases.

Yes, it should.

> We should probably cut the common parts out, as done for rt5682. Ryan, can
> you look into this.

Indeed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]