From: Mike Snitzer <snitzer@redhat.com>
To: yangerkun <yangerkun@huawei.com>
Cc: bmr@redhat.com, dm-devel@redhat.com, agk@redhat.com, bgurney@redhat.com
Subject: Re: [PATCH v2 0/2] introduce interface to list all badblocks
Date: Thu, 18 Jun 2020 11:40:50 -0400 [thread overview]
Message-ID: <20200618154050.GA18007@redhat.com> (raw)
In-Reply-To: <20200618090620.3517530-1-yangerkun@huawei.com>
On Thu, Jun 18 2020 at 5:06am -0400,
yangerkun <yangerkun@huawei.com> wrote:
>
> This patchset will list badblocks while we do 'dmsetup status'.
>
> Image that we have mark block 1 and 2 as bad block, run following
> command will list all bad blocks:
>
> $ sudo dmsetup status dust1
> 0 33552384 dust 252:17 bypass verbose badblocks list: 1 2
>
> v1->v2:
> Realize this logical in dust_status instead dust_message since the
> result can return to user directly.
Seems you've misundeerstood. Please don't augment status to include the
listing of badblocks. The list _could_ be extremely long.
The feedback you got earlier was to use DMEMIT() from the .message
hook. And the listing would be provided as output from the 'dmsetup
message ...' command.
Mike
next prev parent reply other threads:[~2020-06-18 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 9:06 [PATCH v2 0/2] introduce interface to list all badblocks yangerkun
2020-06-18 9:06 ` [PATCH v2 1/2] dm dust: list badblock in dust_status yangerkun
2020-06-18 9:06 ` [PATCH v2 2/2] dm dust: introduce list badblocks in the rst yangerkun
2020-06-18 15:40 ` Mike Snitzer [this message]
2020-06-19 1:07 ` [PATCH v2 0/2] introduce interface to list all badblocks yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618154050.GA18007@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=bgurney@redhat.com \
--cc=bmr@redhat.com \
--cc=dm-devel@redhat.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.