From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACD1C433E0 for ; Thu, 18 Jun 2020 22:06:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D669F2080C for ; Thu, 18 Jun 2020 22:06:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KW5UkrvM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ncAx5x+1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D669F2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7EcufyR5yPrX5y+QBfMXoLuH/MswJh9DXxwZ9ru0GQw=; b=KW5UkrvM2F9Oh7 /0Wpil5LTjrHIQmROQM/SU8+pgyCBXUw+JzyCKQZQqJZnXANuFZJbTp4UtxDDBpe2oBmM4LrFTF8H JmmPmIqVbV15MKN9uSpU2UVbYVyrr05LbWQF4TdHMHdUI1GPg+h7Y9qxtiSCVrTwNp/4bpzYq3bGo 9E81BwrF/knhrF4rTWPOMCSkKNxzipnZLL4mi/Ix5DC+ZDVIiluByOGTqPJnnAsSB1pV3Lc3g8hQe 8SXCJsS+CnybgB6CJmoKpUzVtrb1qIqVNWo2+Y63IwrQ0810sc5a9BCI32fpdJ91Lw8Qg7oy87Zth FxDSfKqHGtM+X4tTQaCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jm2fx-0008OW-8O; Thu, 18 Jun 2020 22:06:25 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jm2fu-0005Qe-K4 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2020 22:06:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UYTpKINys5q7UogH0MrXFzt2ML29Bof5pSVpOvGOBQ8=; b=ncAx5x+1YGICOfIWpHwKkomK9 bND/1aWxxt+dgshqhYPBXFpArncVqbfSpKhYYKFMqXYTUq0weEfJoNO5xoajbmF4Xw+JwLx2Lsndl lkxwRGIwqOX+S0+HY62LFPEY4JqWQSBBmMpTlntAoPkg98Uqv8GlRl/NtR+gU2yTmffokTIGloIL/ mAOXdyc6hA1UGOlLD82lVTlMf0GMRaskW9nh19t9yPzq5DZwQfNKKSKMwyZ5FlCy4QOm+kq/mLHkY emSGuEZAh2W/Vt4zzQxh2kQqcLaryFyoBGCBHXVV6oquxU8/SBSVCTuoyIdz6Uwhb94XgFmkpy/Vb auvbi4H8A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58806) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm2cs-0005cS-G5; Thu, 18 Jun 2020 23:03:14 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jm2cq-00052r-7D; Thu, 18 Jun 2020 23:03:12 +0100 Date: Thu, 18 Jun 2020 23:03:12 +0100 From: Russell King - ARM Linux admin To: Sedat Dilek Subject: Re: [PATCH] Fix unwind_frame for clang-built kernels Message-ID: <20200618220312.GK1551@shell.armlinux.org.uk> References: <20200616223633.73971-1-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_150622_654694_4B7F033E X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Clang-Built-Linux ML , vincent.whitchurch@axis.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nathan Huckleberry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 17, 2020 at 06:23:48AM +0200, Sedat Dilek wrote: > On Wed, Jun 17, 2020 at 12:36 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > Since clang does not push pc and sp in function prologues, the current > > implementation of unwind_frame does not work. By using the previous > > frame's lr/fp instead of saved pc/sp we get valid unwinds on clang-built > > kernels. > > > > The bounds check on next frame pointer must be changed as well since > > there are 8 less bytes between frames. > > > > This fixes /proc//stack. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/912 > > Signed-off-by: Nathan Huckleberry > > Just a small nit. > > Please label your patch with: "arm/stacktrace: ..." or "arm: stacktrace: ..." Convention is to use "ARM: ..." for arch/arm. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18CBC433DF for ; Thu, 18 Jun 2020 22:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 682542070A for ; Thu, 18 Jun 2020 22:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ncAx5x+1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731602AbgFRWDU (ORCPT ); Thu, 18 Jun 2020 18:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgFRWDT (ORCPT ); Thu, 18 Jun 2020 18:03:19 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51A7EC06174E for ; Thu, 18 Jun 2020 15:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UYTpKINys5q7UogH0MrXFzt2ML29Bof5pSVpOvGOBQ8=; b=ncAx5x+1YGICOfIWpHwKkomK9 bND/1aWxxt+dgshqhYPBXFpArncVqbfSpKhYYKFMqXYTUq0weEfJoNO5xoajbmF4Xw+JwLx2Lsndl lkxwRGIwqOX+S0+HY62LFPEY4JqWQSBBmMpTlntAoPkg98Uqv8GlRl/NtR+gU2yTmffokTIGloIL/ mAOXdyc6hA1UGOlLD82lVTlMf0GMRaskW9nh19t9yPzq5DZwQfNKKSKMwyZ5FlCy4QOm+kq/mLHkY emSGuEZAh2W/Vt4zzQxh2kQqcLaryFyoBGCBHXVV6oquxU8/SBSVCTuoyIdz6Uwhb94XgFmkpy/Vb auvbi4H8A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58806) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm2cs-0005cS-G5; Thu, 18 Jun 2020 23:03:14 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jm2cq-00052r-7D; Thu, 18 Jun 2020 23:03:12 +0100 Date: Thu, 18 Jun 2020 23:03:12 +0100 From: Russell King - ARM Linux admin To: Sedat Dilek Cc: Nathan Huckleberry , vincent.whitchurch@axis.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Clang-Built-Linux ML Subject: Re: [PATCH] Fix unwind_frame for clang-built kernels Message-ID: <20200618220312.GK1551@shell.armlinux.org.uk> References: <20200616223633.73971-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 06:23:48AM +0200, Sedat Dilek wrote: > On Wed, Jun 17, 2020 at 12:36 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > Since clang does not push pc and sp in function prologues, the current > > implementation of unwind_frame does not work. By using the previous > > frame's lr/fp instead of saved pc/sp we get valid unwinds on clang-built > > kernels. > > > > The bounds check on next frame pointer must be changed as well since > > there are 8 less bytes between frames. > > > > This fixes /proc//stack. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/912 > > Signed-off-by: Nathan Huckleberry > > Just a small nit. > > Please label your patch with: "arm/stacktrace: ..." or "arm: stacktrace: ..." Convention is to use "ARM: ..." for arch/arm. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!