From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 18 Jun 2020 18:38:32 -0700 From: Moritz Fischer Subject: Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables Message-ID: <20200619013830.GC3685@epycbox.lan> References: <20200611211144.9421-1-luca@lucaceresoli.net> <20200611211144.9421-3-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200611211144.9421-3-luca@lucaceresoli.net> To: Luca Ceresoli Cc: linux-fpga@vger.kernel.org, Moritz Fischer , Rob Herring , Michal Simek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin List-ID: On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c > index 79106626c3f8..799ae04301be 100644 > --- a/drivers/fpga/xilinx-spi.c > +++ b/drivers/fpga/xilinx-spi.c > @@ -41,8 +41,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > const char *buf, size_t count) > { > struct xilinx_spi_conf *conf = mgr->priv; > - const size_t prog_latency_7500us = 7500; > - const size_t prog_pulse_1us = 1; > > if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) { > dev_err(&mgr->dev, "Partial reconfiguration not supported.\n"); > @@ -51,7 +49,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > > gpiod_set_value(conf->prog_b, 1); > > - udelay(prog_pulse_1us); /* min is 500 ns */ > + udelay(1); /* min is 500 ns */ > > gpiod_set_value(conf->prog_b, 0); > > @@ -61,7 +59,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > } > > /* program latency */ > - usleep_range(prog_latency_7500us, prog_latency_7500us + 100); > + usleep_range(7500, 7600); > return 0; > } > > -- > 2.27.0 > Applied to for-next, Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16C2C433DF for ; Fri, 19 Jun 2020 01:38:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90E1E207FC for ; Fri, 19 Jun 2020 01:38:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EraQ4IQ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90E1E207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+AcWogUmECzGN74Wqrm2sjNLph5H5vCSBldZmU6Xbk=; b=EraQ4IQ4XLlekW w+VywId8OEsrZ+mAbLafr8D1yHCDhIDz5zRDDdRNkNW8YkGxmGeXbXbQCjo9J8+lqtPhAbrmtrPXU EHd4RTuHBb/oHkCzDhaqDEejreLJ0smDHC9xi45lh1xQFoo3cGLOBOOPW3lVYrt9aG32n+f944Tvn jdLC9SDVt1unh7v42+1a0qZp05dLdaNtvGxQqzL4zxrOie8OVF2fC9yn1IQ2Ho84t36PQf+MaJb8g vxxtI12TBR/gNGrmNicbB0+/VlpOpqIzXwWsvhEkRrXk2tlwd8uelo9NcRurMDBq1Ivy7cz0B02lm vn2CtIMBRqjMe37RrXtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jm5zH-0003Dm-G7; Fri, 19 Jun 2020 01:38:35 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jm5zE-0003Cz-UY for linux-arm-kernel@lists.infradead.org; Fri, 19 Jun 2020 01:38:34 +0000 Received: by mail-il1-f193.google.com with SMTP id 9so7836494ilg.12 for ; Thu, 18 Jun 2020 18:38:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XYe4dm89OvAp8NEAW4Mj6NX5Hz+7LzKddjXjWWo+/oA=; b=bz5sh9a8CHSHrsF/jdeAQt7lWd9EqY4TXqrjwNeQ/35lcO7eZc+rEtv+y/H0edaQo6 XtATrQqtPqQQRrZI1xxGBfvsx9t1Iy8mEVmS90VlO0IAVHh2nkkOJeK0enpnsnjx1Qw0 iNRPiMaHSaA3FUdzXVwEFMMtxLZRt2dAvSaxarUZDpfMmlCZqb+kkcovMvWeFmtE2GB9 kVrG4kFWXWI1bIdNQZl5Y3+h7apuS5kl9sPipDwEOpqav6gZMabYP84ZLAo8iq81+qw6 +WOOwn0OPEcNaFTgxU0HdIWPoOUba/+vp3bitrVedybOBAYs2tVIdb1MxhPQ3BtykCAs t4mg== X-Gm-Message-State: AOAM532D3+1l5BCaCSAT9k7tUwDDrY5pzkqoRpSZLq9PlcB/mS2WKptV PHQghULcBnmaL3BQ+LCVBqc= X-Google-Smtp-Source: ABdhPJxBolKVx4TEXm9JJNyf4PvqzmqX6Mg/A7H1vOeO8iTVX7Nm4yElXMnQyAEt9w4m2bvywoLVsg== X-Received: by 2002:a92:d112:: with SMTP id a18mr1353053ilb.3.1592530711973; Thu, 18 Jun 2020 18:38:31 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id z16sm2386746ilz.64.2020.06.18.18.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 18:38:31 -0700 (PDT) Date: Thu, 18 Jun 2020 18:38:30 -0700 From: Moritz Fischer To: Luca Ceresoli Subject: Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables Message-ID: <20200619013830.GC3685@epycbox.lan> References: <20200611211144.9421-1-luca@lucaceresoli.net> <20200611211144.9421-3-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200611211144.9421-3-luca@lucaceresoli.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_183832_982767_E4502095 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Rob Herring , Moritz Fischer , Anatolij Gustschin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c > index 79106626c3f8..799ae04301be 100644 > --- a/drivers/fpga/xilinx-spi.c > +++ b/drivers/fpga/xilinx-spi.c > @@ -41,8 +41,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > const char *buf, size_t count) > { > struct xilinx_spi_conf *conf = mgr->priv; > - const size_t prog_latency_7500us = 7500; > - const size_t prog_pulse_1us = 1; > > if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) { > dev_err(&mgr->dev, "Partial reconfiguration not supported.\n"); > @@ -51,7 +49,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > > gpiod_set_value(conf->prog_b, 1); > > - udelay(prog_pulse_1us); /* min is 500 ns */ > + udelay(1); /* min is 500 ns */ > > gpiod_set_value(conf->prog_b, 0); > > @@ -61,7 +59,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > } > > /* program latency */ > - usleep_range(prog_latency_7500us, prog_latency_7500us + 100); > + usleep_range(7500, 7600); > return 0; > } > > -- > 2.27.0 > Applied to for-next, Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E5FC433E1 for ; Fri, 19 Jun 2020 01:38:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A8B62088E for ; Fri, 19 Jun 2020 01:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592530717; bh=J4S8mM/al6OICP8T9AlD75GXLAIgGXov24QiNUFiy/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HTfhLZX/BTbzkngtb0h/0NM73FuDMqRqzO9NOet7gUKHrRdFbiZVT6vtlTTletvVa RfsTzJgrZ7moEnjGDBm/FFTaxEtHpRpF+Y2+MdxzGCJnCnfVyJz3MCHJViRcMljTqw DbEzpRL8UbUCdkn9OtfOi3KgGywOjge3GC1q6r4c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730327AbgFSBie (ORCPT ); Thu, 18 Jun 2020 21:38:34 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:33346 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729975AbgFSBid (ORCPT ); Thu, 18 Jun 2020 21:38:33 -0400 Received: by mail-il1-f193.google.com with SMTP id z2so7867897ilq.0; Thu, 18 Jun 2020 18:38:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XYe4dm89OvAp8NEAW4Mj6NX5Hz+7LzKddjXjWWo+/oA=; b=W3qqZkSbhWwmaWc3/8nl0jYl5lxMGWyT8baT3mNDJCtb004u85Jr9syoWa/xrIiWxs AODRxSAK6dcawAeC7c97IQKWf4iMnITcdBT+8gPGgq3Dbmz76gqK1CSGFQSRr7cMTdz4 W4xe9vHfgbvM/K13jBLz2NTw1aR7Z395t6/rJlJzcFXn4Y5WB/D7OZQDdsArWNZohvaO 1ZVTnG9ts7K4mjG2PLel2McyAGIFywucNhdARNzn8Gga59f235qOf9uKIQM4Sr4R6pbd 5kyoSU0rtQUoHNfsPSGM90uzLIzDILU77oap07xYCfQNRI4umd0dyPjM+sxlZ9HyyRDL tRhg== X-Gm-Message-State: AOAM531THki9uoy9xvNrDUbHVkssYABc24YJfVYSmOjavjXeqsApVeGv cyDrchyfVJOyFE7vj58ml/Q= X-Google-Smtp-Source: ABdhPJxBolKVx4TEXm9JJNyf4PvqzmqX6Mg/A7H1vOeO8iTVX7Nm4yElXMnQyAEt9w4m2bvywoLVsg== X-Received: by 2002:a92:d112:: with SMTP id a18mr1353053ilb.3.1592530711973; Thu, 18 Jun 2020 18:38:31 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id z16sm2386746ilz.64.2020.06.18.18.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 18:38:31 -0700 (PDT) Date: Thu, 18 Jun 2020 18:38:30 -0700 From: Moritz Fischer To: Luca Ceresoli Cc: linux-fpga@vger.kernel.org, Moritz Fischer , Rob Herring , Michal Simek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin Subject: Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables Message-ID: <20200619013830.GC3685@epycbox.lan> References: <20200611211144.9421-1-luca@lucaceresoli.net> <20200611211144.9421-3-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200611211144.9421-3-luca@lucaceresoli.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c > index 79106626c3f8..799ae04301be 100644 > --- a/drivers/fpga/xilinx-spi.c > +++ b/drivers/fpga/xilinx-spi.c > @@ -41,8 +41,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > const char *buf, size_t count) > { > struct xilinx_spi_conf *conf = mgr->priv; > - const size_t prog_latency_7500us = 7500; > - const size_t prog_pulse_1us = 1; > > if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) { > dev_err(&mgr->dev, "Partial reconfiguration not supported.\n"); > @@ -51,7 +49,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > > gpiod_set_value(conf->prog_b, 1); > > - udelay(prog_pulse_1us); /* min is 500 ns */ > + udelay(1); /* min is 500 ns */ > > gpiod_set_value(conf->prog_b, 0); > > @@ -61,7 +59,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > } > > /* program latency */ > - usleep_range(prog_latency_7500us, prog_latency_7500us + 100); > + usleep_range(7500, 7600); > return 0; > } > > -- > 2.27.0 > Applied to for-next, Thanks!