From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768A6C433E0 for ; Fri, 19 Jun 2020 06:41:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A16B207DD for ; Fri, 19 Jun 2020 06:41:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iuc0yOui"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vqnt56rM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A16B207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MyyIRhH/KzW1+9zqs8iCKBDdBgO974niAJmUkupBA14=; b=iuc0yOui+RdanY p9VagxV8vE9Y4/2J786CpEQVy2VYYIdu9CBWPvJ8ZBCr9ciB3+kruieYg6w2bbbgN+N5fTTtIU0Jh QBgwp9JzUonsLSxaaoZZcMtt+REwFUqswZG2mRSlNgosw40ZJseRn3I1u+oyXONcisPcQCjOcCWnR RhXAkPCBuVtY72Gp8gl1ycehBr+hnrXSVw33oSUVJtD0lSZ0mYvPVElkUNo+DgaE9RutwHK76qPzS AAYMlQYdvIoIsEYHmbBrDBLeaqlzzQNuNNenlgBSunJ+HGf67APu5eOsGY1pfa2dmZbPC2xA7vdAm DV0Iey9mYjyuDweakQ2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmAil-0003HK-0X; Fri, 19 Jun 2020 06:41:51 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmAih-0003Gx-0C for linux-arm-kernel@lists.infradead.org; Fri, 19 Jun 2020 06:41:48 +0000 Received: by mail-wm1-x342.google.com with SMTP id f185so8035386wmf.3 for ; Thu, 18 Jun 2020 23:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zjTgpvlZoTMqly8ZeswQThHMqwpruwtDmzNEvVZw/qQ=; b=vqnt56rMvv8CFA31p493VSrcPev/9lBxJ3mwGDNEJqQ+Q69v+8vNZw5F8G7bzOo7Kg rlOqJYsSlI/Cu98RDZCPCxqTCaGNDdGEGEOvLAOdQF6juGmAxXhjvsJUkhC0rjBMZJPn YEpxOrDp8z7X1s/bGM8yYn89B2lnKhUh3aCXBe8RsevQ1AyrZ2KfOdvIm/NL7zi5DNW1 vk7ymnv5xLKTPW8MeoDMv+rmL6wC6QSu7SxTSllIltkBT3dqCkBZZTdniAYENrNMQsTg L/4FghH8cUAe7L2LnvldLWprP8X1EOwrJuPRPykpeUK6xwEzr43RCrU0h1dm46SvwR2V f50w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zjTgpvlZoTMqly8ZeswQThHMqwpruwtDmzNEvVZw/qQ=; b=TLa7PwLTbMxkLTlkMuN2y6uYbizOTe6lhVy3W42gd5h4hFg3qZSLhWWwkhjABqX51r Onvzt2xHTbEyKVhOsmNsZFe8anSd1ZSR2lyNyHTncCUT9I0OXd3XdMjU9zGHrZtZeAYt bRJgVIVB1GV54hDuGohR53mnAz0EtzM07zG4Ajxr1BPMOs6baZ9jyl8kPBw8eBKqiA5Z UwjgbGFFfiNYceLhOgf2fHBoJ62deDEuZmXfGm1vLriEF4NBDcjaf4d03srnQ21to6R5 wAxV1moUV2S0SOzksJr+mZ/QwhOhEzzr/fJAVh7wH3WPZbqcrkMqAP/Db62lZoG2XF4n aZYg== X-Gm-Message-State: AOAM533emClaKhQAwtGA8BmHCxEQMSV33GA0tC1E6lUrbFMN0e0l2IFb uGhyw0LFRU2DbQE5vI2xC/LuHw== X-Google-Smtp-Source: ABdhPJxLzoPL6ztzrQ12+0O9ZkYOHQowqhk0hClejeA2lTwZpJsYkV7bKmLIgtLySZqrkaKQ6wd8Ng== X-Received: by 2002:a1c:4189:: with SMTP id o131mr2164427wma.110.1592548903958; Thu, 18 Jun 2020 23:41:43 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f11sm6157182wrj.2.2020.06.18.23.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 23:41:43 -0700 (PDT) Date: Fri, 19 Jun 2020 07:41:41 +0100 From: Lee Jones To: Chen-Yu Tsai Subject: Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access Message-ID: <20200619064141.GK954398@dell> References: <20200618080223.951737-1-lee.jones@linaro.org> <20200618100704.GC954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_234147_076224_9C062E36 X-CRM114-Status: GOOD ( 28.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Arnd Bergmann , gregkh , Linus Walleij , "linux-kernel@vger.kernel.org" , Rob Herring , Bartosz Golaszewski , michael@walle.cc, Mark Brown , Andy Shevchenko , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxOSBKdW4gMjAyMCwgQ2hlbi1ZdSBUc2FpIHdyb3RlOgoKPiBPbiBUaHUsIEp1biAx OCwgMjAyMCBhdCA2OjA3IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdyb3Rl Ogo+ID4KPiA+IE9uIFRodSwgMTggSnVuIDIwMjAsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gPgo+ ID4gPiBPbiBUaHUsIEp1biAxOCwgMjAyMCBhdCAxMDowMyBBTSBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IFRoZSBleGlzdGluZyBTWVNDT04g aW1wbGVtZW50YXRpb24gb25seSBzdXBwb3J0cyBNTUlPIChtZW1vcnkgbWFwcGVkKQo+ID4gPiA+ IGFjY2Vzc2VzLCBmYWNpbGl0YXRlZCBieSBSZWdtYXAuICBUaGlzIGV4dGVuZHMgc3VwcG9ydCBm b3IgcmVnaXN0ZXJzCj4gPiA+ID4gaGVsZCBiZWhpbmQgSTJDIGJ1c3Nlcy4KPiA+ID4gPgo+ID4g PiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+ Cj4gPiA+IFRoZSBpbXBsZW1lbnRhdGlvbiBsb29rcyBmaW5lIHRvIG1lLCBidXQgY2FuIHlvdSBl eHBsYWluIGhvdyB0aGlzIGlzIGdvaW5nIHRvCj4gPiA+IGJlIHVzZWQsIGFuZCB3aGF0IHRoZSBh ZHZhbnRhZ2UgaXMgb3ZlciBvcGVuLWNvZGluZyB0aGUgZGV2bV9yZWdtYXBfaW5pdF9pMmMoKQo+ ID4gPiBpbiBlYWNoIGRyaXZlciB0aGF0IHdvdWxkIHVzZSB0aGlzPwo+ID4KPiA+IERvZXMgUmVn bWFwIGxldCB5b3UgcmVnaXN0ZXIvaW5pdGlhbGlzZSBhbiBJMkMgYWRkcmVzcyBtb3JlIHRoYW4g b25jZT8KPiA+Cj4gPiBXaGVuIEkgYXR0ZW1wdCBpdCwgSSBnZXQ6Cj4gPgo+ID4gWyAgICAwLjUy Mjk4OF0gaTJjIGkyYy0wOiBGYWlsZWQgdG8gcmVnaXN0ZXIgaTJjIGNsaWVudCB0bXAxMDUgYXQg MHgzMiAoLTE2KQo+ID4gWyAgICAwLjUyMzM0MV0gaTJjIGkyYy0wOiBvZl9pMmM6IEZhaWx1cmUg cmVnaXN0ZXJpbmcgL2J1c0A0MDAwMDAwL21vdGhlcmJvYXJkL2lvZnBnYUA3LDAwMDAwMDAwL2ky Y0AxNjAwMC90ZW1wQDMyCj4gPiBbICAgIDAuNTIzNjkxXSBpMmMgaTJjLTA6IEZhaWxlZCB0byBj cmVhdGUgSTJDIGRldmljZSBmb3IgL2J1c0A0MDAwMDAwL21vdGhlcmJvYXJkL2lvZnBnYUA3LDAw MDAwMDAwL2kyY0AxNjAwMC90ZW1wQDMyCj4gPgo+ID4gPiBJcyB0aGlzIGFib3V0IHVzaW5nIHBy b3BlciBsb2NraW5nIHRocm91Z2ggdGhlIHJlZ21hcCBmcmFtZXdvcmsgZm9yCj4gPiA+IHNoYXJl ZCBpMmMgY2xpZW50cywgb3IgdG8gcmVkdWNlIG1lbW9yeSBjb25zdW1wdGlvbiB3aGVuIGxvdHMg b2YgZHJpdmVycwo+ID4gPiBhY2Nlc3MgdGhlIHNhbWUgcmVnbWFwPwo+ID4KPiA+IEFsbCBvZiB0 aG9zZSB0aGluZ3MgYXJlIHZhbGlkLgo+ID4KPiA+IE15IHVzZS1jYXNlIGlzIHJlZ2FyZGluZyBN RkRzIHNoYXJpbmcgYW4gSTJDIGludGVyZmFjZWQgYWRkcmVzcyBzcGFjZQo+ID4gd2l0aCB0aGVp ciBjaGlsZHJlbi4KPiAKPiBJcyB0aGF0IGFuIGlzc3VlIHdpdGggdGhlIHN0YW5kYXJkIG1mZCAr IHJlZ21hcCBwYXR0ZXJuPwoKVGhlcmUgaXMgbm8gcmVsYXRpb25zaGlwIGJldHdlZW4gTUZEIGFu ZCBSZWdtYXAuICBJdCBpcyBub3QgbW9yZQpjbG9zZWx5IHJlbGF0ZWQgdG8gUmVnbWFwIHRoYW4g aXQgaXMgYW55IG90aGVyIHB1YmxpYyBBUEkgcHJvdmlkZWQKd2l0aGluIHRoZSBrZXJuZWwuICAq U29tZSogcGFyZW50IGRyaXZlcnMgaW5pdGlhbGlzZSBvbmUgbGFyZ2UsCmVuY29tcGFzc2luZyBS ZWdtYXAgYWRkcmVzcyBzcGFjZSBhbmQgcGFzcyBpdCB0byB0aGVpciBjaGlsZHJlbiwgYnV0CnRo aXMgaXNuJ3Qgc3VpdGFibGUgaW4gYWxsIGNhc2VzLgoKPiBGb3IgdGhlIEFYUDIweCBQTUlDcywg d2UgcmVnaXN0ZXIgdGhlIHJlZ21hcCBpbiB0aGUgcGFyZW50IG1mZCBkcml2ZXIgWzFdLAo+IGFu ZCBzdG9yZSB0aGF0IGluIGRldl9kYXRhIGZvciBjaGlsZCBkcml2ZXJzIHRvIGZldGNoIFsyXS4g WW91IGNvdWxkCj4gZWFzaWx5IGp1c3QgZmV0Y2ggdGhlIHJlZ21hcCB3aXRoIGRldl9nZXRfcmVn bWFwKCkgYW5kIGEgcG9pbnRlciB0byB0aGUKPiBwYXJlbnQgZGV2aWNlLgoKUmVtZW1iZXIsIG5v dCBhbGwgdXNlLWNhc2VzIGFyZSB0aGUgc2FtZS4gIEp1c3QgYmVjYXVzZSB5b3VyIEgvVyBmaXRz CndlbGwgd2l0aGluIHRoZSBjdXJyZW50IGZyYW1ld29yaywgZG9lc24ndCBtZWFuIGFsbCB3aWxs LgoKSW5pdGlhbGlzaW5nIGluIHRoZSBwYXJlbnQgaXMgbm8gcHJvYmxlbSBpZiB0aGUgZHJpdmVy IGlzIG1lYW5pbmdmdWwKaW4gb3RoZXIgd2F5cywgYnV0IHdoYXQgaWYgdGhhdCdzIGFsbCB0aGUg cGFyZW50IGRyaXZlciBkb2VzPyAgSW4KdGhlc2UgY2FzZXMgU3lzY29uIGNhbiBiZSB1c2VkIGlu c3RlYWQsIHJlbmRlcmluZyB0aGUgZHJpdmVyCnN1cGVyZmx1b3VzLiBNZWFuaW5nIGl0IGNhbiAo YW5kICpzaG91bGQqKSB0aGVuIGJlIG9taXR0ZWQuCgo+ID4gPiBNeSBpbXByZXNzaW9uIG9mIHRo ZSBleGlzdGluZyBzeXNjb24gY29kZSBpcyB0aGF0IHRoZSBtYWluIHZhbHVlLWFkZCBvdmVyCj4g PiA+IG90aGVyIHdheXMgb2YgZG9pbmcgdGhlIHNhbWUgaXMgdGhlIHN5c2Nvbl9yZWdtYXBfbG9v a3VwX2J5X3BoYW5kbGUoKQo+ID4gPiBpbnRlcmZhY2UgdGhhdCBnaXZlcyBvdGhlciBkcml2ZXJz IGEgbXVjaCBzaW1wbGVyIHdheSBvZiBnZXR0aW5nIHRoZQo+ID4gPiByZWdtYXAganVzdCBiYXNl ZCBvbiB0aGUgRFQgbm9kZS4gQXJlIHlvdSBwbGFubmluZyB0byBhZGQgc29tZXRoaW5nCj4gPiA+ IGxpa2UgdGhhdCBoZXJlIGFzIHdlbGw/IEFuIGlkZWFsIGRyaXZlciBpbnRlcmZhY2UgbWlnaHQg YWxsb3cKPiA+ID4gc3lzY29uX3JlZ21hcF9sb29rdXBfYnlfcGhhbmRsZSgpIHRvIHdvcmsgZm9y IGJvdGggbW1pbyBhbmQgaTJjCj4gPiA+IGJhc2VkIHN5c2NvbnMsIG9yIGFkZGl0aW9uYWwgb25l cyBhcyB3ZWxsLCBidXQgaW1wbGVtZW50aW5nIHRoaXMgd291bGQKPiA+ID4gYmUgcmF0aGVyIHRy aWNreSB3aGVuIHRoZSBpMmMgY29yZSBpcyBhIGxvYWRhYmxlIG1vZHVsZS4KPiAKPiBUaGUgY3Vy cmVudCBNTUlPIHN5c2NvbiBpcyBkZWNvdXBsZWQgZnJvbSB0aGUgRE0sIGFuZCB0aGVyZSBpcyBu byB3YXkKPiBmb3IgZHJpdmVycyB0byBleHBvcnQgb3IgcmVnaXN0ZXIgYSBzeXNjb24sIG1lYW5p bmcgSSBoYXZlIHRvIG9wZW4gY29kZQo+IHN5c2Nvbl9yZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUo KSBbM10gaWYgSSB3YW50IHRvIG9ubHkgZXhwb3NlIGNlcnRhaW4KPiByZWdpc3RlcnMgYW5kIG5v dCB0aGUgZnVsbCBhZGRyZXNzIHJhbmdlLCBvciBpZiBJIHdhbnQgdG8gc2hhcmUgdGhlCj4gcmVn bWFwIHdpdGggdGhlIGV4aXN0aW5nIGRyaXZlciAoZm9yIGxvY2tpbmcgcHVycG9zZXMpLCBvciBi b3RoIFs0XS4KCk5vdCBzdXJlIEkgdW5kZXJzdGFuZCB0aGUgcHJvYmxlbS4KCkNvdWxkIHlvdSBl eHBsYWluIHdoeSB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0IHdvcmsgZm9yIHlv dT8KCk9wZW4gY29kaW5nIHlvdXIgb3duIGltcGxlbWVudGF0aW9uIG9mIFN5c2NvbiBpcyBub24t b3B0aW1hbC4KCj4gTWF5YmUgdGhlcmUncyByb29tIGZvciBpbXByb3ZlbWVudCBoZXJlPyBUaGUg c2FtZSBhcHBsaWVzIHRvIHRoZSBuZXcKPiBJMkMgY2FzZSwgYW5kIGxpa2VseSBhbnkgb3RoZXIg ZnV0dXJlIHN5c2NvbiB2YXJpYW50cy4KPiAKPiBJTUhPIHBlb3BsZSBhcmUgZ2V0dGluZyBpdCB3 cm9uZyBpZiB0aGV5IGhhdmUgYm90aCBhIHN5c2NvbiBhbmQgYSBkcml2ZXIKPiBmb3IgdGhlIHNh bWUgZGV2aWNlLgoKU3lzY29uIGlzIGp1c3QgYSBtZWFucyB0byBvYnRhaW4gYSBncm91cCBvZiBy ZWdpc3RlcnMgZWl0aGVyIGEpCndpdGhvdXQgYSBkZWRpY2F0ZWQgZHJpdmVyIE9SIGIpIHRvIHNo YXJlIGFtb25nc3QgbW9yZSB0aGFuIDEsCnBvdGVudGlhbGx5IHVucmVsYXRlZCwgdXNlci4gIFNv IGluIHRoZSBjYXNlIG9mIGEpIHdoaWNoIGFwcGVhcnMgdG8Kc2l0IHdlbGwgd2l0aC1pbiB5b3Vy IHVzZS1jYXNlIGFuZCBleHBlY3RhdGlvbnMsIHlvdSBhcmUgY29ycmVjdC4KV2hlcmVhcyBpbiB0 aGUgY2FzZSBvZiBiKSB5b3UgYXJlIG5vdC4KCkkgaG9wZSB0aGF0IGhlbHBzIGNsYXJpdHkgdGhl IHNpdHVhdGlvbiBzb21ld2hhdC4KCj4gPiBJIGV4cGVjdCB0aGUgQVBJIHdvdWxkIGJlIGV4cGFu ZGVkIHRvIGNvdmVyIG90aGVyIHVzZS1jYXNlcy4gIFRoaXMgaXMKPiA+IGEgYmFyZSBib25lcyBp bXBsZW1lbnRhdGlvbiB3aGljaCBoYXMgYmVlbiBrZXB0IGFzIGF0b21pYyBhcyBwb3NzaWJsZQo+ ID4gZm9yIGVhc2Ugb2YgcmV2aWV3Lgo+IAo+IFJlZ2FyZHMKPiBDaGVuWXUKPiAKPiBbMV0gaHR0 cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL21mZC9h eHAyMHgtaTJjLmMjTDQzCj4gWzJdIGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xh dGVzdC9zb3VyY2UvZHJpdmVycy9waW5jdHJsL3BpbmN0cmwtYXhwMjA5LmMjTDQzMwo+IFszXSBo dHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZlcnMvbmV0 L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLXN1bjhpLmMjTDEwOTMKPiBbNF0gaHR0cHM6 Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL2Nsay9zdW54 aS1uZy9jY3Utc3VuOGktcjQwLmMjTDEzMzMKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2Vu aW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9w ZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8 IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26601C433E0 for ; Fri, 19 Jun 2020 06:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED2BA20885 for ; Fri, 19 Jun 2020 06:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vqnt56rM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725820AbgFSGlq (ORCPT ); Fri, 19 Jun 2020 02:41:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgFSGlq (ORCPT ); Fri, 19 Jun 2020 02:41:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D61C0613EE for ; Thu, 18 Jun 2020 23:41:45 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id t194so8017768wmt.4 for ; Thu, 18 Jun 2020 23:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zjTgpvlZoTMqly8ZeswQThHMqwpruwtDmzNEvVZw/qQ=; b=vqnt56rMvv8CFA31p493VSrcPev/9lBxJ3mwGDNEJqQ+Q69v+8vNZw5F8G7bzOo7Kg rlOqJYsSlI/Cu98RDZCPCxqTCaGNDdGEGEOvLAOdQF6juGmAxXhjvsJUkhC0rjBMZJPn YEpxOrDp8z7X1s/bGM8yYn89B2lnKhUh3aCXBe8RsevQ1AyrZ2KfOdvIm/NL7zi5DNW1 vk7ymnv5xLKTPW8MeoDMv+rmL6wC6QSu7SxTSllIltkBT3dqCkBZZTdniAYENrNMQsTg L/4FghH8cUAe7L2LnvldLWprP8X1EOwrJuPRPykpeUK6xwEzr43RCrU0h1dm46SvwR2V f50w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zjTgpvlZoTMqly8ZeswQThHMqwpruwtDmzNEvVZw/qQ=; b=rpUD1/ogYVPypJTXNwnZfNQk1K6jV+/B5qWfg8QNrVnSY29/9cXDOb6L2WVyNN+DBl POn6564FY+M3xw8054rSCDkyMOOdHoNb3I56So4UcrLYDxEu8OpHlhWqN4qJEwTiqADy nTTynosoSPuWAQxs0xoED0gMKMsQv4rxPdWjnMtX0Nyh3N6l7ypA5XVs2KYipoIYmLeZ zoYgow4elU8tCOU4uiJt+/A8aIU4NBG9ZTJOptDnn44rtTv2lQxTxV6ygOa6M5XSrARc BOgkLhIfwqll0re75NEbKlVdeMITSYh05iQhbPJj1aDsU0WCe3mdHX5z3anZtHtU1Z9A 4Rfw== X-Gm-Message-State: AOAM5310fa3Z0aEwTuWDNhml/zKJv7aVcO/tU/NhsGnzwquCHiKc2ZQ2 81ligVDESwSBLgjWhpzfqkS1FA== X-Google-Smtp-Source: ABdhPJxLzoPL6ztzrQ12+0O9ZkYOHQowqhk0hClejeA2lTwZpJsYkV7bKmLIgtLySZqrkaKQ6wd8Ng== X-Received: by 2002:a1c:4189:: with SMTP id o131mr2164427wma.110.1592548903958; Thu, 18 Jun 2020 23:41:43 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f11sm6157182wrj.2.2020.06.18.23.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 23:41:43 -0700 (PDT) Date: Fri, 19 Jun 2020 07:41:41 +0100 From: Lee Jones To: Chen-Yu Tsai Cc: Arnd Bergmann , DTML , gregkh , Mark Brown , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , michael@walle.cc, Rob Herring , Andy Shevchenko , Linus Walleij , Linux ARM Subject: Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access Message-ID: <20200619064141.GK954398@dell> References: <20200618080223.951737-1-lee.jones@linaro.org> <20200618100704.GC954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 19 Jun 2020, Chen-Yu Tsai wrote: > On Thu, Jun 18, 2020 at 6:07 PM Lee Jones wrote: > > > > On Thu, 18 Jun 2020, Arnd Bergmann wrote: > > > > > On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > > > > > > > The existing SYSCON implementation only supports MMIO (memory mapped) > > > > accesses, facilitated by Regmap. This extends support for registers > > > > held behind I2C busses. > > > > > > > > Signed-off-by: Lee Jones > > > > > > The implementation looks fine to me, but can you explain how this is going to > > > be used, and what the advantage is over open-coding the devm_regmap_init_i2c() > > > in each driver that would use this? > > > > Does Regmap let you register/initialise an I2C address more than once? > > > > When I attempt it, I get: > > > > [ 0.522988] i2c i2c-0: Failed to register i2c client tmp105 at 0x32 (-16) > > [ 0.523341] i2c i2c-0: of_i2c: Failure registering /bus@4000000/motherboard/iofpga@7,00000000/i2c@16000/temp@32 > > [ 0.523691] i2c i2c-0: Failed to create I2C device for /bus@4000000/motherboard/iofpga@7,00000000/i2c@16000/temp@32 > > > > > Is this about using proper locking through the regmap framework for > > > shared i2c clients, or to reduce memory consumption when lots of drivers > > > access the same regmap? > > > > All of those things are valid. > > > > My use-case is regarding MFDs sharing an I2C interfaced address space > > with their children. > > Is that an issue with the standard mfd + regmap pattern? There is no relationship between MFD and Regmap. It is not more closely related to Regmap than it is any other public API provided within the kernel. *Some* parent drivers initialise one large, encompassing Regmap address space and pass it to their children, but this isn't suitable in all cases. > For the AXP20x PMICs, we register the regmap in the parent mfd driver [1], > and store that in dev_data for child drivers to fetch [2]. You could > easily just fetch the regmap with dev_get_regmap() and a pointer to the > parent device. Remember, not all use-cases are the same. Just because your H/W fits well within the current framework, doesn't mean all will. Initialising in the parent is no problem if the driver is meaningful in other ways, but what if that's all the parent driver does? In these cases Syscon can be used instead, rendering the driver superfluous. Meaning it can (and *should*) then be omitted. > > > My impression of the existing syscon code is that the main value-add over > > > other ways of doing the same is the syscon_regmap_lookup_by_phandle() > > > interface that gives other drivers a much simpler way of getting the > > > regmap just based on the DT node. Are you planning to add something > > > like that here as well? An ideal driver interface might allow > > > syscon_regmap_lookup_by_phandle() to work for both mmio and i2c > > > based syscons, or additional ones as well, but implementing this would > > > be rather tricky when the i2c core is a loadable module. > > The current MMIO syscon is decoupled from the DM, and there is no way > for drivers to export or register a syscon, meaning I have to open code > syscon_regmap_lookup_by_phandle() [3] if I want to only expose certain > registers and not the full address range, or if I want to share the > regmap with the existing driver (for locking purposes), or both [4]. Not sure I understand the problem. Could you explain why the current implementation doesn't work for you? Open coding your own implementation of Syscon is non-optimal. > Maybe there's room for improvement here? The same applies to the new > I2C case, and likely any other future syscon variants. > > IMHO people are getting it wrong if they have both a syscon and a driver > for the same device. Syscon is just a means to obtain a group of registers either a) without a dedicated driver OR b) to share amongst more than 1, potentially unrelated, user. So in the case of a) which appears to sit well with-in your use-case and expectations, you are correct. Whereas in the case of b) you are not. I hope that helps clarity the situation somewhat. > > I expect the API would be expanded to cover other use-cases. This is > > a bare bones implementation which has been kept as atomic as possible > > for ease of review. > > Regards > ChenYu > > [1] https://elixir.bootlin.com/linux/latest/source/drivers/mfd/axp20x-i2c.c#L43 > [2] https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/pinctrl-axp209.c#L433 > [3] https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c#L1093 > [4] https://elixir.bootlin.com/linux/latest/source/drivers/clk/sunxi-ng/ccu-sun8i-r40.c#L1333 -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog