All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Changming Liu <charley.ashbringer@gmail.com>
Cc: linux-usb@vger.kernel.org, thomas@winischhofer.net,
	Changming Liu <liu.changm@northeastern.edu>
Subject: Re: [PATCH 1/4] USB: sisusbvga: change sisusb_write_mem_bulk
Date: Fri, 19 Jun 2020 09:02:30 +0200	[thread overview]
Message-ID: <20200619070230.GA543568@kroah.com> (raw)
In-Reply-To: <1592526534-1739-2-git-send-email-liu.changm@northeastern.edu>

On Thu, Jun 18, 2020 at 08:28:51PM -0400, Changming Liu wrote:
> isusb_write_mem_bulk calls sisusb_send_bulk_msg and
> is called by sisusb_write.
> Changed their parameters accordingly.

Accordingly to what?  The subject just says "change", it does not say
what any of this was changed to here.

> 
> Also change the local buf[4] of sisusb_write_mem_bulk
> to u8. This fixed a potential undefined behavior.

Shouldn't this be a separate patch so that I could be backported to
older kernels as it would fix a potential issue?

When you have "also" in a patch description, it almost always means you
should split the patch up into multiple changes.

> 
> Signed-off-by: Changming Liu <liu.changm@northeastern.edu>

This email address doesn't match the "From:" line :(

thanks,

greg k-h

  reply	other threads:[~2020-06-19  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19  0:28 [PATCH 0/4] USB: sisusbvga: series of changes char to u8 Changming Liu
2020-06-19  0:28 ` [PATCH 1/4] USB: sisusbvga: change sisusb_write_mem_bulk Changming Liu
2020-06-19  7:02   ` Greg KH [this message]
2020-06-19  0:28 ` [PATCH 2/4] USB: sisusbvga: change the buffers of sisusb from char to u8 Changming Liu
2020-06-19  0:28 ` [PATCH 3/4] USB: sisusbvga: change userbuffer for sisusb_recv_bulk_msg " Changming Liu
2020-06-19  0:28 ` [PATCH 4/4] USB: sisusbvga: change sisusb_read_mem_bulk Changming Liu
2020-06-19  7:00 ` [PATCH 0/4] USB: sisusbvga: series of changes char to u8 Greg KH
2020-06-19 20:50   ` Changming Liu
2020-06-24 15:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619070230.GA543568@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=charley.ashbringer@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=liu.changm@northeastern.edu \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.