Re: [RFC PATCH 06/21] mlx5: add header_split flag

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4231 bytes --]

Hi Jonathan,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net/master]
[also build test WARNING on linus/master v5.8-rc1 next-20200618]
[cannot apply to char-misc/char-misc-testing net-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jonathan-Lemon/netgpu-networking-between-NIC-and-GPU-CPU/20200619-001526
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git ef7232da6bcd4294cbb2d424bc35885721570f01
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_alloc_rq':
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:380:6: warning: unused variable 'num_xsk_frames' [-Wunused-variable]
380 |  u32 num_xsk_frames = 0;
|      ^~~~~~~~~~~~~~
In file included from include/linux/kernel.h:13,
from include/asm-generic/bug.h:19,
from arch/sparc/include/asm/bug.h:25,
from include/linux/bug.h:5,
from include/linux/refcount.h:96,
from include/net/act_api.h:9,
from include/net/tc_act/tc_gact.h:5,
from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:33:
drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_build_rq_frags_info':
<<                  from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:42:
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2097:24: warning: ?: using integer constants in boolean context [-Wint-in-bool-context]
2097 |              PAGE_SIZE :
include/linux/log2.h:176:4: note: in definition of macro 'roundup_pow_of_two'
176 |   (n == 1) ? 1 :            |    ^

vim +2097 drivers/net/ethernet/mellanox/mlx5/core/en_main.c

  2060	
  2061		if (!hd_split && mlx5e_rx_is_linear_skb(params, xsk)) {
  2062			int frag_stride;
  2063	
  2064			frag_stride = mlx5e_rx_get_linear_frag_sz(params, xsk);
  2065			frag_stride = roundup_pow_of_two(frag_stride);
  2066	
  2067			info->arr[0].frag_size = byte_count;
  2068			info->arr[0].frag_stride = frag_stride;
  2069			info->num_frags = 1;
  2070			info->wqe_bulk = PAGE_SIZE / frag_stride;
  2071			goto out;
  2072		}
  2073	
  2074		if (byte_count > PAGE_SIZE +
  2075		    (MLX5E_MAX_RX_FRAGS - 1) * frag_size_max)
  2076			frag_size_max = PAGE_SIZE;
  2077	
  2078		i = 0;
  2079	
  2080		if (hd_split) {
  2081			// Start with one fragment for all headers (implementing HDS)
  2082			info->arr[0].frag_size = TOTAL_HEADERS;
  2083			info->arr[0].frag_stride = roundup_pow_of_two(PAGE_SIZE);
  2084			buf_size += TOTAL_HEADERS;
  2085			// Now, continue with the payload frags.
  2086			i = 1;
  2087		}
  2088	
  2089		while (buf_size < byte_count) {
  2090			int frag_size = byte_count - buf_size;
  2091	
  2092			if (i < MLX5E_MAX_RX_FRAGS - 1)
  2093				frag_size = min(frag_size, frag_size_max);
  2094	
  2095			info->arr[i].frag_size = frag_size;
  2096			info->arr[i].frag_stride = roundup_pow_of_two(hd_split ?
> 2097								      PAGE_SIZE :
  2098								      frag_size);
  2099			info->arr[i].frag_source = hd_split;
  2100			buf_size += frag_size;
  2101			i++;
  2102		}
  2103		info->num_frags = i;
  2104		/* number of different wqes sharing a page */
  2105		info->wqe_bulk = 1 + (info->num_frags % 2);
  2106	
  2107	out:
  2108		info->wqe_bulk = max_t(u8, info->wqe_bulk, 8);
  2109		info->log_num_frags = order_base_2(info->num_frags);
  2110	}
  2111	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66202 bytes --]