From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 13/14] xfs: move the di_dmevmask field to struct xfs_inode
Date: Fri, 19 Jun 2020 15:42:41 +0200 [thread overview]
Message-ID: <20200619134241.GB27997@lst.de> (raw)
In-Reply-To: <20200603003656.GX8230@magnolia>
On Tue, Jun 02, 2020 at 05:36:56PM -0700, Darrick J. Wong wrote:
> On Sun, May 24, 2020 at 11:17:56AM +0200, Christoph Hellwig wrote:
> > In preparation of removing the historic icinode struct, move the
> > dmevmask field into the containing xfs_inode structure.
>
> Do we even use dmevmask or dmstate? Why not just get rid of them and
> set them to zero ondisk?
"we" don't really use it, no. But until recently we had an ioctl to
set it, and bulkstat can report it. If we didn't have the fields in
xfs_inode we'd thus lose information when changing the inode.
OTOH once Daves series to always read the inode buffer when dirting
the inode is merged we could copy it straight from the buffer to the
log inode. I'll volunteer to do that work once all the reuquired bit
are merged, but for now I'd just like to kill off the horrible icdinode
structure.
next prev parent reply other threads:[~2020-06-19 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 9:17 kill of struct xfs_icdinode Christoph Hellwig
2020-05-24 9:17 ` [PATCH 01/14] xfs: don't clear the "dinode core" in xfs_inode_alloc Christoph Hellwig
2020-05-24 9:17 ` [PATCH 02/14] xfs: move the di_projid field to struct xfs_inode Christoph Hellwig
2020-05-24 9:17 ` [PATCH 03/14] xfs: move the di_size " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 04/14] xfs: move the di_nblocks " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 05/14] xfs: move the di_extsize " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 06/14] xfs: move the di_cowextsize " Christoph Hellwig
2020-06-03 0:30 ` Darrick J. Wong
2020-05-24 9:17 ` [PATCH 07/14] xfs: move the di_flushiter " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 08/14] xfs: use a union for i_cowextsize and i_flushiter Christoph Hellwig
2020-06-03 0:33 ` Darrick J. Wong
2020-05-24 9:17 ` [PATCH 09/14] xfs: move the di_forkoff field to struct xfs_inode Christoph Hellwig
2020-05-24 9:17 ` [PATCH 10/14] xfs: move the di_flags " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 11/14] xfs: move the di_flags2 " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 12/14] xfs: move the di_crtime " Christoph Hellwig
2020-05-24 9:17 ` [PATCH 13/14] xfs: move the di_dmevmask " Christoph Hellwig
2020-06-03 0:36 ` Darrick J. Wong
2020-06-19 13:42 ` Christoph Hellwig [this message]
2020-05-24 9:17 ` [PATCH 14/14] xfs: move the di_dmstate " Christoph Hellwig
2020-06-01 12:56 ` kill of struct xfs_icdinode Brian Foster
2020-06-19 13:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619134241.GB27997@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.