From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Michał Leszczyński" <michal.leszczynski@cert.pl>
Cc: Kevin Tian <kevin.tian@intel.com>,
"Kang, Luwei" <luwei.kang@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Tamas K Lengyel <tamas.k.lengyel@gmail.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/7] x86/vmx: add IPT cpu feature
Date: Fri, 19 Jun 2020 17:31:40 +0200 [thread overview]
Message-ID: <20200619153140.GC735@Air-de-Roger> (raw)
In-Reply-To: <445735893.10257958.1592576548575.JavaMail.zimbra@cert.pl>
On Fri, Jun 19, 2020 at 04:22:28PM +0200, Michał Leszczyński wrote:
> ----- 19 cze 2020 o 15:44, Roger Pau Monné roger.pau@citrix.com napisał(a):
>
> > On Fri, Jun 19, 2020 at 01:40:21AM +0200, Michał Leszczyński wrote:
> >> Check if Intel Processor Trace feature is supported by current
> >> processor. Define hvm_ipt_supported function.
> >>
> >> Signed-off-by: Michal Leszczynski <michal.leszczynski@cert.pl>
> >> ---
> >
> > We usually keep a shirt list of the changes between versions, so it's
> > easier for the reviewers to know what changed. As an example:
> >
> > https://lore.kernel.org/xen-devel/20200613184132.11880-1-julien@xen.org/
> >
>
> There is a change list in the cover letter. Should I also add changelog for
> each individual patch?
Oh, sorry, completely missed that. IMO yes, it's easier for reviewers
because we then have the diff and the changelog at the same place.
Changelogs in cover letters are also fine, but I would tend to only
add big architectural changes there.
Roger.
next prev parent reply other threads:[~2020-06-19 15:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 23:34 [PATCH v2 0/7] Implement support for external IPT monitoring Michał Leszczyński
2020-06-18 23:38 ` [PATCH v2 1/7] xen/mm: lift 32 item limit from mfn/gfn arrays Michał Leszczyński
2020-06-19 11:34 ` Roger Pau Monné
2020-06-19 11:36 ` Michał Leszczyński
2020-06-19 11:48 ` Jan Beulich
2020-06-19 11:51 ` Michał Leszczyński
2020-06-19 12:35 ` Michał Leszczyński
2020-06-19 12:39 ` Jan Beulich
2020-06-22 3:00 ` Michał Leszczyński
2020-06-18 23:39 ` [PATCH v2 2/7] x86/vmx: add Intel PT MSR definitions Michał Leszczyński
2020-06-22 12:35 ` Jan Beulich
2020-06-18 23:40 ` [PATCH v2 3/7] x86/vmx: add IPT cpu feature Michał Leszczyński
2020-06-19 13:44 ` Roger Pau Monné
2020-06-19 14:22 ` Michał Leszczyński
2020-06-19 15:31 ` Roger Pau Monné [this message]
2020-06-22 2:49 ` Michał Leszczyński
2020-06-22 8:31 ` Jan Beulich
2020-06-22 12:40 ` Jan Beulich
2020-06-18 23:41 ` [PATCH v2 4/7] x86/vmx: add do_vmtrace_op Michał Leszczyński
2020-06-19 0:46 ` Michał Leszczyński
2020-06-19 15:30 ` Roger Pau Monné
2020-06-19 15:50 ` Jan Beulich
2020-06-22 2:45 ` Michał Leszczyński
2020-06-22 2:56 ` Michał Leszczyński
2020-06-22 8:39 ` Jan Beulich
2020-06-22 13:25 ` Jan Beulich
2020-06-22 14:35 ` Michał Leszczyński
2020-06-22 15:22 ` Jan Beulich
2020-06-22 16:02 ` Michał Leszczyński
2020-06-22 16:16 ` Jan Beulich
2020-06-22 16:22 ` Michał Leszczyński
2020-06-22 16:25 ` Roger Pau Monné
2020-06-22 16:33 ` Michał Leszczyński
2020-06-23 1:04 ` Michał Leszczyński
2020-06-23 8:51 ` Jan Beulich
2020-06-23 17:24 ` Andrew Cooper
2020-06-24 10:03 ` Jan Beulich
2020-06-24 12:40 ` Andrew Cooper
2020-06-24 12:52 ` Tamas K Lengyel
2020-06-24 12:23 ` Michał Leszczyński
2020-06-22 17:05 ` Michał Leszczyński
2020-06-23 8:49 ` Jan Beulich
2020-06-18 23:41 ` [PATCH v2 5/7] tools/libxc: add xc_vmtrace_* functions Michał Leszczyński
2020-06-18 23:42 ` [PATCH v2 6/7] tools/libxl: add vmtrace_pt_size parameter Michał Leszczyński
2020-06-18 23:42 ` [PATCH v2 7/7] tools/proctrace: add proctrace tool Michał Leszczyński
2020-06-18 23:51 ` [PATCH v2 0/7] Implement support for external IPT monitoring Michał Leszczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619153140.GC735@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=luwei.kang@intel.com \
--cc=michal.leszczynski@cert.pl \
--cc=tamas.k.lengyel@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.