All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Straub <lukasstraub2@web.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-block <qemu-block@nongnu.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: Re: [PATCH v4 1/4] Introduce yank feature
Date: Fri, 19 Jun 2020 18:29:24 +0200	[thread overview]
Message-ID: <20200619182924.7898035e@luklap> (raw)
In-Reply-To: <20200617151240.GM1728005@stefanha-x1.localdomain>

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

On Wed, 17 Jun 2020 16:12:40 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > +static struct YankInstance *yank_find_instance(char *name)  
> 
> There are const char * -> char * casts in later patches. Please use
> const char * where possible. Callers shouldn't need to cast away const.

nbd and chardev generate the instance name dynamically so it needs to be char *, but in migration it's hardcoded.

Thanks,
Lukas Straub

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-06-19 16:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 15:44 [PATCH v4 0/4] Introduce 'yank' oob qmp command to recover from hanging qemu Lukas Straub
2020-05-25 15:44 ` [PATCH v4 1/4] Introduce yank feature Lukas Straub
2020-06-16 14:39   ` Daniel P. Berrangé
2020-06-19 14:23     ` Lukas Straub
2020-06-19 16:53       ` Daniel P. Berrangé
2020-06-16 14:49   ` Daniel P. Berrangé
2020-06-17 15:12   ` Stefan Hajnoczi
2020-06-19 16:29     ` Lukas Straub [this message]
2020-06-19 16:52       ` Daniel P. Berrangé
2020-06-19 16:59         ` Lukas Straub
2020-05-25 15:44 ` [PATCH v4 2/4] block/nbd.c: Add " Lukas Straub
2020-06-16 14:40   ` Daniel P. Berrangé
2020-06-16 14:44   ` Daniel P. Berrangé
2020-06-19 16:23     ` Lukas Straub
2020-06-17 15:09   ` Stefan Hajnoczi
2020-06-19 18:07     ` Lukas Straub
2020-05-25 15:44 ` [PATCH v4 3/4] chardev/char-socket.c: " Lukas Straub
2020-06-16 14:41   ` Daniel P. Berrangé
2020-05-25 15:44 ` [PATCH v4 4/4] migration: " Lukas Straub
2020-06-16 14:42   ` Daniel P. Berrangé
2020-06-06 19:30 ` [PATCH v4 0/4] Introduce 'yank' oob qmp command to recover from hanging qemu Lukas Straub
2020-06-17 14:41   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619182924.7898035e@luklap \
    --to=lukasstraub2@web.de \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.