All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] Add test case for CVE-2018-11508
Date: Sat, 20 Jun 2020 11:24:27 +0200	[thread overview]
Message-ID: <20200620092427.GB281578@x230> (raw)
In-Reply-To: <20200620063713.5330-1-niravparmar@zilogic.com>

Hi Nirav,

thanks for your patch!

...
> + * This proves that there are 4 bytes of info leaked. The bug was fixed in
> + * Kernel Version 4.16.9. Therefore, the below test case will only be
> + * applicable for the kernel version 4.16.9 and above.
This is IMHO wrong. The fix 3a4d44b61625 fixes 3a4d44b61625 ("ntp: Move adjtimex
related compat syscalls to native counterparts"), which was released in
v4.13-rc1.

...
> +static struct tst_test test = {
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.min_kver = "4.16.9",
Thus there should be .min_kver = "4.13",

And most of the tests doesn't have .min_kver anyway, it might be removed
entirely.

> +	.test_all = verify_adjtimex,
> +	.bufs = (struct tst_buffers []) {
> +		{&buf, .size = sizeof(*buf)},
> +		{&tim_save, .size = sizeof(*tim_save)},
> +		{},
> +	},
> +	.tags = (const struct tst_tag[]) {
> +		{"CVE", "2018-11508"},
> +		{"linux-git", "3a4d44b61625"},
> +		{},
> +	}
> +};

Kind regards,
Petr

  reply	other threads:[~2020-06-20  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20  6:37 [LTP] [PATCH v1] Add test case for CVE-2018-11508 Nirav Parmar
2020-06-20  9:24 ` Petr Vorel [this message]
2020-08-11 14:07 ` Cyril Hrubis
  -- strict thread matches above, loose matches on Subject: below --
2020-06-22  9:49 niravparmar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200620092427.GB281578@x230 \
    --to=petr.vorel@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.