From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sat, 20 Jun 2020 11:20:05 +0000 Subject: Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Message-Id: <20200620112005.GA16901@ravnborg.org> List-Id: References: <20200618134650.44311-1-weiyongjun1@huawei.com> In-Reply-To: <20200618134650.44311-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: David Airlie , kernel-janitors@vger.kernel.org, Philippe CORNU , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hulk Robot , Thierry Reding Hi Wei. On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote: > It's not necessary to unregister backlight device which > registered with devm_backlight_device_register(). > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Thanks, pushed to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index 895ee3d1371e..d956522f32ee 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi) > if (ret < 0) { > dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n"); > drm_panel_remove(&ctx->panel); > - backlight_device_unregister(ctx->bl_dev); > return ret; > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0473C433E0 for ; Sat, 20 Jun 2020 11:20:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8631923B1F for ; Sat, 20 Jun 2020 11:20:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8631923B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF0A26E0E3; Sat, 20 Jun 2020 11:20:10 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF9EE6E0E3 for ; Sat, 20 Jun 2020 11:20:09 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1729920020; Sat, 20 Jun 2020 13:20:07 +0200 (CEST) Date: Sat, 20 Jun 2020 13:20:05 +0200 From: Sam Ravnborg To: Wei Yongjun Subject: Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Message-ID: <20200620112005.GA16901@ravnborg.org> References: <20200618134650.44311-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618134650.44311-1-weiyongjun1@huawei.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=e5mUnYsNAAAA:8 a=zABfKpiexC27CGjMe80A:9 a=CjuIK1q_8ugA:10 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, Philippe CORNU , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hulk Robot , Thierry Reding Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Wei. On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote: > It's not necessary to unregister backlight device which > registered with devm_backlight_device_register(). > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Thanks, pushed to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index 895ee3d1371e..d956522f32ee 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi) > if (ret < 0) { > dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n"); > drm_panel_remove(&ctx->panel); > - backlight_device_unregister(ctx->bl_dev); > return ret; > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23054C433E1 for ; Sat, 20 Jun 2020 11:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01B5F23B28 for ; Sat, 20 Jun 2020 11:20:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgFTLUL (ORCPT ); Sat, 20 Jun 2020 07:20:11 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:50394 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbgFTLUK (ORCPT ); Sat, 20 Jun 2020 07:20:10 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1729920020; Sat, 20 Jun 2020 13:20:07 +0200 (CEST) Date: Sat, 20 Jun 2020 13:20:05 +0200 From: Sam Ravnborg To: Wei Yongjun Cc: Thierry Reding , David Airlie , Daniel Vetter , Philippe CORNU , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hulk Robot Subject: Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Message-ID: <20200620112005.GA16901@ravnborg.org> References: <20200618134650.44311-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618134650.44311-1-weiyongjun1@huawei.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=e5mUnYsNAAAA:8 a=zABfKpiexC27CGjMe80A:9 a=CjuIK1q_8ugA:10 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei. On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote: > It's not necessary to unregister backlight device which > registered with devm_backlight_device_register(). > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Thanks, pushed to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index 895ee3d1371e..d956522f32ee 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi) > if (ret < 0) { > dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n"); > drm_panel_remove(&ctx->panel); > - backlight_device_unregister(ctx->bl_dev); > return ret; > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel