From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Date: Sat, 20 Jun 2020 17:30:12 +0200 Message-ID: <20200620153012.GA22743@ravnborg.org> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> <20200620114934.GB5829@pendragon.ideasonboard.com> <20200620143114.GA22329@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Laurent Pinchart , Thierry Reding , Rob Herring , Frank Rowand , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote: > 20.06.2020 17:31, Sam Ravnborg пишет: > > Hi Dmitry > > > >> > >> Oops! Good catch! > > Yep, thanks Laurent. Should have taken a better look before applying. > > > >> Indeed, I blindly set the LVDS type to all these > >> panels. Please revert this patch, I'll double check each panel and > >> prepare an updated version of this patch. Thank you very much for the > >> review! > > > > If you can prepare a fix within a few days then lets wait for that. > > I will do a better review next time. > > Hello Sam, > > I should be able to make it later today or tomorrow. Could you please > clarify what do you mean by the fix, do you what it to be as an > additional patch on top of the applied one or a new version of the patch? An additional patch on top of the one applied. It shall carry a proper fixes: tag like this: Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels") Cc: Dmitry Osipenko Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F1FC433E0 for ; Sat, 20 Jun 2020 15:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05667208D5 for ; Sat, 20 Jun 2020 15:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725794AbgFTPaQ (ORCPT ); Sat, 20 Jun 2020 11:30:16 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:41224 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbgFTPaQ (ORCPT ); Sat, 20 Jun 2020 11:30:16 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7CF968053D; Sat, 20 Jun 2020 17:30:13 +0200 (CEST) Date: Sat, 20 Jun 2020 17:30:12 +0200 From: Sam Ravnborg To: Dmitry Osipenko Cc: Laurent Pinchart , Thierry Reding , Rob Herring , Frank Rowand , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Message-ID: <20200620153012.GA22743@ravnborg.org> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> <20200620114934.GB5829@pendragon.ideasonboard.com> <20200620143114.GA22329@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=I1XKC5YfttuoCrzH9m8A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Dmitry On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote: > 20.06.2020 17:31, Sam Ravnborg пишет: > > Hi Dmitry > > > >> > >> Oops! Good catch! > > Yep, thanks Laurent. Should have taken a better look before applying. > > > >> Indeed, I blindly set the LVDS type to all these > >> panels. Please revert this patch, I'll double check each panel and > >> prepare an updated version of this patch. Thank you very much for the > >> review! > > > > If you can prepare a fix within a few days then lets wait for that. > > I will do a better review next time. > > Hello Sam, > > I should be able to make it later today or tomorrow. Could you please > clarify what do you mean by the fix, do you what it to be as an > additional patch on top of the applied one or a new version of the patch? An additional patch on top of the one applied. It shall carry a proper fixes: tag like this: Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels") Cc: Dmitry Osipenko Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2862C433DF for ; Sat, 20 Jun 2020 15:30:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 816B420FC3 for ; Sat, 20 Jun 2020 15:30:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816B420FC3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CF416E2EA; Sat, 20 Jun 2020 15:30:17 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4141F6E2E8 for ; Sat, 20 Jun 2020 15:30:16 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7CF968053D; Sat, 20 Jun 2020 17:30:13 +0200 (CEST) Date: Sat, 20 Jun 2020 17:30:12 +0200 From: Sam Ravnborg To: Dmitry Osipenko Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Message-ID: <20200620153012.GA22743@ravnborg.org> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> <20200620114934.GB5829@pendragon.ideasonboard.com> <20200620143114.GA22329@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=I1XKC5YfttuoCrzH9m8A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Laurent Pinchart , linux-tegra@vger.kernel.org, Frank Rowand Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgRG1pdHJ5Ck9uIFNhdCwgSnVuIDIwLCAyMDIwIGF0IDA2OjA1OjM3UE0gKzAzMDAsIERtaXRy eSBPc2lwZW5rbyB3cm90ZToKPiAyMC4wNi4yMDIwIDE3OjMxLCBTYW0gUmF2bmJvcmcg0L/QuNGI 0LXRgjoKPiA+IEhpIERtaXRyeQo+ID4gCj4gPj4KPiA+PiBPb3BzISBHb29kIGNhdGNoIQo+ID4g WWVwLCB0aGFua3MgTGF1cmVudC4gU2hvdWxkIGhhdmUgdGFrZW4gYSBiZXR0ZXIgbG9vayBiZWZv cmUgYXBwbHlpbmcuCj4gPiAKPiA+PiBJbmRlZWQsIEkgYmxpbmRseSBzZXQgdGhlIExWRFMgdHlw ZSB0byBhbGwgdGhlc2UKPiA+PiBwYW5lbHMuIFBsZWFzZSByZXZlcnQgdGhpcyBwYXRjaCwgSSds bCBkb3VibGUgY2hlY2sgZWFjaCBwYW5lbCBhbmQKPiA+PiBwcmVwYXJlIGFuIHVwZGF0ZWQgdmVy c2lvbiBvZiB0aGlzIHBhdGNoLiBUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB0aGUKPiA+PiByZXZp ZXchCj4gPiAKPiA+IElmIHlvdSBjYW4gcHJlcGFyZSBhIGZpeCB3aXRoaW4gYSBmZXcgZGF5cyB0 aGVuIGxldHMgd2FpdCBmb3IgdGhhdC4KPiA+IEkgd2lsbCBkbyBhIGJldHRlciByZXZpZXcgbmV4 dCB0aW1lLgo+IAo+IEhlbGxvIFNhbSwKPiAKPiBJIHNob3VsZCBiZSBhYmxlIHRvIG1ha2UgaXQg bGF0ZXIgdG9kYXkgb3IgdG9tb3Jyb3cuIENvdWxkIHlvdSBwbGVhc2UKPiBjbGFyaWZ5IHdoYXQg ZG8geW91IG1lYW4gYnkgdGhlIGZpeCwgZG8geW91IHdoYXQgaXQgdG8gYmUgYXMgYW4KPiBhZGRp dGlvbmFsIHBhdGNoIG9uIHRvcCBvZiB0aGUgYXBwbGllZCBvbmUgb3IgYSBuZXcgdmVyc2lvbiBv ZiB0aGUgcGF0Y2g/CkFuIGFkZGl0aW9uYWwgcGF0Y2ggb24gdG9wIG9mIHRoZSBvbmUgYXBwbGll ZC4KSXQgc2hhbGwgY2FycnkgYSBwcm9wZXIgZml4ZXM6IHRhZyBsaWtlIHRoaXM6CgpGaXhlczog OTRmMDc5MTdlYmU4ICgiZHJtL3BhbmVsLXNpbXBsZTogQWRkIG1pc3NpbmcgY29ubmVjdG9yIHR5 cGUgZm9yIHNvbWUgcGFuZWxzIikKQ2M6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNv bT4KQ2M6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KQ2M6IFRoaWVycnkgUmVkaW5n IDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+CkNjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCgoJU2FtCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=