From: "J. Bruce Fields" <bfields@fieldses.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Dave Chinner <david@fromorbit.com>,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs <linux-xfs@vger.kernel.org>,
jlayton@redhat.com
Subject: Re: [PATCH] fs: i_version mntopt gets visible through /proc/mounts
Date: Sat, 20 Jun 2020 13:09:24 -0400 [thread overview]
Message-ID: <20200620170924.GI1514@fieldses.org> (raw)
In-Reply-To: <d6f9cac3-eec0-a88e-4eab-7673728db52c@sandeen.net>
On Sat, Jun 20, 2020 at 12:00:43PM -0500, Eric Sandeen wrote:
> On 6/19/20 8:56 PM, J. Bruce Fields wrote:
> > On Sat, Jun 20, 2020 at 11:49:57AM +1000, Dave Chinner wrote:
>
> ...
>
> >> However, other people have different opinions on this matter (and we
> >> know that from the people who considered XFS v4 -> v5 going slower
> >> because iversion a major regression), and so we must acknowledge
> >> those opinions even if we don't agree with them.
> >
> > Do you have any of those reports handy? Were there numbers?
>
> I can't answer that but did a little digging. MS_I_VERSION as an option
> appeared here:
>
...
> so the optional enablement was there on day one, without any real explanation
> of why.
My memory is that they didn't have measurements at first, but worried
that there might be a performance issue. Which later mesurements
confirmed.
But that Jeff Layton's work eliminated most of that.
I think ext4 was the focuse of the concern, but xfs might also have had
a (less serious) regression, and btrfs might have actually had it worst?
But I don't have references and my memory may be wrong.
--b.
next prev parent reply other threads:[~2020-06-20 17:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 20:21 [PATCH] fs: i_version mntopt gets visible through /proc/mounts Masayoshi Mizuma
2020-06-17 8:03 ` Christoph Hellwig
2020-06-17 13:33 ` Masayoshi Mizuma
2020-06-17 15:58 ` J. Bruce Fields
2020-06-17 17:14 ` Eric Sandeen
2020-06-17 17:24 ` Darrick J. Wong
2020-06-17 17:55 ` Eric Sandeen
2020-06-17 18:18 ` J. Bruce Fields
2020-06-17 18:28 ` Eric Sandeen
2020-06-17 18:45 ` J. Bruce Fields
2020-06-18 1:30 ` Masayoshi Mizuma
2020-06-18 1:44 ` Darrick J. Wong
2020-06-18 3:33 ` Masayoshi Mizuma
2020-06-18 3:05 ` Dave Chinner
2020-06-18 3:45 ` Masayoshi Mizuma
2020-06-18 22:39 ` Dave Chinner
2020-06-19 2:20 ` J. Bruce Fields
2020-06-19 2:44 ` Dave Chinner
2020-06-19 12:04 ` Jeff Layton
2020-06-19 20:40 ` J. Bruce Fields
2020-06-19 22:10 ` Dave Chinner
2020-06-19 22:28 ` J. Bruce Fields
2020-06-20 1:49 ` Dave Chinner
2020-06-20 1:56 ` J. Bruce Fields
2020-06-20 17:00 ` Eric Sandeen
2020-06-20 17:09 ` J. Bruce Fields [this message]
2020-06-20 23:54 ` Dave Chinner
2020-06-22 21:26 ` J. Bruce Fields
2020-06-22 22:03 ` Dave Chinner
2020-06-19 13:17 ` Christoph Hellwig
2020-07-13 23:45 ` Eric Sandeen
2020-07-14 8:30 ` Christoph Hellwig
2020-07-14 20:26 ` Eric Sandeen
2020-06-27 8:29 ` [fs] 089633dad0: kmsg.xfs:Unknown_parameter'i_version' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200620170924.GI1514@fieldses.org \
--to=bfields@fieldses.org \
--cc=adilger.kernel@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=msys.mizuma@gmail.com \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.