From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: heikki.krogerus@linux.intel.com, mark.rutland@arm.com,
broonie@kernel.org, gregkh@linuxfoundation.org,
lgirdwood@gmail.com, agross@kernel.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
jackp@codeaurora.org, rdunlap@infradead.org,
bryan.odonoghue@linaro.org, lijun.kernel@gmail.com
Subject: Re: [PATCH v3 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block
Date: Sun, 21 Jun 2020 00:09:53 -0700 [thread overview]
Message-ID: <20200621070953.GE128451@builder.lan> (raw)
In-Reply-To: <20200617180209.5636-4-wcheng@codeaurora.org>
On Wed 17 Jun 11:02 PDT 2020, Wesley Cheng wrote:
> The PM8150B has a dedicated USB type C block, which can be used for type C
> orientation and role detection. Create the reference node to this type C
> block for further use.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index 322379d5c31f..ec44a8bc2f84 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -22,6 +22,14 @@ power-on@800 {
> status = "disabled";
> };
>
> + qcom,typec@1500 {
Please no "qcom," in the node names and please give it a label to make
it easy to change the status of the node.
> + compatible = "qcom,pm8150b-usb-typec";
> + status = "disabled";
> + reg = <0x1500>;
> + interrupts =
> + <0x2 0x15 0x5 IRQ_TYPE_EDGE_RISING>;
This is nicer on a single line, so please omit the line break.
Regards,
Bjorn
> + };
> +
> adc@3100 {
> compatible = "qcom,spmi-adc5";
> reg = <0x3100>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-06-21 7:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 18:02 [PATCH v3 0/6] Introduce PMIC based USB type C detection Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 1/6] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-06-18 18:33 ` Rob Herring
2020-06-18 20:09 ` Wesley Cheng
2020-06-18 22:23 ` Rob Herring
2020-06-22 17:47 ` Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-06-21 7:09 ` Bjorn Andersson [this message]
2020-06-17 18:02 ` [PATCH v3 4/6] regulator: Add support for QCOM PMIC VBUS booster Wesley Cheng
2020-06-17 18:23 ` Randy Dunlap
2020-06-21 7:04 ` Bjorn Andersson
2020-06-17 18:02 ` [PATCH v3 5/6] dt-bindings: regulator: Add dt-binding for QCOM PMIC VBUS output regulator Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 6/6] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
2020-06-17 18:41 ` Jack Pham
2020-06-21 7:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621070953.GE128451@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=lijun.kernel@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.