From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>,
Eugene Crosser <crosser@average.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org
Subject: Re: Expose skb_gso_validate_network_len() [Was: ebtables: load-on-demand extensions]
Date: Mon, 22 Jun 2020 01:52:36 +0200 [thread overview]
Message-ID: <20200621235236.GN26990@breakpoint.cc> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2006211201270.18408@n3.vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
> >Why? Maybe someone wants to collect statistics on encountered packet
> >size or something like that.
>
> Possibly so, but you would not want to penalize users who do
> want the short-circuiting behavior when they are not interested
> in the statistics.
What short-circuit behaviour?
The difference we're talking about is:
*reg = get_gso_segment_or_nh_len(skb);
vs.
if (!skb_is_gso(skb) ||
get_gso_segment_len(skb) <= priv->len))
regs->verdict.code = NFT_BREAK;
next prev parent reply other threads:[~2020-06-21 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 14:48 ebtables: load-on-demand extensions Eugene Crosser
2020-06-16 15:21 ` Jan Engelhardt
2020-06-16 15:54 ` Eugene Crosser
2020-06-16 16:33 ` Jan Engelhardt
2020-06-19 13:45 ` Eugene Crosser
2020-06-19 15:15 ` Pablo Neira Ayuso
2020-06-19 16:21 ` Eugene Crosser
2020-06-20 10:34 ` Expose skb_gso_validate_network_len() [Was: ebtables: load-on-demand extensions] Eugene Crosser
2020-06-20 11:04 ` Florian Westphal
2020-06-20 21:16 ` Eugene Crosser
2020-06-21 3:24 ` Florian Westphal
2020-06-21 10:03 ` Jan Engelhardt
2020-06-21 18:48 ` Eugene Crosser
2020-06-21 23:52 ` Florian Westphal [this message]
2020-06-22 4:50 ` Jan Engelhardt
2020-06-22 7:41 ` Eugene Crosser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621235236.GN26990@breakpoint.cc \
--to=fw@strlen.de \
--cc=crosser@average.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.