From: Oleg Nesterov <oleg@redhat.com>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: linux-kernel@vger.kernel.org, christian.brauner@ubuntu.com,
ebiederm@xmission.com, akpm@linux-foundation.org,
liuzhiqiang26@huawei.com, joel@joelfernandes.org,
paulmck@linux.vnet.ibm.com, asmadeus@codewreck.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand
Date: Mon, 22 Jun 2020 08:25:28 +0200 [thread overview]
Message-ID: <20200622062527.GA6516@redhat.com> (raw)
In-Reply-To: <20200621133704.77896-1-alexander.kapshuk@gmail.com>
On 06/21, Alexander Kapshuk wrote:
>
> Export symbol __lock_task_sighand, so it is accessible from code compiled
> as modules.
> This fixes the following modpost error:
> ERROR: modpost: "__lock_task_sighand" [net/9p/9pnet.ko] undefined!
>
> Where __lock_task_sighand is called via lock_task_sighand in net/9p/client.c
> See https://lore.kernel.org/lkml/20200620201456.14304-1-alexander.kapshuk@gmail.com/.
Why?
current->sighand is stable and can't go away. Unless "current" is exiting and
has already passed exit_notify(). So I don't think net/9p needs this helper.
However, the games with TIF_SIGPENDING doesn't look right in any case.
Oleg.
next prev parent reply other threads:[~2020-06-22 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 13:37 [PATCH] kernel/signal.c: Export symbol __lock_task_sighand Alexander Kapshuk
2020-06-21 13:54 ` Dominique Martinet
2020-06-22 8:39 ` Christian Brauner
2020-06-22 8:50 ` Alexander Kapshuk
2020-06-22 6:25 ` Oleg Nesterov [this message]
2020-06-22 8:39 ` Christian Brauner
2020-06-22 10:24 ` Dominique Martinet
2020-06-22 11:31 ` Oleg Nesterov
2020-06-22 11:36 ` Christian Brauner
2020-06-22 12:03 ` Oleg Nesterov
2020-06-22 12:29 ` Christian Brauner
2020-06-22 13:01 ` Oleg Nesterov
2020-06-22 13:04 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622062527.GA6516@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.kapshuk@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=lkp@intel.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.