From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB2FC433DF for ; Mon, 22 Jun 2020 12:33:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B11D20720 for ; Mon, 22 Jun 2020 12:33:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QcBGvkrb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kQhewzvs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B11D20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 156FB16A0; Mon, 22 Jun 2020 14:32:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 156FB16A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1592829201; bh=vUsQ4/bIHVn4jBo65OALfNI338jW6zMlkCy7dd1UtUo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QcBGvkrbBpKXyrBt0Wt5kbJE+DV15mh32WRB8uDHEYn9mdeXHB/OHP1Vg3zoZfD8t S57zN8dRu1P9jZ0a2bBKizIVtyitsIny2u/LuxfjEOHqq44j+tab98IQgwaoIcTiCx Yw75JF0oL8iBZlTlIK3sIwbLsLUj66ZbDvPjYzqU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 90EB2F8015A; Mon, 22 Jun 2020 14:32:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3D9E6F80157; Mon, 22 Jun 2020 14:31:35 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 84BB8F80157 for ; Mon, 22 Jun 2020 14:31:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 84BB8F80157 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kQhewzvs" Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CA1B206BE; Mon, 22 Jun 2020 12:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592829079; bh=vUsQ4/bIHVn4jBo65OALfNI338jW6zMlkCy7dd1UtUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQhewzvsjTq3cvPrzmIBgb5SttjfYpYAIvQ5Sk32Q6C8nxucZEc7myegU6NDew1Ql Om4NchBLWbGKl0T0gUerAdMSFOJno0IDf+H3x+a1YRaJx5M8asWcogxHQ6vTkHl6nl 7gS0eiC95+Xni+DDX+Xb7uWSTTR/yN282ozy9BK4= Date: Mon, 22 Jun 2020 08:31:18 -0400 From: Sasha Levin To: Mark Brown Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Message-ID: <20200622123118.GF1931@sasha-vm> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200622112321.GB4560@sirena.org.uk> Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: >On Sun, Jun 21, 2020 at 07:33:52PM -0400, Sasha Levin wrote: >> On Thu, Jun 18, 2020 at 03:39:30PM +0100, Mark Brown wrote: >> > On Thu, Jun 18, 2020 at 10:30:46AM -0400, Sasha Levin wrote: >> > > On Thu, Jun 18, 2020 at 12:00:23PM +0100, Mark Brown wrote: > >> > > > This is a new feature not a bugfix. > >> > > I saw this patch more as a hardware quirk. > >> > Pretty much any DT property is a hardware quirk :( > >> Which is why we're taking most of them :) > >That's concerning - please don't do this. It's not what stable is >expected to be and there's no guarantee that you're getting all the >changes required to actually make things work. How come? This is one of the things stable rules explicitly call for: "New device IDs and quirks are also accepted". If we're missing anything, the solution is to make sure we stop missing it rather than not take anything to begin with :) -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Date: Mon, 22 Jun 2020 08:31:18 -0400 Message-ID: <20200622123118.GF1931@sasha-vm> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20200622112321.GB4560-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dmitry Osipenko , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: >On Sun, Jun 21, 2020 at 07:33:52PM -0400, Sasha Levin wrote: >> On Thu, Jun 18, 2020 at 03:39:30PM +0100, Mark Brown wrote: >> > On Thu, Jun 18, 2020 at 10:30:46AM -0400, Sasha Levin wrote: >> > > On Thu, Jun 18, 2020 at 12:00:23PM +0100, Mark Brown wrote: > >> > > > This is a new feature not a bugfix. > >> > > I saw this patch more as a hardware quirk. > >> > Pretty much any DT property is a hardware quirk :( > >> Which is why we're taking most of them :) > >That's concerning - please don't do this. It's not what stable is >expected to be and there's no guarantee that you're getting all the >changes required to actually make things work. How come? This is one of the things stable rules explicitly call for: "New device IDs and quirks are also accepted". If we're missing anything, the solution is to make sure we stop missing it rather than not take anything to begin with :) -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731A1C433E1 for ; Mon, 22 Jun 2020 12:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 528F62071A for ; Mon, 22 Jun 2020 12:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592829082; bh=vUsQ4/bIHVn4jBo65OALfNI338jW6zMlkCy7dd1UtUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dJLKNPo7TH5An+LpjGbyLjAJ/If3rO21hdap5HReS9YlUZUPqenEGUMsNFRxUo/a5 Y3Lc2mVv7db5v7y41cA1rsrKDR9yF5JoB3PlJMOcxd7tVoRU1c3E3l+0i6VqamCQZ8 uUTb6ZDZ5fq5+pgnAonhg03zX1tlDZbfi01JKnEw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728228AbgFVMbV (ORCPT ); Mon, 22 Jun 2020 08:31:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:38010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728107AbgFVMbU (ORCPT ); Mon, 22 Jun 2020 08:31:20 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CA1B206BE; Mon, 22 Jun 2020 12:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592829079; bh=vUsQ4/bIHVn4jBo65OALfNI338jW6zMlkCy7dd1UtUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQhewzvsjTq3cvPrzmIBgb5SttjfYpYAIvQ5Sk32Q6C8nxucZEc7myegU6NDew1Ql Om4NchBLWbGKl0T0gUerAdMSFOJno0IDf+H3x+a1YRaJx5M8asWcogxHQ6vTkHl6nl 7gS0eiC95+Xni+DDX+Xb7uWSTTR/yN282ozy9BK4= Date: Mon, 22 Jun 2020 08:31:18 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Osipenko , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Message-ID: <20200622123118.GF1931@sasha-vm> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200622112321.GB4560@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: >On Sun, Jun 21, 2020 at 07:33:52PM -0400, Sasha Levin wrote: >> On Thu, Jun 18, 2020 at 03:39:30PM +0100, Mark Brown wrote: >> > On Thu, Jun 18, 2020 at 10:30:46AM -0400, Sasha Levin wrote: >> > > On Thu, Jun 18, 2020 at 12:00:23PM +0100, Mark Brown wrote: > >> > > > This is a new feature not a bugfix. > >> > > I saw this patch more as a hardware quirk. > >> > Pretty much any DT property is a hardware quirk :( > >> Which is why we're taking most of them :) > >That's concerning - please don't do this. It's not what stable is >expected to be and there's no guarantee that you're getting all the >changes required to actually make things work. How come? This is one of the things stable rules explicitly call for: "New device IDs and quirks are also accepted". If we're missing anything, the solution is to make sure we stop missing it rather than not take anything to begin with :) -- Thanks, Sasha