Re: [PATCH v11 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Jun 22, 2020 at 01:05:25PM +0100, Shiju Jose wrote:
> CPER records describing a firmware-first error are identified by GUID.
> The ghes driver currently logs, but ignores any unknown CPER records.
> This prevents describing errors that can't be represented by a standard
> entry, that would otherwise allow a driver to recover from an error.
> The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of
> version 2.8).
> 
> patch set
> 1. add a notifier chain for these non-standard/vendor-records
>    in the ghes driver.
> 
> 2. add a driver to handle HiSilicon hip PCIe controller's errors.
>    
> Changes:
> 
> V11:
> 1. Following modifications made by James Morse in the APEI patch
>    for the vendor error record.
>    - Removed kfifo and ghes_gdata_pool. Expanded commit message.
>    
>    Note: Kept the Signed-off-by: James Morse as he is given
>    because I am not sure the right format.

Wait, what?  He doesn't seem to have given any S-o-b in the public
thread.

Signed-off-by means that you handled a patch.  Presumably you are the
maintainer and hopefully you looked at the patch before applying it.
Signed-off-by is like signing a legal document to say that you didn't
add any Top Secrety SCO UNIXWare source code.  Reviewed-by means you
reviewed it and approve.  Acked-by means you approve the patch which
sort of means you are the maintainer or you care about it for some
reason, for example, maybe there was a debate and you like the chosen
approach.

regards,
dan carpenter