Re: [PATCH] hw/acpi: specify 64-bit acpi table

[Igor Mammedov <imammedo@redhat.com>]

On Tue, 16 Jun 2020 13:20:17 -0600
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:

> > > increment the revision to '2' so that these larger addresses are
> > > addressable. This matters because the DSDT revision represents the
> > > maximum capability of all other SSDTs. This is also what arm does.  
> > it was keept at 1 for compat reasons with WindowsXP.
> > by now it is long time EOL, so it might be fine to bump version,
> > but it would be nice to know if this change breaks XP or not?  
> 
> I just installed Windows XP twice, once without the patch and once
> with the patch. The command line I used for this was:
> 
> qemu-system-x86_64 -m 3G -cpu host -enable-kvm -M pc-1.0 -drive file=disk.qcow
> 2 -cdrom en_windows_xp_professional_with_service_pack_3_x86_cd_vl_x14-73974.iso
> 
> Aside from the nostalgia being completely overwhelming, both installs
> were successful, and I was greeted with the terrific bliss.bmp
> background.
I'm not sure runnig test with pc-1.0 is valid, since ACPI tables generated by QEMU
happend around 1.7 time.
Can you retest with latest machine version "-M pc", please?