From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD35C433DF for ; Mon, 22 Jun 2020 15:06:33 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08A4620656 for ; Mon, 22 Jun 2020 15:06:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CCKP6Iy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A4620656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 05MF6Gwk021840; Mon, 22 Jun 2020 17:06:16 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 216177773; Mon, 22 Jun 2020 17:06:16 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 8900C3BAB for ; Mon, 22 Jun 2020 17:06:14 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 05MF6CBk021194 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 22 Jun 2020 17:06:13 +0200 (CEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E33C20716; Mon, 22 Jun 2020 15:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592838370; bh=Y4CpcF3aADqh+pQXARrCx9IJmnrlUGPWQkgvA0aXDAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CCKP6Iy/aswRA9wgZNXlyp1WDg4SxZykY40qDUqdWQ4gzZq2As5ych8GHMpMYeVRn vp8p82C2iMFPP/Nsj5p36r9VTQiYvjYk0bySbR85IDLrIXhgCEiIH/HtvN590bOGl6 b+MoH2N2jQ5ovfnlZZ908qs7t34AhELPRyWPTkTY= Date: Mon, 22 Jun 2020 17:06:05 +0200 From: Greg Kroah-Hartman To: Shuah Khan Message-ID: <20200622150605.GA3828014@kroah.com> References: <20200604164145.173925-1-maennich@google.com> <20200622080345.GD260206@google.com> <0eda607e-4083-46d2-acb8-63cfa2697a71@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0eda607e-4083-46d2-acb8-63cfa2697a71@linuxfoundation.org> X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 22 Jun 2020 17:06:16 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 22 Jun 2020 17:06:13 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Matthias Maennich , YueHaibing , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jeyu@kernel.org, kernel-team@android.com, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote: > On 6/22/20 2:03 AM, Matthias Maennich wrote: > > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote: > > > On 6/4/20 1:31 PM, Julia Lawall wrote: > > > > > > > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote: > > > > > > > > > When running `make coccicheck` in report mode using the > > > > > add_namespace.cocci file, it will fail for files that contain > > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch > > > > > errors out as virtual.ns is not set. > > > > > > > > > > In order to fix that, add the virtual rule nsdeps and only > > > > > do search and > > > > > replace if that rule has been explicitly requested. > > > > > > > > > > In order to make spatch happy in report mode, we also need a > > > > > dummy rule, > > > > > as otherwise it errors out with "No rules apply". Using a script:python > > > > > rule appears unrelated and odd, but this is the shortest I > > > > > could come up > > > > > with. > > > > > > > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule > > > > > when run trough > > > > > `make nsdeps`. > > > > > > > > > > Suggested-by: Julia Lawall > > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed") > > > > > Cc: YueHaibing > > > > > Cc: jeyu@kernel.org > > > > > Cc: cocci@systeme.lip6.fr > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Matthias Maennich > > > > > > > > Acked-by: Julia Lawall > > > > > > > > Shuah reported the problem to me, so you could add > > > > > > > > Reported-by: Shuah Khan > > > > > > > > > > Very cool. No errors with this patch. Thanks for fixing it > > > quickly. > > > > I am happy I could fix that and thanks for confirming. I assume your > > Tested-by could be added? > > Yes > > Tested-by: Shuah Khan > > > > Is somebody willing to take this patch through their tree? > > > > My guess is that these go through kbuild git?? If you want to take this, that's fine with me. But as I had the original file come through my tree, I can take it too. It's up to you, either is ok with me. thanks greg k-h _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68358C433E1 for ; Mon, 22 Jun 2020 15:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42F8020732 for ; Mon, 22 Jun 2020 15:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592838374; bh=Y4CpcF3aADqh+pQXARrCx9IJmnrlUGPWQkgvA0aXDAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TOSb1aoup+Umtk9dekMGYvDKIy2pawgBabmaJKs2z1FX8ekN6a3vO38jpvMmmapGT +qiZzLLOz63E+lItSQehKL3j4cAufc+/aDvrUizFp6EHsFagoMLra1Zaoqi7vbOVfU VpLT4UWzwjGPDBigmUdzYBthDNOBmfEIo4qyMaAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729315AbgFVPGM (ORCPT ); Mon, 22 Jun 2020 11:06:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:53244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729210AbgFVPGL (ORCPT ); Mon, 22 Jun 2020 11:06:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E33C20716; Mon, 22 Jun 2020 15:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592838370; bh=Y4CpcF3aADqh+pQXARrCx9IJmnrlUGPWQkgvA0aXDAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CCKP6Iy/aswRA9wgZNXlyp1WDg4SxZykY40qDUqdWQ4gzZq2As5ych8GHMpMYeVRn vp8p82C2iMFPP/Nsj5p36r9VTQiYvjYk0bySbR85IDLrIXhgCEiIH/HtvN590bOGl6 b+MoH2N2jQ5ovfnlZZ908qs7t34AhELPRyWPTkTY= Date: Mon, 22 Jun 2020 17:06:05 +0200 From: Greg Kroah-Hartman To: Shuah Khan Cc: Matthias Maennich , Julia Lawall , linux-kernel@vger.kernel.org, kernel-team@android.com, YueHaibing , jeyu@kernel.org, cocci@systeme.lip6.fr, stable@vger.kernel.org Subject: Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci Message-ID: <20200622150605.GA3828014@kroah.com> References: <20200604164145.173925-1-maennich@google.com> <20200622080345.GD260206@google.com> <0eda607e-4083-46d2-acb8-63cfa2697a71@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eda607e-4083-46d2-acb8-63cfa2697a71@linuxfoundation.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote: > On 6/22/20 2:03 AM, Matthias Maennich wrote: > > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote: > > > On 6/4/20 1:31 PM, Julia Lawall wrote: > > > > > > > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote: > > > > > > > > > When running `make coccicheck` in report mode using the > > > > > add_namespace.cocci file, it will fail for files that contain > > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch > > > > > errors out as virtual.ns is not set. > > > > > > > > > > In order to fix that, add the virtual rule nsdeps and only > > > > > do search and > > > > > replace if that rule has been explicitly requested. > > > > > > > > > > In order to make spatch happy in report mode, we also need a > > > > > dummy rule, > > > > > as otherwise it errors out with "No rules apply". Using a script:python > > > > > rule appears unrelated and odd, but this is the shortest I > > > > > could come up > > > > > with. > > > > > > > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule > > > > > when run trough > > > > > `make nsdeps`. > > > > > > > > > > Suggested-by: Julia Lawall > > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed") > > > > > Cc: YueHaibing > > > > > Cc: jeyu@kernel.org > > > > > Cc: cocci@systeme.lip6.fr > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Matthias Maennich > > > > > > > > Acked-by: Julia Lawall > > > > > > > > Shuah reported the problem to me, so you could add > > > > > > > > Reported-by: Shuah Khan > > > > > > > > > > Very cool. No errors with this patch. Thanks for fixing it > > > quickly. > > > > I am happy I could fix that and thanks for confirming. I assume your > > Tested-by could be added? > > Yes > > Tested-by: Shuah Khan > > > > Is somebody willing to take this patch through their tree? > > > > My guess is that these go through kbuild git?? If you want to take this, that's fine with me. But as I had the original file come through my tree, I can take it too. It's up to you, either is ok with me. thanks greg k-h