From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: miquel.raynal@bootlin.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] mtd: rawnand: diskonchip: Fix the probe error path" failed to apply to 4.19-stable tree
Date: Mon, 22 Jun 2020 20:48:53 -0400 [thread overview]
Message-ID: <20200623004853.GS1931@sasha-vm> (raw)
In-Reply-To: <159257446611107@kroah.com>
On Fri, Jun 19, 2020 at 03:47:46PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From c5be12e45940f1aa1b5dfa04db5d15ad24f7c896 Mon Sep 17 00:00:00 2001
>From: Miquel Raynal <miquel.raynal@bootlin.com>
>Date: Tue, 19 May 2020 14:59:45 +0200
>Subject: [PATCH] mtd: rawnand: diskonchip: Fix the probe error path
>
>Not sure nand_cleanup() is the right function to call here but in any
>case it is not nand_release(). Indeed, even a comment says that
>calling nand_release() is a bit of a hack as there is no MTD device to
>unregister. So switch to nand_cleanup() for now and drop this
>comment.
>
>There is no Fixes tag applying here as the use of nand_release()
>in this driver predates by far the introduction of nand_cleanup() in
>commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
>which makes this change possible. However, pointing this commit as the
>culprit for backporting purposes makes sense even if it did not intruce
>any bug.
>
>Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
>Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>Cc: stable@vger.kernel.org
>Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-13-miquel.raynal@bootlin.com
Some code refactoring:
59ac276f2227 ("mtd: rawnand: Pass a nand_chip object to nand_release()")
00ad378f304a ("mtd: rawnand: Pass a nand_chip object to nand_scan()")
And movement (drivers/mtd/nand/diskonchip.c ->
drivers/mtd/nand/raw/diskonchip.c) in older branches. I've fixed it up
and queued for 4.19-4.9.
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-06-23 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:47 FAILED: patch "[PATCH] mtd: rawnand: diskonchip: Fix the probe error path" failed to apply to 4.19-stable tree gregkh
2020-06-23 0:48 ` Sasha Levin [this message]
2020-06-23 1:27 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623004853.GS1931@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=miquel.raynal@bootlin.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.