All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: ebiggers@google.com, drosen@google.com, jaegeuk@kernel.org,
	krisman@collabora.co.uk, stable@vger.kernel.org,
	viro@zeniv.linux.org.uk, yuchao0@huawei.com
Subject: Re: FAILED: patch "[PATCH] f2fs: avoid utf8_strncasecmp() with unstable name" failed to apply to 5.7-stable tree
Date: Mon, 22 Jun 2020 21:29:48 -0400	[thread overview]
Message-ID: <20200623012948.GU1931@sasha-vm> (raw)
In-Reply-To: <1592575583131183@kroah.com>

On Fri, Jun 19, 2020 at 04:06:23PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.7-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From fc3bb095ab02b9e7d89a069ade2cead15c64c504 Mon Sep 17 00:00:00 2001
>From: Eric Biggers <ebiggers@google.com>
>Date: Mon, 1 Jun 2020 13:08:05 -0700
>Subject: [PATCH] f2fs: avoid utf8_strncasecmp() with unstable name
>
>If the dentry name passed to ->d_compare() fits in dentry::d_iname, then
>it may be concurrently modified by a rename.  This can cause undefined
>behavior (possibly out-of-bounds memory accesses or crashes) in
>utf8_strncasecmp(), since fs/unicode/ isn't written to handle strings
>that may be concurrently modified.
>
>Fix this by first copying the filename to a stack buffer if needed.
>This way we get a stable snapshot of the filename.
>
>Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups")
>Cc: <stable@vger.kernel.org> # v5.4+
>Cc: Al Viro <viro@zeniv.linux.org.uk>
>Cc: Daniel Rosenberg <drosen@google.com>
>Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>Signed-off-by: Eric Biggers <ebiggers@google.com>
>Reviewed-by: Chao Yu <yuchao0@huawei.com>
>Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

I've grabbed f874fa1c7c79 ("f2fs: split f2fs_d_compare() from
f2fs_match_name()") as a dependency and queued both for 5.7 and 5.4.

-- 
Thanks,
Sasha

  reply	other threads:[~2020-06-23  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 14:06 FAILED: patch "[PATCH] f2fs: avoid utf8_strncasecmp() with unstable name" failed to apply to 5.7-stable tree gregkh
2020-06-23  1:29 ` Sasha Levin [this message]
2020-06-23  5:25   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623012948.GU1931@sasha-vm \
    --to=sashal@kernel.org \
    --cc=drosen@google.com \
    --cc=ebiggers@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jaegeuk@kernel.org \
    --cc=krisman@collabora.co.uk \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.