From: "Fredrik Gustafsson" <fredrik.gustafsson@axis.com>
To: <openembedded-core@lists.openembedded.org>
Cc: <tools-cfpbuild-internal@axis.com>, <hugo.cedervall@axis.com>,
Fredrik Gustafsson <fredrigu@axis.com>
Subject: [PATCH 1/2] nopackages.bbclass: Move to nopackages_base.bbclass
Date: Tue, 23 Jun 2020 13:13:27 +0200 [thread overview]
Message-ID: <20200623111328.5838-2-fredrigu@axis.com> (raw)
In-Reply-To: <20200623111328.5838-1-fredrigu@axis.com>
When for example adding an other package mananger a two rows
deltask do_package_write_PKGMGR
deltask do_package_write_PKGMGR_setscene
is needed to be added to nopackages.bbclass. When adding the new package
manager in a new layer in order to extend poky (rather than forking it)
the whole nopackages.bbclass needs to be copied which is a maintenance
problem. Moving nopackages.bbclass to nopackages.bbclass would make the
new layer just adding an image.bbclass containing:
inherit nopackages_base.bbclass
deltask do_package_write_PKGMGR
deltask do_package_write_PKGMGR_setscene
Which is much easier to maintain.
Signed-off-by: Fredrik Gustafsson <fredrigu@axis.com>
---
meta/classes/nopackages.bbclass | 15 +++------------
meta/classes/nopackages_base.bbclass | 12 ++++++++++++
2 files changed, 15 insertions(+), 12 deletions(-)
create mode 100644 meta/classes/nopackages_base.bbclass
diff --git a/meta/classes/nopackages.bbclass b/meta/classes/nopackages.bbclass
index 559f5078bd..78bbd8c85c 100644
--- a/meta/classes/nopackages.bbclass
+++ b/meta/classes/nopackages.bbclass
@@ -1,12 +1,3 @@
-deltask do_package
-deltask do_package_write_rpm
-deltask do_package_write_ipk
-deltask do_package_write_deb
-deltask do_package_qa
-deltask do_packagedata
-deltask do_package_setscene
-deltask do_package_write_rpm_setscene
-deltask do_package_write_ipk_setscene
-deltask do_package_write_deb_setscene
-deltask do_package_qa_setscene
-deltask do_packagedata_setscene
+# This file should only inherit nopackages_base. This is to make
+# this file easy to extend from an other layer.
+inherit nopackages_base
diff --git a/meta/classes/nopackages_base.bbclass b/meta/classes/nopackages_base.bbclass
new file mode 100644
index 0000000000..e898cef00f
--- /dev/null
+++ b/meta/classes/nopackages_base.bbclass
@@ -0,0 +1,12 @@
+deltask do_package
+deltask do_package_qa
+deltask do_packagedata
+deltask do_package_setscene
+deltask do_package_qa_setscene
+deltask do_packagedata_setscene
+deltask do_package_write_rpm
+deltask do_package_write_deb
+deltask do_package_write_ipk
+deltask do_package_write_rpm_setscene
+deltask do_package_write_deb_setscene
+deltask do_package_write_ipk_setscene
--
2.20.1
next prev parent reply other threads:[~2020-06-23 11:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 11:13 Add package managers as a plugin Fredrik Gustafsson
2020-06-23 11:13 ` Fredrik Gustafsson [this message]
2020-06-23 11:41 ` [OE-core] [PATCH 1/2] nopackages.bbclass: Move to nopackages_base.bbclass Richard Purdie
2020-06-23 11:13 ` [PATCH 2/2] lib/oe: Split package manager code to multiple files Fredrik Gustafsson
2020-06-23 12:02 ` [OE-core] " Richard Purdie
2020-06-23 12:12 ` Fredrik Gustafsson
2020-06-23 12:23 ` Paul Barker
2020-06-23 11:32 ` ✗ patchtest: failure for "nopackages.bbclass: Move to no..." and 1 more Patchwork
2020-06-23 18:50 ` [OE-core] Add package managers as a plugin Denys Dmytriyenko
2020-06-30 15:15 ` Fredrik Gustafsson
2020-06-24 15:18 ` Alex Stewart
2020-06-30 18:38 ` Fredrik Gustafsson
2020-06-30 20:22 ` Alex Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623111328.5838-2-fredrigu@axis.com \
--to=fredrik.gustafsson@axis.com \
--cc=fredrigu@axis.com \
--cc=hugo.cedervall@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tools-cfpbuild-internal@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.