diff for duplicates of <20200623160036.GD3235@minyard.net> diff --git a/a/1.txt b/N1/1.txt index 5759087..c6ed92e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -62,8 +62,8 @@ On Tue, Jun 23, 2020 at 11:40:21PM +0800, Xin Long wrote: > > > addrparms = retval; > > > > > > list_for_each_entry(addr, &bp->address_list, list) { -> > > + if ((PF_INET6 = sk->sk_family) && inet_v6_ipv6only(sk) && -> > > + (AF_INET = addr->a.sa.sa_family)) +> > > + if ((PF_INET6 == sk->sk_family) && inet_v6_ipv6only(sk) && +> > > + (AF_INET == addr->a.sa.sa_family)) > > > + continue; > > > > This does not compile in the latest mainline. sk is not defined. @@ -174,7 +174,7 @@ Anyway, I have a patch I have compiled and tested, I will send that. > > > > >>>>> ssize_t rv; > > > > >>>>> > > > > >>>>> rv = read(s, data, sizeof(data)); -> > > > >>>>> if (rv = -1) { +> > > > >>>>> if (rv == -1) { > > > > >>>>> perror("read"); > > > > >>>>> return -1; > > > > >>>>> } @@ -195,39 +195,39 @@ Anyway, I have a patch I have compiled and tested, I will send that. > > > > >>>>> return err; > > > > >>>>> > > > > >>>>> ls = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol); -> > > > >>>>> if (ls = -1) { +> > > > >>>>> if (ls == -1) { > > > > >>>>> perror("socket"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> optval = 1; > > > > >>>>> if (setsockopt(ls, SOL_SOCKET, SO_REUSEADDR, -> > > > >>>>> (void *)&optval, sizeof(optval)) = -1) { +> > > > >>>>> (void *)&optval, sizeof(optval)) == -1) { > > > > >>>>> perror("setsockopt reuseaddr"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> /* Comment this out and it will work. */ > > > > >>>>> if (setsockopt(ls, IPPROTO_IPV6, IPV6_V6ONLY, &optval, -> > > > >>>>> sizeof(optval)) = -1) { +> > > > >>>>> sizeof(optval)) == -1) { > > > > >>>>> perror("setsockopt ipv6 only"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> err = bind(ls, ai->ai_addr, ai->ai_addrlen); -> > > > >>>>> if (err = -1) { +> > > > >>>>> if (err == -1) { > > > > >>>>> perror("bind"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> err = listen(ls, 5); -> > > > >>>>> if (err = -1) { +> > > > >>>>> if (err == -1) { > > > > >>>>> perror("listen"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> s = accept(ls, NULL, NULL); -> > > > >>>>> if (s = -1) { +> > > > >>>>> if (s == -1) { > > > > >>>>> perror("accept"); > > > > >>>>> return -1; > > > > >>>>> } @@ -252,13 +252,13 @@ Anyway, I have a patch I have compiled and tested, I will send that. > > > > >>>>> return err; > > > > >>>>> > > > > >>>>> s = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol); -> > > > >>>>> if (s = -1) { +> > > > >>>>> if (s == -1) { > > > > >>>>> perror("socket"); > > > > >>>>> return -1; > > > > >>>>> } > > > > >>>>> > > > > >>>>> err = connect(s, ai->ai_addr, ai->ai_addrlen); -> > > > >>>>> if (err = -1) { +> > > > >>>>> if (err == -1) { > > > > >>>>> perror("connect"); > > > > >>>>> return -1; > > > > >>>>> } diff --git a/a/content_digest b/N1/content_digest index bc82c30..c25a760 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,7 +9,7 @@ "ref\0CADvbK_cmFXPcKRNcnNLx3at=yaO53E=6dvzqwvC6UoS+Q2tMJg@mail.gmail.com\0" "From\0Corey Minyard <minyard@acm.org>\0" "Subject\0Re: Strange problem with SCTP+IPv6\0" - "Date\0Tue, 23 Jun 2020 16:00:36 +0000\0" + "Date\0Tue, 23 Jun 2020 11:00:36 -0500\0" "To\0Xin Long <lucien.xin@gmail.com>\0" "Cc\0Michael Tuexen <Michael.Tuexen@lurchi.franken.de>" Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> @@ -83,8 +83,8 @@ "> > > addrparms = retval;\n" "> > >\n" "> > > list_for_each_entry(addr, &bp->address_list, list) {\n" - "> > > + if ((PF_INET6 = sk->sk_family) && inet_v6_ipv6only(sk) &&\n" - "> > > + (AF_INET = addr->a.sa.sa_family))\n" + "> > > + if ((PF_INET6 == sk->sk_family) && inet_v6_ipv6only(sk) &&\n" + "> > > + (AF_INET == addr->a.sa.sa_family))\n" "> > > + continue;\n" "> >\n" "> > This does not compile in the latest mainline. sk is not defined.\n" @@ -195,7 +195,7 @@ "> > > > >>>>> ssize_t rv;\n" "> > > > >>>>>\n" "> > > > >>>>> rv = read(s, data, sizeof(data));\n" - "> > > > >>>>> if (rv = -1) {\n" + "> > > > >>>>> if (rv == -1) {\n" "> > > > >>>>> perror(\"read\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" @@ -216,39 +216,39 @@ "> > > > >>>>> return err;\n" "> > > > >>>>>\n" "> > > > >>>>> ls = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);\n" - "> > > > >>>>> if (ls = -1) {\n" + "> > > > >>>>> if (ls == -1) {\n" "> > > > >>>>> perror(\"socket\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> optval = 1;\n" "> > > > >>>>> if (setsockopt(ls, SOL_SOCKET, SO_REUSEADDR,\n" - "> > > > >>>>> (void *)&optval, sizeof(optval)) = -1) {\n" + "> > > > >>>>> (void *)&optval, sizeof(optval)) == -1) {\n" "> > > > >>>>> perror(\"setsockopt reuseaddr\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> /* Comment this out and it will work. */\n" "> > > > >>>>> if (setsockopt(ls, IPPROTO_IPV6, IPV6_V6ONLY, &optval,\n" - "> > > > >>>>> sizeof(optval)) = -1) {\n" + "> > > > >>>>> sizeof(optval)) == -1) {\n" "> > > > >>>>> perror(\"setsockopt ipv6 only\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> err = bind(ls, ai->ai_addr, ai->ai_addrlen);\n" - "> > > > >>>>> if (err = -1) {\n" + "> > > > >>>>> if (err == -1) {\n" "> > > > >>>>> perror(\"bind\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> err = listen(ls, 5);\n" - "> > > > >>>>> if (err = -1) {\n" + "> > > > >>>>> if (err == -1) {\n" "> > > > >>>>> perror(\"listen\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> s = accept(ls, NULL, NULL);\n" - "> > > > >>>>> if (s = -1) {\n" + "> > > > >>>>> if (s == -1) {\n" "> > > > >>>>> perror(\"accept\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" @@ -273,13 +273,13 @@ "> > > > >>>>> return err;\n" "> > > > >>>>>\n" "> > > > >>>>> s = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);\n" - "> > > > >>>>> if (s = -1) {\n" + "> > > > >>>>> if (s == -1) {\n" "> > > > >>>>> perror(\"socket\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" "> > > > >>>>>\n" "> > > > >>>>> err = connect(s, ai->ai_addr, ai->ai_addrlen);\n" - "> > > > >>>>> if (err = -1) {\n" + "> > > > >>>>> if (err == -1) {\n" "> > > > >>>>> perror(\"connect\");\n" "> > > > >>>>> return -1;\n" "> > > > >>>>> }\n" @@ -304,4 +304,4 @@ "> > > > >>\n" > > > > -e08f519b9f90a61b930e702f66866f1c1841b0181350b962e2d36647776799da +ee2189cce8df2bb09fbba66fc766a368e29e6198c8f8e474f778aef05b31e4f5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.