From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp4176164lfm; Tue, 23 Jun 2020 08:25:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw1wrNVGmZ0uRdvTlJc5U6q3P2CkBgRZM6FbcdDp5HxGg7uQPfi/HzpPn3KF5Sci8BPGQ9 X-Received: by 2002:aa7:d0c5:: with SMTP id u5mr21884685edo.51.1592925952387; Tue, 23 Jun 2020 08:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592925952; cv=none; d=google.com; s=arc-20160816; b=MiZpypMpQ2x73dWnrvixNJtFT5bhqdaCvEl2ej/NHurJu3ybjHxJDnjgnNBHvjivuw jMZYZe61bTFBvAQH9NMBwqoMatQ8gbBWFfQcYJrD1+kqgpmwSekEYwSL7Suq9F6fUd34 E5K9nglTUIUeoQxCfJErgCDA18O4pixno3QXVnol6PCBo+Am67fTCjvmqKR7iJMv6nRO /GOiBaXGBMSQi7tYoprUI9pel/yvtGxpCOJFt/A9c2aT4eRGxu9yqsqSK60dyBlOyApM cMc5xB++SSn0bHcx9zyfyCZleesZmoTtzxeUelN+kQtldyixNBTNtxbYymCLHkeCW0Eb JmmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=jBAXVsoXXh0/I2Sku0Zs4vjlE275yD39tzwQsaS7Dok=; b=CjFev1yrh/lBNFJ19Hb5d4IT0nwoCizPJ5Xb1m6qQ2FePUc9ThQ5Ki+TzcL7i0j40l YdWuRtbqKrdO1VUtpE+cW9DXW5Lls7XSZoW85OpdBsydh8JFQ+aPzTBndZlXqW5JD239 Y5PsRVE02V7JOhMLt+kOS9X9OJmtEOCSdkL+2yEDentiaC6sIDiyQXyoXuOJoL30MtX2 iYRGbez4fUt0uZzqOsPrPcG6W78S7qGS0fhaASjHdQhqTnSIEuBtJzP7bmUqZz5x7B45 xRVmV13pU5ukheSk8qJuSR3Pg4vOHCwh7NbhIuJSkaRTKdjj/npWhlNBOMWU3RS40hBD 0otQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a3nZagn7; spf=pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si10824437edw.365.2020.06.23.08.25.52; Tue, 23 Jun 2020 08:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a3nZagn7; spf=pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732982AbgFWPZv (ORCPT + 5 others); Tue, 23 Jun 2020 11:25:51 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40140 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732781AbgFWPZv (ORCPT ); Tue, 23 Jun 2020 11:25:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592925949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jBAXVsoXXh0/I2Sku0Zs4vjlE275yD39tzwQsaS7Dok=; b=a3nZagn72f6P0zZqZoYWCPnFrl8K8Mk4LQ/za22lPCLjpGpvAwBgRdTp6CMZiZ4JrVHsYx 6c+24Pzv/wNvGsz3N+ARTsZhttq/1q341+dw65t793/4leg08wTxMBl8SPSgNTEAVrrmzx ZAYcclAMLb+Ew57Dw2VgKhiK5bNmWTo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-A9yNL1DHOtOBrK8pOcq0nA-1; Tue, 23 Jun 2020 11:25:47 -0400 X-MC-Unique: A9yNL1DHOtOBrK8pOcq0nA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0FBF107ACF2; Tue, 23 Jun 2020 15:25:45 +0000 (UTC) Received: from gondolin (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3CDB60F8D; Tue, 23 Jun 2020 15:25:31 +0000 (UTC) Date: Tue, 23 Jun 2020 17:25:29 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Aleksandar Markovic , Aurelien Jarno , David Hildenbrand , Christian Borntraeger , Aleksandar Rikalo , Richard Henderson , qemu-s390x@nongnu.org, David Gibson , Peter Maydell , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Halil Pasic , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Marcelo Tosatti , Thomas Huth Subject: Re: [PATCH 1/7] accel/kvm: Let kvm_check_extension use global KVM state Message-ID: <20200623172529.4ebe956c.cohuck@redhat.com> In-Reply-To: <20200623105052.1700-2-philmd@redhat.com> References: <20200623105052.1700-1-philmd@redhat.com> <20200623105052.1700-2-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: lt9qq7jKsYdL On Tue, 23 Jun 2020 12:50:46 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > As KVM supported extentions those should be the same for > all VMs, it is safe to directly use the global kvm_state > in kvm_check_extension(). >=20 > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index f24d7da783..934a7d6b24 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -913,7 +913,7 @@ int kvm_check_extension(KVMState *s, unsigned int ext= ension) > { > int ret; > =20 > - ret =3D kvm_ioctl(s, KVM_CHECK_EXTENSION, extension); > + ret =3D kvm_ioctl(kvm_state, KVM_CHECK_EXTENSION, extension); > if (ret < 0) { > ret =3D 0; > } Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CF2C433DF for ; Tue, 23 Jun 2020 15:26:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B89C2070E for ; Tue, 23 Jun 2020 15:26:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DEFBQebI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B89C2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnkp1-0001nt-Gd for qemu-devel@archiver.kernel.org; Tue, 23 Jun 2020 11:26:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnko9-0000AY-Bq for qemu-devel@nongnu.org; Tue, 23 Jun 2020 11:25:57 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55457 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jnko6-0000Cz-KD for qemu-devel@nongnu.org; Tue, 23 Jun 2020 11:25:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592925953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jBAXVsoXXh0/I2Sku0Zs4vjlE275yD39tzwQsaS7Dok=; b=DEFBQebIjg/lTtfdnGPbvUXIpH4C1vlsPdyzhNYlFhWYId+SdVcSaGINKZ0y3cswu4y2vV 0Y2VzxGC6ZtBMz3bFZCnX3lom3gqRrbUm0kwZ/cZTwlKhBRO9tRzhfBTOAUjGLvkfx2Pbf R1bYb+tSr5k5G7zDx3fnWTzGGv262R8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-A9yNL1DHOtOBrK8pOcq0nA-1; Tue, 23 Jun 2020 11:25:47 -0400 X-MC-Unique: A9yNL1DHOtOBrK8pOcq0nA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0FBF107ACF2; Tue, 23 Jun 2020 15:25:45 +0000 (UTC) Received: from gondolin (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3CDB60F8D; Tue, 23 Jun 2020 15:25:31 +0000 (UTC) Date: Tue, 23 Jun 2020 17:25:29 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 1/7] accel/kvm: Let kvm_check_extension use global KVM state Message-ID: <20200623172529.4ebe956c.cohuck@redhat.com> In-Reply-To: <20200623105052.1700-2-philmd@redhat.com> References: <20200623105052.1700-1-philmd@redhat.com> <20200623105052.1700-2-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Received-SPF: pass client-ip=207.211.31.81; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/23 02:54:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Marcelo Tosatti , Eduardo Habkost , kvm@vger.kernel.org, David Hildenbrand , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , Aleksandar Markovic , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Thomas Huth , Paolo Bonzini , David Gibson , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 23 Jun 2020 12:50:46 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > As KVM supported extentions those should be the same for > all VMs, it is safe to directly use the global kvm_state > in kvm_check_extension(). >=20 > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index f24d7da783..934a7d6b24 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -913,7 +913,7 @@ int kvm_check_extension(KVMState *s, unsigned int ext= ension) > { > int ret; > =20 > - ret =3D kvm_ioctl(s, KVM_CHECK_EXTENSION, extension); > + ret =3D kvm_ioctl(kvm_state, KVM_CHECK_EXTENSION, extension); > if (ret < 0) { > ret =3D 0; > } Reviewed-by: Cornelia Huck