From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F878C433DF for ; Tue, 23 Jun 2020 20:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 149D32070E for ; Tue, 23 Jun 2020 20:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944072; bh=JT7YxV6z/6qiwExiVMHHGnzReWH50EhdvoD/VQr3wiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pmaHkZqODv2UbL/s+6Y8oGotpaDqgDXktkOcBuPr+w2dfDu5s/L0hul2nqB2foRrS felbRJNtlEdVeJCYg5KT6XqVqSG79rvAKBd5Xv3piD1WwwofmH4z5OssZYe6y+Qkze ilJg/newei0ILyX7bna2e7xdFEqrJHWYw/Pkpywk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389269AbgFWU1t (ORCPT ); Tue, 23 Jun 2020 16:27:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:47346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390788AbgFWU1o (ORCPT ); Tue, 23 Jun 2020 16:27:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D1F92064B; Tue, 23 Jun 2020 20:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944064; bh=JT7YxV6z/6qiwExiVMHHGnzReWH50EhdvoD/VQr3wiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L67PAqsSR+ubxEcyUe2z43DLRaG/VrBr69465STczqROwaiGxU1qf2H7YxNXXReen pDnJPch0zGWVv/qY6ogh2Ht9ou+nIWjqPNyke3sNkpX2Bo3BR3wGPQn1ueOg+BjgBW uU4znbUkg3sBDMi3gT09GcNP+dRF2vSre3X8t+a8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Suganath Prabu S , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 131/314] scsi: mpt3sas: Fix double free warnings Date: Tue, 23 Jun 2020 21:55:26 +0200 Message-Id: <20200623195345.120586545@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195338.770401005@linuxfoundation.org> References: <20200623195338.770401005@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suganath Prabu S [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ] Fix following warning from Smatch static analyser: drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->hpr_lookup' double freed drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->internal_lookup' double freed Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com Reported-by: Dan Carpenter Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 752b71cfbe12c..7fd1d731555f9 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4777,7 +4777,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) } kfree(ioc->hpr_lookup); + ioc->hpr_lookup = NULL; kfree(ioc->internal_lookup); + ioc->internal_lookup = NULL; if (ioc->chain_lookup) { for (i = 0; i < ioc->scsiio_depth; i++) { for (j = ioc->chains_per_prp_buffer; -- 2.25.1