From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DFAC433DF for ; Tue, 23 Jun 2020 20:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A9D22072E for ; Tue, 23 Jun 2020 20:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944221; bh=V/s8NPxg6JfdnXjqV+GFshr1cIzxmfG5AaSgnm8hZIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=z1jO1WYQhi+rKl8mWPUkuV/Dijke4R8rqTx5qtCYROdcTicrbNviB4O6Vndmcl1Tg 167MyQVxdnMk5nal9cyECDwwhZQMsFQ/OXTAHUOAa4wVKx5S/lTfV3iDgc7glAyubi 6yTIYukHndkdggq2p+hw+2c9TXCaumtceXUhgOu8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389451AbgFWUaT (ORCPT ); Tue, 23 Jun 2020 16:30:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:50302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391044AbgFWUaG (ORCPT ); Tue, 23 Jun 2020 16:30:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DFFC206C3; Tue, 23 Jun 2020 20:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944207; bh=V/s8NPxg6JfdnXjqV+GFshr1cIzxmfG5AaSgnm8hZIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YjFTDyoEwpAyGKFJluu7Zz21bnWSVkdQP6c5Tor+G2NG/1DrlGYUutqA7h5f9XF5g c3oVJJVYKhNcpFUnkfXW3WFwhvqRWJJKHp+apCr0lRy14JpCxGV/Yo/m/ESRoyVBRo MH5u8a0M8q0s22+3Bhbt6ndmHjXZt5pE8fZ7PklA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stanley Chu , Can Guo , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 214/314] scsi: ufs: Dont update urgent bkops level when toggling auto bkops Date: Tue, 23 Jun 2020 21:56:49 +0200 Message-Id: <20200623195349.126633596@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195338.770401005@linuxfoundation.org> References: <20200623195338.770401005@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Can Guo [ Upstream commit be32acff43800c87dc5c707f5d47cc607b76b653 ] Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime. But it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled. Link: https://lore.kernel.org/r/1590632686-17866-1-git-send-email-cang@codeaurora.org Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") Reviewed-by: Stanley Chu Signed-off-by: Can Guo Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index bc73181b0405a..2b6853c7375c9 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5101,7 +5101,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err = ufshcd_enable_auto_bkops(hba); else err = ufshcd_disable_auto_bkops(hba); - hba->urgent_bkops_lvl = curr_status; out: return err; } -- 2.25.1