From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3DEC433DF for ; Tue, 23 Jun 2020 21:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8430E2072E for ; Tue, 23 Jun 2020 21:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592948287; bh=HA8aiIuaasPxl1vbmOhAxA5aPPqvNiOAcyQJmQvdG/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LJiAPtFjq155LGaikG855NnA5xtJfxl039SMYalsP3kjVxGBdE1OPsnw9izzGQd6q 5oqyXFyR9X4qYe5RKjx7Ru/YqOCoHa8A4xnSs/aIlkIha/GA2rWkxe01YRkH2JOi8N YRFzZtpw2UA8EaOkW2qhO8M/Ww57dhJvI2bWZ3yE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393641AbgFWViF (ORCPT ); Tue, 23 Jun 2020 17:38:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:49566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388107AbgFWUIf (ORCPT ); Tue, 23 Jun 2020 16:08:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92FE22078A; Tue, 23 Jun 2020 20:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592942915; bh=HA8aiIuaasPxl1vbmOhAxA5aPPqvNiOAcyQJmQvdG/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ey5p5ot4IaxpWGusCbOw2AtKtuZSKzsLMwN+2hFgPBuwl7s9krAaB5Mk0a5l7lz2c 5NCNsMjUGIqQcrlsg20LM9NTMwFSCyNVgI9LXEN8xrXxGuBXrV+vgKMMqL5F6TpX5n WSjO08W8ut5DbQqh4TohKGrfXxFg1mKAiEqSSMfk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.7 186/477] f2fs: fix potential use-after-free issue Date: Tue, 23 Jun 2020 21:53:03 +0200 Message-Id: <20200623195416.379459620@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit f3494345ce9999624b36109252a4bf5f00e51a46 ] In error path of f2fs_read_multi_pages(), it should let last referrer release decompress io context memory, otherwise, other referrer will cause use-after-free issue. Fixes: 4c8ff7095bef ("f2fs: support data compression") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/data.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index cdf2f626bea7a..10491ae1cb850 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2130,16 +2130,16 @@ submit_and_realloc: page->index, for_write); if (IS_ERR(bio)) { ret = PTR_ERR(bio); - bio = NULL; dic->failed = true; if (refcount_sub_and_test(dic->nr_cpages - i, - &dic->ref)) + &dic->ref)) { f2fs_decompress_end_io(dic->rpages, cc->cluster_size, true, false); - f2fs_free_dic(dic); + f2fs_free_dic(dic); + } f2fs_put_dnode(&dn); - *bio_ret = bio; + *bio_ret = NULL; return ret; } } -- 2.25.1