All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/nginx: add stream split clients option
Date: Tue, 23 Jun 2020 23:18:40 +0200	[thread overview]
Message-ID: <20200623211840.GC2351@scaer> (raw)
In-Reply-To: <20200623203526.1024367-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2020-06-23 22:35 +0200, Fabrice Fontaine spake thusly:
> stream split clients module has been added in version 1.11.3 with
> https://github.com/nginx/nginx/commit/6c2b086d0e10cab769f9321998dcb631796ec49b
> and is enabled by default, add an option to be able to disable it
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

But see a little nit below...

> ---
>  package/nginx/Config.in | 6 ++++++
>  package/nginx/nginx.mk  | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/package/nginx/Config.in b/package/nginx/Config.in
> index 9f742e3e6b..eba0d30329 100644
> --- a/package/nginx/Config.in
> +++ b/package/nginx/Config.in
> @@ -364,6 +364,12 @@ config BR2_PACKAGE_NGINX_STREAM_MAP_MODULE
>  	help
>  	  Enable ngx_stream_map_module
>  
> +config BR2_PACKAGE_NGINX_STREAM_SPLIT_CLIENTS_MODULE
> +	bool "ngx_stream_split_client_module"
> +	default y
> +	help
> +	  Enable ngx_stream_split_clients_module

I know you only adhered to the existing options, but I find a help text
that just repeats the prompt, to be totally useless.

I kept it as-is to match the rest of the file, though.

Thanks! :-)

Regards,
Yann E. MORIN.

>  config BR2_PACKAGE_NGINX_STREAM_RETURN_MODULE
>  	bool "ngx_stream_return_module"
>  	default y
> diff --git a/package/nginx/nginx.mk b/package/nginx/nginx.mk
> index 52b91bcde5..db63531dd6 100644
> --- a/package/nginx/nginx.mk
> +++ b/package/nginx/nginx.mk
> @@ -239,6 +239,7 @@ NGINX_CONF_OPTS += \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_ACCESS_MODULE),,--without-stream_access_module) \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_GEO_MODULE),,--without-stream_geo_module) \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_MAP_MODULE),,--without-stream_map_module) \
> +	$(if $(BR2_PACKAGE_NGINX_STREAM_SPLIT_CLIENTS_MODULE),,--without-stream_split_clients_module) \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_RETURN_MODULE),,--without-stream_return_module) \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_UPSTREAM_HASH_MODULE),,--without-stream_upstream_hash_module) \
>  	$(if $(BR2_PACKAGE_NGINX_STREAM_UPSTREAM_LEAST_CONN_MODULE),,--without-stream_upstream_least_conn_module) \
> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-06-23 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 20:35 [Buildroot] [PATCH 1/1] package/nginx: add stream split clients option Fabrice Fontaine
2020-06-23 21:18 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623211840.GC2351@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.