From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15321C433DF for ; Wed, 24 Jun 2020 05:37:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E133D20768 for ; Wed, 24 Jun 2020 05:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592977056; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VCoP+fErum3o1UEzQObCOXxQjrl0fF8PNLUeQytTgyKVNtquEfxj80NHgJhHDmDyI /8vElIYiRe/2LRmVIlwO6T5A9CdrApTwp9ez8KB+iLU/VemZqWHDao3WB33CM2BASH t94tUG5kPBwzKV6N6+2KFu/BGeM0F+8brYSl0cfU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388873AbgFXFhc (ORCPT ); Wed, 24 Jun 2020 01:37:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:54570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388470AbgFXFhb (ORCPT ); Wed, 24 Jun 2020 01:37:31 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC0C82072E; Wed, 24 Jun 2020 05:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592977051; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ME2/ILyRl01EO6yDPEjuIw5z41jE6WT0YL/dZxeFp1FPcCqTGoXmWlZASWXMdQg+d Gg6ZXHBJaopVsT69BCF292QvgQpMxHWYMvgoHHUbOyO2xDDrO8HZyvDEPplfoZjCZF oVsC9NaAewstXOI+yLeiPyQ9MDInXF4S2T12EQBY= Date: Tue, 23 Jun 2020 22:37:29 -0700 From: Eric Biggers To: Daniel Rosenberg Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v9 1/4] unicode: Add utf8_casefold_hash Message-ID: <20200624053729.GE844@sol.localdomain> References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-2-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624043341.33364-2-drosen@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. It would be helpful to add a few more details in this commit message. Somewhat along the lines of: ->d_hash() for casefolding currently allocates memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk mode, this is unreliable and inefficient, and this patch allows solving that problem by removing the need to allocate memory. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E160C433DF for ; Wed, 24 Jun 2020 05:37:44 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DC192072E for ; Wed, 24 Jun 2020 05:37:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Q1b3WOty"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="dIiPyMAS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ME2/ILyR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DC192072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jny6Q-0008DJ-M4; Wed, 24 Jun 2020 05:37:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jny6P-0008DB-21 for linux-f2fs-devel@lists.sourceforge.net; Wed, 24 Jun 2020 05:37:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; b=Q1b3WOtyPF8UUz1qeZ5qQgX4Py UrQUv3mvUv+Idg5BOBnzm5kFfGvaayC9DwHZAbWxLuFX4/a0eAlw2m3B1NopZwduEh3jwWYRV9sy7 PhPna0WQfMq7C0+7JJHFI6KGUFCTLS1fEODs6iBv2OMJB5RpJ3tWOp7mfDVKuYLUx2Co=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; b=dIiPyMASadj7ws+7blRP4vs+sj j8LUxtIPjUcjxup2K0VrCtst4RnHaVI239PMBqgSxFVbpyNOVt/WTFmzZIiySf0N1RdpJvnwaPY5t Fj6QNF4RRaYkRnIhrqLBmOYJ070kA6u93BhFv5aHJYyBBibaSjCiZkWHdQK0WDTcK9i4=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jny6O-00DiaD-26 for linux-f2fs-devel@lists.sourceforge.net; Wed, 24 Jun 2020 05:37:40 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC0C82072E; Wed, 24 Jun 2020 05:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592977051; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ME2/ILyRl01EO6yDPEjuIw5z41jE6WT0YL/dZxeFp1FPcCqTGoXmWlZASWXMdQg+d Gg6ZXHBJaopVsT69BCF292QvgQpMxHWYMvgoHHUbOyO2xDDrO8HZyvDEPplfoZjCZF oVsC9NaAewstXOI+yLeiPyQ9MDInXF4S2T12EQBY= Date: Tue, 23 Jun 2020 22:37:29 -0700 From: Eric Biggers To: Daniel Rosenberg Message-ID: <20200624053729.GE844@sol.localdomain> References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-2-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624043341.33364-2-drosen@google.com> X-Headers-End: 1jny6O-00DiaD-26 Subject: Re: [f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. It would be helpful to add a few more details in this commit message. Somewhat along the lines of: ->d_hash() for casefolding currently allocates memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk mode, this is unreliable and inefficient, and this patch allows solving that problem by removing the need to allocate memory. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E4DC433DF for ; Wed, 24 Jun 2020 05:38:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E87E2072E for ; Wed, 24 Jun 2020 05:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T0x4EI7d"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ME2/ILyR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E87E2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6Vbfn+3IdDWDuv5e07HLKkIB+N7K056Z3D5dx6zg1Xo=; b=T0x4EI7dV6O7cJPDtzSrCLVkC H8TUzGOCxaXF+62ifQhQ7/8ffCiqQDFBdqclUAm9uitdGTVL2xxmx2fAUB+IhUO/ECdx66ptgJuOr z0qAJpcAVFAaBFNefyjKDQDmXLvntDNDBinJA0wKSE4Jo24abpYrl10v5xTEKznmRQ6Jo8b0EKBSV CJcmF0vSZsKk/IX8EMEdsPWmUvW423QdJiA8U1DPhmiVrXrtDHyC2JvyAYDnxmZIWu2x/ZkxhpExK YXlNP5o2M54CFGSvhPT+Zq3qnnZaRmA2dIb413SAMcjxHZFYmp57fNAVQhl/NDFk39gM9botq6Zw/ R+YKDYnRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jny6I-0007S1-Qf; Wed, 24 Jun 2020 05:37:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jny6G-0007Qz-7E for linux-mtd@lists.infradead.org; Wed, 24 Jun 2020 05:37:32 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC0C82072E; Wed, 24 Jun 2020 05:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592977051; bh=wb4QukjekILuiNOvt3WtAggRANvs3/DPlF6kk/OZN9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ME2/ILyRl01EO6yDPEjuIw5z41jE6WT0YL/dZxeFp1FPcCqTGoXmWlZASWXMdQg+d Gg6ZXHBJaopVsT69BCF292QvgQpMxHWYMvgoHHUbOyO2xDDrO8HZyvDEPplfoZjCZF oVsC9NaAewstXOI+yLeiPyQ9MDInXF4S2T12EQBY= Date: Tue, 23 Jun 2020 22:37:29 -0700 From: Eric Biggers To: Daniel Rosenberg Subject: Re: [PATCH v9 1/4] unicode: Add utf8_casefold_hash Message-ID: <20200624053729.GE844@sol.localdomain> References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-2-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624043341.33364-2-drosen@google.com> X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , Chao Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. It would be helpful to add a few more details in this commit message. Somewhat along the lines of: ->d_hash() for casefolding currently allocates memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk mode, this is unreliable and inefficient, and this patch allows solving that problem by removing the need to allocate memory. - Eric ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/