From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D935FC433E0 for ; Wed, 24 Jun 2020 08:37:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A66882088E for ; Wed, 24 Jun 2020 08:37:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SedGmTrZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A66882088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eyH8VaSc0ERdzOlfJULf7j1BIaocngrUiIL2PsnUFds=; b=SedGmTrZXmW4owr1MIDuULH4P 9EqrAvCtY0ABMcbwe0lr0bP9pWBgy3yWsBBcAe8ynjuWYW0ytxr6cO4XkBACKTWNrIMZMvTErFCF3 uXWjrNeXJH7oH85RoHHahLj3bXInEraNk6PWvVzyG3VuzB9XdmQ8SxR6KREKHz5fYLcbXGvhXA4kn vQi8HnHehFGbK6uhHML/Ar4XlUNsZECvPiDNGJrjoLpy69kVVCGAlFWaNzkMAZdp1zh+ZvtCtL4FE NZtBzNtJInk5Z93P+SvGQ0K0A9xmyHgquRJiDnRbCepbU/E2mXB5qPQxUc31c7L8xdzPFiN5wWUhg 2yehI4nog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo0ui-0001fG-Sx; Wed, 24 Jun 2020 08:37:48 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo0ug-0001eS-JR for linux-nvme@lists.infradead.org; Wed, 24 Jun 2020 08:37:47 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id ADF5F68B02; Wed, 24 Jun 2020 10:37:43 +0200 (CEST) Date: Wed, 24 Jun 2020 10:37:43 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 3/3] nvme-rdma: assign completion vector correctly Message-ID: <20200624083743.GA23529@lst.de> References: <20200623145525.1586-1-maxg@mellanox.com> <20200623145525.1586-4-maxg@mellanox.com> <20200623152236.GA3072004@mellanox.com> <543adcc9-fda0-abb2-c37a-fb961d65c5cd@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yaminf@mellanox.com, Sagi Grimberg , idanb@mellanox.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, shlomin@mellanox.com, Jason Gunthorpe , kbusch@kernel.org, ogerlitz@mellanox.com, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 11:34:22AM +0300, Max Gurtovoy wrote: > > On 6/23/2020 8:34 PM, Sagi Grimberg wrote: >> >>>> The completion vector index that is given during CQ creation can't >>>> exceed the number of support vectors by the underlying RDMA device. This >>>> violation currently can accure, for example, in case one will try to >>>> connect with N regular read/write queues and M poll queues and the sum >>>> of N + M > num_supported_vectors. This will lead to failure in establish >>>> a connection to remote target. Instead, in that case, share a completion >>>> vector between queues. >>> >>> That sounds like a RC patch? Where is the fixes line? Why is it in >>> this series? >> >> Agree, this should be sent as a separate patch. > > The reason I sent it in 1 series is to avoid conflicts. Since all the > patches can go to nvme-5.8, I tried to make life easier. > > We can do it separately of course. > > Christoph, > > would you like to merge patches 1+2 from this series or should I send them > again as well ? I don't think 1+2 are 5.8 material, so please just resend 3 standalone for now, and then resend 1+2 once I've merged it and rebased nvme-5.9 on top of nvme-5.8. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme