[Buildroot] [PATCH v2] package/irrlicht: fix libraries linking

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Tue, 23 Jun 2020 20:08:47 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> >> Due to the fact that it points to the host system libraries. This -L
> >> argument is set correctly within package makefile.  
> > Yes, of course. My question is why do you have two patches? They touch
> > exactly the same line, simply do the change in two steps instead of
> > one. Am I missing something here ?  
> Ah, I didn't want to combine everything into one patch because there 
> were 2 different changes (adding keyword and removing paths) but I'm 
> gonna combine it into one patch then.

OK, it's true you can see it as: one allows to override the LDFLAGS,
the other drops a bogus hardcoded path.


> >>> IRRLICHT_CONF_OPTS += CPPFLAGS="$(IRRLICHT_CPPFLAGS)"  
> >> Good hint, I was thinking about a bit different approach but it wasn't
> >> working as I expected therefore I did it as it's above.  
> > So I guess you'll rework accordingly? If needed, you can also have a
> > preparation patch that reworks this IRRLICHT_CPPFLAGS thing for the
> > NEON stuff, and then another patch that fixes the library linking issue.
> >
> > Thomas  
> 
> It turned out that -I$(STAGING_DIR)/usr/include isn't necessary anymore 
> so I've decided not to touch that.

-I$(STAGING_DIR)/usr/include is definitely useless as it's the default
search path for headers for the Buildroot cross-compiler, but that's
not what you were adding: you were adding
-I$(STAGING_DIR)/usr/include/X11R6, which is not in the default search
path for headers.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com