From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13861C433E0 for ; Wed, 24 Jun 2020 11:26:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D363C20836 for ; Wed, 24 Jun 2020 11:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vXq9kR52"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h+qiZfi0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D363C20836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JRlJNBEXTr019+X5vIBPPnPWiLj/0yvg9FT4GyTUJ8U=; b=vXq9kR52Hs8uF/P0j/rICn0Ss JYBEdF0L1HYkzOyAGZXfK6AUMZ8NfG+NEIIKLiQ7H6rlfcutNPcVICj8eVHhM90U6/VxzaUCPY7l0 dlfXCa+4/1hVlKmF79zSzpom2uAGka9xeEl7JBr3xVxunWPit9A3wS2y5rLRYWKJSG1IQ0rPZCqLG eYg/Z9ZhXBZm4QDe5v1PiJ0ME6bqZ6K9/zbMjLZmeP9WzyIl3py6StIxtVMXMHt2hqeeW3HK2f8+U xiop4zSxPR2rxkyVNONnzgNpsHIZqnK1UlRHka9016HEPCXmhSI+n8SaL7zA7fO07KQ8XlnZExRE/ cesAc+C8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo3Vu-00016f-R7; Wed, 24 Jun 2020 11:24:22 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo3Vr-00015K-8y for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 11:24:20 +0000 Received: by mail-wm1-x342.google.com with SMTP id o8so1961580wmh.4 for ; Wed, 24 Jun 2020 04:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NrvSiaDLXTBfKnuOt7hk8LUvf/vD6JGQ7WAbFA5i7Uc=; b=h+qiZfi0OhOnDkgTLpZizeUC5IOa97wx3ik8VofmQ5pfxMjOrV/QZdQ1bzH0PCVdiU UgreOMhRLysmM+bBtebPY7anIyh5Ho7OoqBtQmM4nX9hm9SZdRD6PwLqtvezCvD5x2bP yKLL3oYAOG9YVSUhAPv2B0YkFFu+XrIW2mOMZL0AxwspP7uIhMzfAKKRW5Sjn3PfuI7I 8tUEK+4WbXF6HcnEghMiSEhm2Z6Z58auYOW96L/YLupOfUvseYw9YDjMWDUdRzEAqj/T mPxbp9qt//mWBrqgyYQmdqSzcji9eNyItiQcmo1Ts9oa2hmbhVVJiBaLSzhtiyZR1Cab UiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NrvSiaDLXTBfKnuOt7hk8LUvf/vD6JGQ7WAbFA5i7Uc=; b=dyLEoSgvIk4G4/sfLizRmom8rl0YqtUa2bFF5y0kVhmqyDYVCsIaLRl3jZTSJF+nyA tVYQ/1+QeRZEeevo309dd57ddwfYUIgg4RZQs3F8u31FKSEiNlIMv7bZXBGZJVNDrGoG gN6ZkzTQzkhuujy5HSp1faEiGCrCimNs5CqoN6VWZ6KreRcnXpEEnDuAq/SffYd40i8C 9yfEsEpo/OBDlXzPrs/b+PBjcxLoAYYqWRXzxKz1qtpkgiwQa/710HRYXf7JCI48oI0T VLnIptUVQhkSeYF+83Qqtm9NVKddslGX6FmviEc60DIZpVn6Slf6/T+GqU/o2/XKRLw6 EF+A== X-Gm-Message-State: AOAM5319ezKRlDHKYL9adY8NkRIUo96azkoTHBxUM3X5TVrNYW5Fa0eo XOu12Fq8E4GF/UKqo5WPM+0SAyb4dbM= X-Google-Smtp-Source: ABdhPJxnvJ/bAKboWQS8u3ig+E2OSp3FrtA0y0gJWgzooZABsBXHuo/PhR/sGO75JnZcwGDW//Wkaw== X-Received: by 2002:a7b:c4c3:: with SMTP id g3mr8696211wmk.126.1592997857631; Wed, 24 Jun 2020 04:24:17 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x5sm7962485wmg.2.2020.06.24.04.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 04:24:16 -0700 (PDT) Date: Wed, 24 Jun 2020 12:24:14 +0100 From: Lee Jones To: Michael Walle Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes Message-ID: <20200624112414.GG954398@dell> References: <20200611191002.2256570-1-lee.jones@linaro.org> <30f03734-61fd-1b6b-bf11-21b6423a7c50@gmail.com> <20200624064145.GC954398@dell> <7a31b34940984b3f0921ed2d4fb29a58@walle.cc> <20200624082352.GF954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robin.murphy@arm.com, broonie@kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, Frank Rowand , linus.walleij@linaro.org, linux@roeck-us.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNCBKdW4gMjAyMCwgTWljaGFlbCBXYWxsZSB3cm90ZToKCj4gQW0gMjAyMC0wNi0y NCAxMDoyMywgc2NocmllYiBMZWUgSm9uZXM6Cj4gPiBPbiBXZWQsIDI0IEp1biAyMDIwLCBNaWNo YWVsIFdhbGxlIHdyb3RlOgo+IAo+IFsuLl0KPiAKPiA+ID4gQWx0aG91Z2ggUm9iIG1lbnRpb25l ZCB0byBtYXliZSByZWxheCB0aGF0LCBidXQgSSBzaWxsIGZhaWwgdG8gc2VlCj4gPiA+IHRoZSBh ZHZhbnRhZ2UgdG8gaGF2ZSBhbiBhcmJpdHJhcnkgcmVnIHByb3BlcnR5IGluc3RlYWQgb2YgYSB1 bmlxdWUKPiA+ID4gbm9kZSBuYW1lLgo+ID4gCj4gPiBJIGRvbid0IGhhdmUgYSBzdHJvbmcgb3Bp bmlvbiBlaXRoZXIgd2F5Lgo+ID4gCj4gPiBXZSBjYW4gKmFsc28qIGFkZCBub2RlIG5hbWUgbWF0 Y2hpbmcgaWYgUm9iIGRlZW1zIGl0IGZpdC4KPiAKPiBXaGVyZSBkbyB5b3Ugc2VlIGEgdXNlIG9m IHRoZSByZWcgcHJvcGVydHk/CgpUaGUgdmFzdCBwcm9wb3J0aW9uIG9mIGRldmljZXMgZG8gYW5k IHdpbGwgaGF2ZSAncmVnJyBwcm9wZXJ0aWVzLgoKPiBZb3UgYWxyZWFkeSBleHByZXNzZWQKPiB0 aGF0IHlvdSBzZWUgZXhwb3NpbmcgdGhlIGludGVybmFsIG9mZnNldCBhcyBhIGhhY2s6Cj4gCj4g ICJQbGFjaW5nICJpbnRlcm5hbCBvZmZzZXRzIiBpbnRvIHRoZSAncmVnJyBwcm9wZXJ0eSBpcyBh IGhhY2suIiBbMV0KPiAKPiBTbyB3aGF0IGFyZSB5b3UgcHV0dGluZyBpbnRvIHJlZyBpbnN0ZWFk PyBSb2Igc3VnZ2VzdGVkICJhbnl0aGluZyIKPiBkb2N1bWVudGVkIGluIHRoZSBoYXJkd2FyZSBt YW51YWwuIEJ1dCBpc24ndCB0aGlzIGp1c3QgYWxzbyBzb21ldGhpbmcKPiB3ZSBtYWtlIHVwIGFu ZCBlc3BlY2lhbGx5IGZvciB0aGUgTUZEIGRyaXZlci4gVGh1cyBJTUhPIGl0IGRvZXNuJ3QKPiBx dWFsaWZ5IGFzIGEgdW5pdC1hZGRyZXNzLCB3aGljaCAtIGFzIGZhciBhcyBJIHVuZGVyc3RhbmQg aXQgLSBpcwo+IHVuaXF1ZSBvbiB0aGUgcGFyZW50IGJ1cy4gVG8gcmVwZWF0IG15IGFyZ3VtZW50 LCBpdHMgbm90IGEgZGVmaW5lZAo+IHRoaW5nIGxpa2UgYW4gSTJDIGFkZHJlc3MuCgpTbyBvdXIg YXJndW1lbnQgaW4gdGhlIHBhc3QgKGFsdGhvdWdoIHRoaXMgaXMgZ29pbmcgYmFjayB0aGUgYmVz dCBwYXJ0Cm9mIDEwIHllYXJzKSBoYXMgYWx3YXlzIGJlZW4gdGhhdDsgaWYgZGV2aWNlcyBhcmUg ZGlmZmVyZW50LCB0aGVyZSBpcwphbG1vc3QgYWx3YXlzIGEgZG9jdW1lbnRlZCAoaW4gdGhlIEgv VyBtYW51YWwvZGF0YXNoZWV0KSB3YXkgdG8KZGlmZmVyZW50aWF0ZS9hZGRyZXNzIHRoZW0uICBX aGV0aGVyIHRoYXQncyBhIHBoeXNpY2FsIGFkZHJlc3MsIGFuCm9mZnNldCwgYSBiYW5rIElELCBh biBJMkMvU1BJIGFkZHJlc3Mgb3Igd2hhdGV2ZXIuCgpBcyB0byBub3QgYmVpbmcgYWJsZSB0byB1 c2UgdGhhdCBhZGRyZXNzL0lEIGR1ZSB0byB0aGUgRFQgcnVsZXMKc3Vycm91bmRpbmcgYWRkcmVz cyBzcGFjZSBhcyBwZXIgdGhlIGV4YW1wbGUgaW4geW91ciBwcmV2aW91cyBlbWFpbCwKd2VsbCB0 aGF0J3MgYSBydWxlIHNwZWNpZmljIHRvIERUIGFuZCBtYWtlcyBsaXR0bGUgc2Vuc2UgaW4gc29t ZSByZWFsCndvcmxkIGNhc2VzIChzdWNoIGFzLCBkYXJlIEkgc2F5IGl0LCB0aGUgQUI4NTAwKS4K CllvdSdsbCBoYXZlIHRvIHRha2UgdGhlIGFmb3JlbWVudGlvbmVkIHBvaW50IGFuZCB0aGUgcG9p bnQgYWJvdXQgdXNpbmcKbm9kZSBuYW1lcyBpbnN0ZWFkIG9mICdyZWcnIHByb3BlcnRpZXMgdXAg d2l0aCBSb2IgYW5kIHRoZSBvdGhlcgppbnRlcmVzdGVkIERUIGZvbGsuCgpBZ2FpbiwgSSdtIGhh cHB5IHRvIGV4dGVuZCB0aGF0IGZ1bmN0aW9uYWxpdHkgaWYgaXQgYmVjb21lcyBhY2NlcHRhYmxl CnByYWN0aWNlLgoKPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtZGV2aWNldHJl ZS8yMDIwMDYwOTE4NTIzMS5HTzQxMDZAZGVsbC8KPiAKPiAtbWljaGFlbAoKLS0gCkxlZSBKb25l cyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMK TGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBM aW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E14C433E0 for ; Wed, 24 Jun 2020 11:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A211320836 for ; Wed, 24 Jun 2020 11:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h+qiZfi0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390607AbgFXLYV (ORCPT ); Wed, 24 Jun 2020 07:24:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388986AbgFXLYT (ORCPT ); Wed, 24 Jun 2020 07:24:19 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 997A0C061573 for ; Wed, 24 Jun 2020 04:24:19 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f139so2134168wmf.5 for ; Wed, 24 Jun 2020 04:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NrvSiaDLXTBfKnuOt7hk8LUvf/vD6JGQ7WAbFA5i7Uc=; b=h+qiZfi0OhOnDkgTLpZizeUC5IOa97wx3ik8VofmQ5pfxMjOrV/QZdQ1bzH0PCVdiU UgreOMhRLysmM+bBtebPY7anIyh5Ho7OoqBtQmM4nX9hm9SZdRD6PwLqtvezCvD5x2bP yKLL3oYAOG9YVSUhAPv2B0YkFFu+XrIW2mOMZL0AxwspP7uIhMzfAKKRW5Sjn3PfuI7I 8tUEK+4WbXF6HcnEghMiSEhm2Z6Z58auYOW96L/YLupOfUvseYw9YDjMWDUdRzEAqj/T mPxbp9qt//mWBrqgyYQmdqSzcji9eNyItiQcmo1Ts9oa2hmbhVVJiBaLSzhtiyZR1Cab UiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NrvSiaDLXTBfKnuOt7hk8LUvf/vD6JGQ7WAbFA5i7Uc=; b=pi/DyX4x6DTZTvA2wGhp6rzwdPEn4VcWhP9AN5SEflWHgnYLyT7uzCI+jRBpH/YGBB 0Wc6VCjfB+xN/oFBv8Yh1FTPQdmoR3TG7lxSGUDSvvmjse1QrBvxjMSc2U3km6txiEYw guazZZvviOTmcCjOITaWuPGJdc3q0mrk0XVmJoWxY8EH2dqsMwzRhpvblOUnvq2R1KMn Dv5pTMCHi4IEsCSecPgPZb0FipJloCScXbOxl2I9XQ0w/9vu/3j0aC2+Noa7ixixomuT HyiPT/3rO+k/Yku2PUj3BCDL+kmHBSWOQmQpamaD6SI4eQ3ZbmKL88v/cJURYisdrPPk 2TzA== X-Gm-Message-State: AOAM5314R8XVYz4x2ucwJ0995wB+6bm9PtDM3/eNO9GtpEJ40e0oVr/N 35tD79TZe3K/fsiVPXfk6i8ulQ== X-Google-Smtp-Source: ABdhPJxnvJ/bAKboWQS8u3ig+E2OSp3FrtA0y0gJWgzooZABsBXHuo/PhR/sGO75JnZcwGDW//Wkaw== X-Received: by 2002:a7b:c4c3:: with SMTP id g3mr8696211wmk.126.1592997857631; Wed, 24 Jun 2020 04:24:17 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x5sm7962485wmg.2.2020.06.24.04.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 04:24:16 -0700 (PDT) Date: Wed, 24 Jun 2020 12:24:14 +0100 From: Lee Jones To: Michael Walle Cc: Frank Rowand , andy.shevchenko@gmail.com, robh+dt@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, andriy.shevchenko@linux.intel.com, robin.murphy@arm.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes Message-ID: <20200624112414.GG954398@dell> References: <20200611191002.2256570-1-lee.jones@linaro.org> <30f03734-61fd-1b6b-bf11-21b6423a7c50@gmail.com> <20200624064145.GC954398@dell> <7a31b34940984b3f0921ed2d4fb29a58@walle.cc> <20200624082352.GF954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 24 Jun 2020, Michael Walle wrote: > Am 2020-06-24 10:23, schrieb Lee Jones: > > On Wed, 24 Jun 2020, Michael Walle wrote: > > [..] > > > > Although Rob mentioned to maybe relax that, but I sill fail to see > > > the advantage to have an arbitrary reg property instead of a unique > > > node name. > > > > I don't have a strong opinion either way. > > > > We can *also* add node name matching if Rob deems it fit. > > Where do you see a use of the reg property? The vast proportion of devices do and will have 'reg' properties. > You already expressed > that you see exposing the internal offset as a hack: > > "Placing "internal offsets" into the 'reg' property is a hack." [1] > > So what are you putting into reg instead? Rob suggested "anything" > documented in the hardware manual. But isn't this just also something > we make up and especially for the MFD driver. Thus IMHO it doesn't > qualify as a unit-address, which - as far as I understand it - is > unique on the parent bus. To repeat my argument, its not a defined > thing like an I2C address. So our argument in the past (although this is going back the best part of 10 years) has always been that; if devices are different, there is almost always a documented (in the H/W manual/datasheet) way to differentiate/address them. Whether that's a physical address, an offset, a bank ID, an I2C/SPI address or whatever. As to not being able to use that address/ID due to the DT rules surrounding address space as per the example in your previous email, well that's a rule specific to DT and makes little sense in some real world cases (such as, dare I say it, the AB8500). You'll have to take the aforementioned point and the point about using node names instead of 'reg' properties up with Rob and the other interested DT folk. Again, I'm happy to extend that functionality if it becomes acceptable practice. > [1] https://lore.kernel.org/linux-devicetree/20200609185231.GO4106@dell/ > > -michael -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog