diff for duplicates of <20200624132640.GC9972@mwanda> diff --git a/a/1.txt b/N1/1.txt index c026eb4..7b9a03b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,12 +15,17 @@ index 13fea645c7f0..54e377754a6c 100644 * If the written data is completely 0xff, we also want to write 0xff as * ECC, otherwise we will get in trouble when doing subpage writes. */ -- if (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) = 0) +- if (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) == 0) - memset(ecc_code, 0xff, ARRAY_SIZE(empty_block_ecc)); -+ if (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) = 0) ++ if (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) == 0) + memset(ecc_code, 0xff, sizeof(empty_block_ecc)); return 0; } -- 2.27.0 + + +______________________________________________________ +Linux MTD discussion mailing list +http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/a/content_digest b/N1/content_digest index e17089d..5b807bf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH] mtd: rawnand: ingenic: cleanup ARRAY_SIZE() vs sizeof() use\0" - "Date\0Wed, 24 Jun 2020 13:26:40 +0000\0" + "Date\0Wed, 24 Jun 2020 16:26:40 +0300\0" "To\0Paul Cercueil <paul@crapouillou.net>\0" "Cc\0Vignesh Raghavendra <vigneshr@ti.com>" Richard Weinberger <richard@nod.at> @@ -28,14 +28,19 @@ " \t * If the written data is completely 0xff, we also want to write 0xff as\n" " \t * ECC, otherwise we will get in trouble when doing subpage writes.\n" " \t */\n" - "-\tif (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) = 0)\n" + "-\tif (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) == 0)\n" "-\t\tmemset(ecc_code, 0xff, ARRAY_SIZE(empty_block_ecc));\n" - "+\tif (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) = 0)\n" + "+\tif (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) == 0)\n" "+\t\tmemset(ecc_code, 0xff, sizeof(empty_block_ecc));\n" " \n" " \treturn 0;\n" " }\n" "-- \n" - 2.27.0 + "2.27.0\n" + "\n" + "\n" + "______________________________________________________\n" + "Linux MTD discussion mailing list\n" + http://lists.infradead.org/mailman/listinfo/linux-mtd/ -b4b245f4ed84ef35bc2ab6a0a9608365601e0b9f3211995a0683412271e4d4d2 +26074e1c69fc34f67eed916607c9d32b266955b010d99f765af18095d8fb6912
diff --git a/a/1.txt b/N2/1.txt index c026eb4..3d6d8dd 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -15,9 +15,9 @@ index 13fea645c7f0..54e377754a6c 100644 * If the written data is completely 0xff, we also want to write 0xff as * ECC, otherwise we will get in trouble when doing subpage writes. */ -- if (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) = 0) +- if (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) == 0) - memset(ecc_code, 0xff, ARRAY_SIZE(empty_block_ecc)); -+ if (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) = 0) ++ if (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) == 0) + memset(ecc_code, 0xff, sizeof(empty_block_ecc)); return 0; diff --git a/a/content_digest b/N2/content_digest index e17089d..9bde259 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,14 +1,14 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH] mtd: rawnand: ingenic: cleanup ARRAY_SIZE() vs sizeof() use\0" - "Date\0Wed, 24 Jun 2020 13:26:40 +0000\0" + "Date\0Wed, 24 Jun 2020 16:26:40 +0300\0" "To\0Paul Cercueil <paul@crapouillou.net>\0" - "Cc\0Vignesh Raghavendra <vigneshr@ti.com>" + "Cc\0Harvey Hunt <harveyhuntnexus@gmail.com>" + Miquel Raynal <miquel.raynal@bootlin.com> Richard Weinberger <richard@nod.at> - kernel-janitors@vger.kernel.org - linux-kernel@vger.kernel.org - Harvey Hunt <harveyhuntnexus@gmail.com> + Vignesh Raghavendra <vigneshr@ti.com> linux-mtd@lists.infradead.org - " Miquel Raynal <miquel.raynal@bootlin.com>\0" + linux-kernel@vger.kernel.org + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "The ARRAY_SIZE() is the number of elements but we want to use sizeof()\n" @@ -28,9 +28,9 @@ " \t * If the written data is completely 0xff, we also want to write 0xff as\n" " \t * ECC, otherwise we will get in trouble when doing subpage writes.\n" " \t */\n" - "-\tif (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) = 0)\n" + "-\tif (memcmp(ecc_code, empty_block_ecc, ARRAY_SIZE(empty_block_ecc)) == 0)\n" "-\t\tmemset(ecc_code, 0xff, ARRAY_SIZE(empty_block_ecc));\n" - "+\tif (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) = 0)\n" + "+\tif (memcmp(ecc_code, empty_block_ecc, sizeof(empty_block_ecc)) == 0)\n" "+\t\tmemset(ecc_code, 0xff, sizeof(empty_block_ecc));\n" " \n" " \treturn 0;\n" @@ -38,4 +38,4 @@ "-- \n" 2.27.0 -b4b245f4ed84ef35bc2ab6a0a9608365601e0b9f3211995a0683412271e4d4d2 +8d3207c18b31cd7eb5c1cd4b1fa5d5819c927b448eec9343a82d2988538634db
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.