From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 24 Jun 2020 15:43:21 +0000 Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-Id: <20200624154321.GH954398@dell> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> In-Reply-To: <20200624153216.GA1814806@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Sam Ravnborg Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, 24 Jun 2020, Sam Ravnborg wrote: > Hi Lee. > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > Attempting to clean-up W=1 kernel builds, which are currently > > overwhelmingly riddled with niggly little warnings. > > > > Lee Jones (8): > > backlight: lms501kf03: Remove unused const variables > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > CHECK_FREQ_REG() args > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > backlight: ili922x: Add missing kerneldoc description for > > ili922x_reg_dump()'s arg > I wonder why these warnings show up as nothing pulls in this .c file. > Anyway I would suggest to drop using kerneldoc syntax for single drivers > like this - and the benefit here is low. > Now they are typed, otherwise this ahd been fine in a single patch. What do you mean by 'nothing pulls it in'? > > backlight: backlight: Supply description for function args in existing > > Kerneldocs > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > The other fixes looks good. > They are all: > Acked-by: Sam Ravnborg Thanks (although this should be Reviewed-by). > > drivers/video/backlight/backlight.c | 2 ++ > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > drivers/video/backlight/lcd.c | 1 + > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > drivers/video/backlight/lms501kf03.c | 8 -------- > > drivers/video/backlight/qcom-wled.c | 8 -------- > > 6 files changed, 11 insertions(+), 20 deletions(-) > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA2AC433E0 for ; Wed, 24 Jun 2020 15:45:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA64420706 for ; Wed, 24 Jun 2020 15:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="krY36Z1Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Olmv6gOF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA64420706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9De8TbsgLOdwpJ/I8kEoqb/YSS/ZzFrcXvzAQjak/bg=; b=krY36Z1ZlX0e7VIqUnheh90zX eiWavqPeTiZmzeLe7DNBcgNWwSylyky4Gp43dIGGDKi72vmQfdA0ia6HcBcLmI07NqR9P+dvkwExs B7Gq7/5yJQTzFm7B6NZTfw2gDFLM1x9X+cZsYafW0/NBdPqpgVlZ6v/uKcOAPbRNJkfwXNY6nO5La se0XmsGGsGEtXws/CgUq4aJgr6m/B99SQjs7SkZ6jFBNBa/5eycVd4H3CXPYiOzBy2pkpi/1+6JDh R2hFRxuR090XWzMkqVxmIeA6p2XYKgG0EyUwIVlWCYkZw8yqplbmuQFAHI1Ba3Q0ew9QD4ZhhUgII eRd4aG+kA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7Yf-0006pG-DV; Wed, 24 Jun 2020 15:43:29 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7Yb-0006oU-1J for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:43:26 +0000 Received: by mail-wm1-x343.google.com with SMTP id u26so4783666wmn.1 for ; Wed, 24 Jun 2020 08:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=Olmv6gOFR6NbOAqgFzCBJx/sCYV/IREx2uVFDnyNUpwSY/mDxH4RQEaIIqwkxB4ICw OmlyLQtUPS7BKq9rjxqW7PsmSayRlxNsp3CBwqOphzrTJesmqsd/9oNQrA3IlpYUW0PZ fudSy31IumvzQrnLbUbjZSN5JGU9DP5XWjcMbAryKvmqsYifSefNVUqu2Su8OXQvPMVE dsVZolchYV5cK7gk0/DRSho+Ia0WuTzYBvKGvhRhtgPUURP4Ndkk9KgCqzQ81nwD7C0z CNpkJgEMvLNJ4qfZ1RFZnaKXBpWwSTDYACp0W4/tSjgSY9pUvicATh27hnBP4HKau3Ho XwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=LPLMwRPizbwufZJOQ9XvviaaRX/HcO36XNEDqkHhTbYUxokI0lgLvtdNHuqIKexMBy 1pUB7oAE/O2JMEU81sEpL4I/P6Sa+HYmpS9/3z9foNivcuKblJYVUuVs3TtFjMgFnJ4u 000Uea4vZUsojRpbBGuJaYWpAkHIVgsZD8qsIDw9mNlprcSBTp4H8LrWNZLqKyx9jHlM nDgrEuzZ3MM/wvRmGjVIg3f6jjn80t7uUPIxvnZNGmA3s9ecW6fgi3ue06V9kgcVj1Rj xXaho6vn4cu6Y8CNC4yylues5rKYSySYc5+ojfULLqUhTmhRB3XYSBrbjEXh1rW6Zq7n x+EQ== X-Gm-Message-State: AOAM5322oRg4OC6lEkPsnqgbLpvz5IxTVZ2txx4XmEnHG6/lhRqJ3swe V6GnabW4DBqeCeW9pJ9G17Q3oQ== X-Google-Smtp-Source: ABdhPJwj67zlK538LD9M3+i8IFmwRhOZYaUWn/TQagj8Vmc62JySmFUQKYtWcbTLacIAWDoe1q9dnA== X-Received: by 2002:a7b:c345:: with SMTP id l5mr32069049wmj.31.1593013403867; Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c143sm8597840wmd.1.2020.06.24.08.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Date: Wed, 24 Jun 2020 16:43:21 +0100 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200624154321.GH954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624153216.GA1814806@ravnborg.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUuCj4gCj4g T24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDM6NTc6MTNQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gQXR0ZW1wdGluZyB0byBjbGVhbi11cCBXPTEga2VybmVsIGJ1aWxkcywgd2hpY2ggYXJl IGN1cnJlbnRseQo+ID4gb3ZlcndoZWxtaW5nbHkgcmlkZGxlZCB3aXRoIG5pZ2dseSBsaXR0bGUg d2FybmluZ3MuCj4gPiAKPiA+IExlZSBKb25lcyAoOCk6Cj4gPiAgIGJhY2tsaWdodDogbG1zNTAx a2YwMzogUmVtb3ZlIHVudXNlZCBjb25zdCB2YXJpYWJsZXMKPiA+ICAgYmFja2xpZ2h0OiBsY2Q6 IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBlbnRyeSBmb3IgJ3N0cnVjdCBkZXZpY2UgcGFyZW50Jwo+ IAo+IAo+ID4gICBiYWNrbGlnaHQ6IGlsaTkyMng6IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBkZXNj cmlwdGlvbnMgZm9yCj4gPiAgICAgQ0hFQ0tfRlJFUV9SRUcoKSBhcmdzCj4gPiAgIGJhY2tsaWdo dDogaWxpOTIyeDogUmVtb3ZlIGludmFsaWQgdXNlIG9mIGtlcm5lbGRvYyBzeW50YXgKPiA+ICAg YmFja2xpZ2h0OiBpbGk5MjJ4OiBBZGQgbWlzc2luZyBrZXJuZWxkb2MgZGVzY3JpcHRpb24gZm9y Cj4gPiAgICAgaWxpOTIyeF9yZWdfZHVtcCgpJ3MgYXJnCj4gSSB3b25kZXIgd2h5IHRoZXNlIHdh cm5pbmdzIHNob3cgdXAgYXMgbm90aGluZyBwdWxscyBpbiB0aGlzIC5jIGZpbGUuCj4gQW55d2F5 IEkgd291bGQgc3VnZ2VzdCB0byBkcm9wIHVzaW5nIGtlcm5lbGRvYyBzeW50YXggZm9yIHNpbmds ZSBkcml2ZXJzCj4gbGlrZSB0aGlzIC0gYW5kIHRoZSBiZW5lZml0IGhlcmUgaXMgbG93Lgo+IE5v dyB0aGV5IGFyZSB0eXBlZCwgb3RoZXJ3aXNlIHRoaXMgYWhkIGJlZW4gZmluZSBpbiBhIHNpbmds ZSBwYXRjaC4KCldoYXQgZG8geW91IG1lYW4gYnkgJ25vdGhpbmcgcHVsbHMgaXQgaW4nPwoKPiA+ ICAgYmFja2xpZ2h0OiBiYWNrbGlnaHQ6IFN1cHBseSBkZXNjcmlwdGlvbiBmb3IgZnVuY3Rpb24g YXJncyBpbiBleGlzdGluZwo+ID4gICAgIEtlcm5lbGRvY3MKPiA+ICAgYmFja2xpZ2h0OiBsbTM2 MzBhX2JsOiBSZW1vdmUgaW52YWxpZCBjaGVja3MgZm9yIHVuc2lnbmVkIGludCA8IDAKPiA+ICAg YmFja2xpZ2h0OiBxY29tLXdsZWQ6IFJlbW92ZSB1bnVzZWQgY29uZmlncyBmb3IgTEVEMyBhbmQg TEVENAo+IAo+IFRoZSBvdGhlciBmaXhlcyBsb29rcyBnb29kLgo+IFRoZXkgYXJlIGFsbDoKPiBB Y2tlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgoKVGhhbmtzIChhbHRob3Vn aCB0aGlzIHNob3VsZCBiZSBSZXZpZXdlZC1ieSkuCgo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2JhY2tsaWdodC5jICB8IDIgKysKPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5 MjJ4LmMgICAgfCA4ICsrKysrKy0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbGNkLmMg ICAgICAgIHwgMSArCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjMwYV9ibC5jIHwg NCArKy0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG1zNTAxa2YwMy5jIHwgOCAtLS0t LS0tLQo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jICB8IDggLS0tLS0t LS0KPiA+ICA2IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygt KQo+ID4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABF4C433DF for ; Wed, 24 Jun 2020 15:43:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88A8220706 for ; Wed, 24 Jun 2020 15:43:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Olmv6gOF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88A8220706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 024ED6E0F7; Wed, 24 Jun 2020 15:43:26 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467816E0F7 for ; Wed, 24 Jun 2020 15:43:25 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id a6so4781235wmm.0 for ; Wed, 24 Jun 2020 08:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=Olmv6gOFR6NbOAqgFzCBJx/sCYV/IREx2uVFDnyNUpwSY/mDxH4RQEaIIqwkxB4ICw OmlyLQtUPS7BKq9rjxqW7PsmSayRlxNsp3CBwqOphzrTJesmqsd/9oNQrA3IlpYUW0PZ fudSy31IumvzQrnLbUbjZSN5JGU9DP5XWjcMbAryKvmqsYifSefNVUqu2Su8OXQvPMVE dsVZolchYV5cK7gk0/DRSho+Ia0WuTzYBvKGvhRhtgPUURP4Ndkk9KgCqzQ81nwD7C0z CNpkJgEMvLNJ4qfZ1RFZnaKXBpWwSTDYACp0W4/tSjgSY9pUvicATh27hnBP4HKau3Ho XwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=bBQucfvj/797M6PjY2RSFeQ8/4uqugVNMoEeElQ6z/T9mOKyUXGcNHzLG1U5uPU/6g l/YFvMwVAJUyZqE+GyQjWg3BhiLjzZE1oIpPWLDEihnbi3PrQ6zWWCkbNCC6xm7o1hN0 zhWKtvCEh9Qq8i5N4KdZnI+WVDgyt+mSN36FO4cDUVFw/RJuqBP8I7nygMcwAsV8VzLX uWBZz8sPupz/7UBRMX97/4LgeVbGlz0knHmL3WIPq2QEOAcW0x2DpJonQTzz+bdzBoEN FJ7vF9Bk8Hh0e5nY1HHeVuEW/k6ZjDKu493ToL5KskEr6q+J0aR3gX8MaOd1GnUJIUnE dEhQ== X-Gm-Message-State: AOAM530aC+4srV+Wu4/XoSTbWMryFUETIVjxfE043yg5VQYbb6Szv5rc aCyYHi1YPqixsHS9NkKoocC9eA== X-Google-Smtp-Source: ABdhPJwj67zlK538LD9M3+i8IFmwRhOZYaUWn/TQagj8Vmc62JySmFUQKYtWcbTLacIAWDoe1q9dnA== X-Received: by 2002:a7b:c345:: with SMTP id l5mr32069049wmj.31.1593013403867; Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c143sm8597840wmd.1.2020.06.24.08.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Date: Wed, 24 Jun 2020 16:43:21 +0100 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200624154321.GH954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624153216.GA1814806@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUuCj4gCj4g T24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDM6NTc6MTNQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gQXR0ZW1wdGluZyB0byBjbGVhbi11cCBXPTEga2VybmVsIGJ1aWxkcywgd2hpY2ggYXJl IGN1cnJlbnRseQo+ID4gb3ZlcndoZWxtaW5nbHkgcmlkZGxlZCB3aXRoIG5pZ2dseSBsaXR0bGUg d2FybmluZ3MuCj4gPiAKPiA+IExlZSBKb25lcyAoOCk6Cj4gPiAgIGJhY2tsaWdodDogbG1zNTAx a2YwMzogUmVtb3ZlIHVudXNlZCBjb25zdCB2YXJpYWJsZXMKPiA+ICAgYmFja2xpZ2h0OiBsY2Q6 IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBlbnRyeSBmb3IgJ3N0cnVjdCBkZXZpY2UgcGFyZW50Jwo+ IAo+IAo+ID4gICBiYWNrbGlnaHQ6IGlsaTkyMng6IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBkZXNj cmlwdGlvbnMgZm9yCj4gPiAgICAgQ0hFQ0tfRlJFUV9SRUcoKSBhcmdzCj4gPiAgIGJhY2tsaWdo dDogaWxpOTIyeDogUmVtb3ZlIGludmFsaWQgdXNlIG9mIGtlcm5lbGRvYyBzeW50YXgKPiA+ICAg YmFja2xpZ2h0OiBpbGk5MjJ4OiBBZGQgbWlzc2luZyBrZXJuZWxkb2MgZGVzY3JpcHRpb24gZm9y Cj4gPiAgICAgaWxpOTIyeF9yZWdfZHVtcCgpJ3MgYXJnCj4gSSB3b25kZXIgd2h5IHRoZXNlIHdh cm5pbmdzIHNob3cgdXAgYXMgbm90aGluZyBwdWxscyBpbiB0aGlzIC5jIGZpbGUuCj4gQW55d2F5 IEkgd291bGQgc3VnZ2VzdCB0byBkcm9wIHVzaW5nIGtlcm5lbGRvYyBzeW50YXggZm9yIHNpbmds ZSBkcml2ZXJzCj4gbGlrZSB0aGlzIC0gYW5kIHRoZSBiZW5lZml0IGhlcmUgaXMgbG93Lgo+IE5v dyB0aGV5IGFyZSB0eXBlZCwgb3RoZXJ3aXNlIHRoaXMgYWhkIGJlZW4gZmluZSBpbiBhIHNpbmds ZSBwYXRjaC4KCldoYXQgZG8geW91IG1lYW4gYnkgJ25vdGhpbmcgcHVsbHMgaXQgaW4nPwoKPiA+ ICAgYmFja2xpZ2h0OiBiYWNrbGlnaHQ6IFN1cHBseSBkZXNjcmlwdGlvbiBmb3IgZnVuY3Rpb24g YXJncyBpbiBleGlzdGluZwo+ID4gICAgIEtlcm5lbGRvY3MKPiA+ICAgYmFja2xpZ2h0OiBsbTM2 MzBhX2JsOiBSZW1vdmUgaW52YWxpZCBjaGVja3MgZm9yIHVuc2lnbmVkIGludCA8IDAKPiA+ICAg YmFja2xpZ2h0OiBxY29tLXdsZWQ6IFJlbW92ZSB1bnVzZWQgY29uZmlncyBmb3IgTEVEMyBhbmQg TEVENAo+IAo+IFRoZSBvdGhlciBmaXhlcyBsb29rcyBnb29kLgo+IFRoZXkgYXJlIGFsbDoKPiBB Y2tlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgoKVGhhbmtzIChhbHRob3Vn aCB0aGlzIHNob3VsZCBiZSBSZXZpZXdlZC1ieSkuCgo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2JhY2tsaWdodC5jICB8IDIgKysKPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5 MjJ4LmMgICAgfCA4ICsrKysrKy0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbGNkLmMg ICAgICAgIHwgMSArCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjMwYV9ibC5jIHwg NCArKy0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG1zNTAxa2YwMy5jIHwgOCAtLS0t LS0tLQo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jICB8IDggLS0tLS0t LS0KPiA+ICA2IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygt KQo+ID4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A23C433E1 for ; Wed, 24 Jun 2020 15:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F91C20706 for ; Wed, 24 Jun 2020 15:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Olmv6gOF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404350AbgFXPn0 (ORCPT ); Wed, 24 Jun 2020 11:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404253AbgFXPnZ (ORCPT ); Wed, 24 Jun 2020 11:43:25 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C832C0613ED for ; Wed, 24 Jun 2020 08:43:25 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id u26so4783667wmn.1 for ; Wed, 24 Jun 2020 08:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=Olmv6gOFR6NbOAqgFzCBJx/sCYV/IREx2uVFDnyNUpwSY/mDxH4RQEaIIqwkxB4ICw OmlyLQtUPS7BKq9rjxqW7PsmSayRlxNsp3CBwqOphzrTJesmqsd/9oNQrA3IlpYUW0PZ fudSy31IumvzQrnLbUbjZSN5JGU9DP5XWjcMbAryKvmqsYifSefNVUqu2Su8OXQvPMVE dsVZolchYV5cK7gk0/DRSho+Ia0WuTzYBvKGvhRhtgPUURP4Ndkk9KgCqzQ81nwD7C0z CNpkJgEMvLNJ4qfZ1RFZnaKXBpWwSTDYACp0W4/tSjgSY9pUvicATh27hnBP4HKau3Ho XwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QM8WHNX4JVzp1tT3alZnq1KeTZs+/wuqZ6hsAIKxcMA=; b=LjfApev1z5DupqBGM8J56w48c3mO4Y9maMPS9/Rt5Lo54P8gQAiM0kKrocJlU31SPh ClvNVj8o+mZRv2oiXpz2UYoObWXeklVqU7Q/nTNaxczz027DuOqBXJBU+e4Nthzd0Kyz TGEZgOqEySWR0i+obwz7rpWBKky48X7kAJP+NP71v6XGgs9DyLLkQ2Mq3nTC87F1TJ5i UTeAkHT86XIaxPEYpTX190sSdFtq2pyeCaucLXilOeWbJykMcZknV0Xq9pAeoK0z55Ts Y2qM48Ckpng3LZxjDGN8J87OA7XAvHJHqRo2mFSevMPK1yCHHAn4SDfQHvAKdAJiHfHU DEZg== X-Gm-Message-State: AOAM530byGlGtvkmyig3/CgvuTdmbD9c6N2tJxibVCdBpPB8fwJ/a28b eJb6zOBuPdAVelPJE4Q8wCFDeQ== X-Google-Smtp-Source: ABdhPJwj67zlK538LD9M3+i8IFmwRhOZYaUWn/TQagj8Vmc62JySmFUQKYtWcbTLacIAWDoe1q9dnA== X-Received: by 2002:a7b:c345:: with SMTP id l5mr32069049wmj.31.1593013403867; Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c143sm8597840wmd.1.2020.06.24.08.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:43:23 -0700 (PDT) Date: Wed, 24 Jun 2020 16:43:21 +0100 From: Lee Jones To: Sam Ravnborg Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200624154321.GH954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200624153216.GA1814806@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jun 2020, Sam Ravnborg wrote: > Hi Lee. > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > Attempting to clean-up W=1 kernel builds, which are currently > > overwhelmingly riddled with niggly little warnings. > > > > Lee Jones (8): > > backlight: lms501kf03: Remove unused const variables > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > CHECK_FREQ_REG() args > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > backlight: ili922x: Add missing kerneldoc description for > > ili922x_reg_dump()'s arg > I wonder why these warnings show up as nothing pulls in this .c file. > Anyway I would suggest to drop using kerneldoc syntax for single drivers > like this - and the benefit here is low. > Now they are typed, otherwise this ahd been fine in a single patch. What do you mean by 'nothing pulls it in'? > > backlight: backlight: Supply description for function args in existing > > Kerneldocs > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > The other fixes looks good. > They are all: > Acked-by: Sam Ravnborg Thanks (although this should be Reviewed-by). > > drivers/video/backlight/backlight.c | 2 ++ > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > drivers/video/backlight/lcd.c | 1 + > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > drivers/video/backlight/lms501kf03.c | 8 -------- > > drivers/video/backlight/qcom-wled.c | 8 -------- > > 6 files changed, 11 insertions(+), 20 deletions(-) > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog