From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9A3AC433E0 for ; Wed, 24 Jun 2020 16:57:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EC8220738 for ; Wed, 24 Jun 2020 16:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZMqFzBcn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ZgOTBUbP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EC8220738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=URji3Bp8Mp7wSzETTu8c52434aVuy0vzdtkgDF+BNrY=; b=ZMqFzBcnHP50JdpIarHQ6XfZK Pci7FB5hUjDM9qvrUTT3rq4hN3qs/Cwk9+wXwXJGjPvuPEXwcU3ZES/cFTED3hTA0q/TGvtRu+i48 wi752Qu0CNzyWp0CHHlulvclwAwXaqdjIAezXKBUfPTq6sbznj3zmvyyb0fBWeH8CZwcmSj1hjnej 3Ze1OrcHRj3t1kOs6Dtvdp7u62uuYXO9Mg8q1Be/jyQ58ytp1F7vZZ3pVoXseAJ0LPHDX2jLvHWlH QKplMpovsxkGP4xoi8mx+3MQhvM7oQ7oGZQkzQh/T4BGkfQLGQh3NSZ3Gd5/dWIm9UtG6xh4y3Nff Rrj+XYtQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8iL-00059E-Fx; Wed, 24 Jun 2020 16:57:33 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8iI-00057U-Ld; Wed, 24 Jun 2020 16:57:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L0BSl9Rz5P8GUkSvL7sI0fAZe5Hrhoqy7/0x3FiFW2Y=; b=ZgOTBUbPjta9cXrzFnnIAnab4 Dcm9pDc0Ejlq5vVTWRjyevo27fV7XGPaj06Z05BDeZRcenj/FWeWJut7lz1cg2jUDgZnf8MvLUdYM P+biZdJlriNMVb3RtYtqgt1B8ql+d+lgDKGM3OOj3i9TDJ3SIgG6/R4Rg8amZWPYlQq6fIY/e5RIH 39Hwa7ZromkrO1urRg88NKb0eQZfm104fYt7Wvq+tEViZGuPwfd3FP5JIhp40PZgkNtwizse0M5zD FpIcwGpyg+93AxBkRp7ezqMw7JKjDwcBW5nSjVKmWjVeWpHEex9JZNfJ7NiOhJ6zOdVKpd7uk/VBN B1UNRAHEg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59222) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jo8i8-0003ML-Ug; Wed, 24 Jun 2020 17:57:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jo8i7-00027d-Ep; Wed, 24 Jun 2020 17:57:19 +0100 Date: Wed, 24 Jun 2020 17:57:19 +0100 From: Russell King - ARM Linux admin To: Bartosz Golaszewski Subject: Re: [PATCH 14/15] net: phy: add PHY regulator support Message-ID: <20200624165719.GB1551@shell.armlinux.org.uk> References: <20200622093744.13685-1-brgl@bgdev.pl> <20200622093744.13685-15-brgl@bgdev.pl> <20200622132921.GI1551@shell.armlinux.org.uk> <20200623094252.GS1551@shell.armlinux.org.uk> <20200623095646.GT1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Tom Lendacky , Vladimir Oltean , Liam Girdwood , Fabien Parent , Iyappan Subramanian , Quan Nguyen , Frank Rowand , Florian Fainelli , Bartosz Golaszewski , Jakub Kicinski , Vivien Didelot , devicetree , Philipp Zabel , Stephane Le Provost , Keyur Chudgar , Jassi Brar , Claudiu Manoil , Mark Brown , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , Linux ARM , netdev , Ilias Apalodimas , Linux Kernel Mailing List , Rob Herring , Andrew Perepech , Pedro Tsai , "David S . Miller" , Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjMsIDIwMjAgYXQgMDY6Mjc6MDZQTSArMDIwMCwgQmFydG9zeiBHb2xhc3pl d3NraSB3cm90ZToKPiB3dC4sIDIzIGN6ZSAyMDIwIG8gMTE6NTYgUnVzc2VsbCBLaW5nIC0gQVJN IExpbnV4IGFkbWluCj4gPGxpbnV4QGFybWxpbnV4Lm9yZy51az4gbmFwaXNhxYIoYSk6Cj4gPgo+ ID4gT24gVHVlLCBKdW4gMjMsIDIwMjAgYXQgMTE6NDY6MTVBTSArMDIwMCwgQmFydG9zeiBHb2xh c3pld3NraSB3cm90ZToKPiA+ID4gd3QuLCAyMyBjemUgMjAyMCBvIDExOjQzIFJ1c3NlbGwgS2lu ZyAtIEFSTSBMaW51eCBhZG1pbgo+ID4gPiA8bGludXhAYXJtbGludXgub3JnLnVrPiBuYXBpc2HF gihhKToKPiA+ID4gPgo+ID4gPiA+IE9uIFR1ZSwgSnVuIDIzLCAyMDIwIGF0IDExOjQxOjExQU0g KzAyMDAsIEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4gPiA+ID4gPiBwb24uLCAyMiBjemUg MjAyMCBvIDE1OjI5IFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbgo+ID4gPiA+ID4gPGxp bnV4QGFybWxpbnV4Lm9yZy51az4gbmFwaXNhxYIoYSk6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gW3NuaXAhXQo+ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhpcyBp cyBsaWtlbHkgdG8gY2F1c2UgaXNzdWVzIGZvciBzb21lIFBIWSBkcml2ZXJzLiAgTm90ZSB0aGF0 IHdlIGhhdmUKPiA+ID4gPiA+ID4gc29tZSBQSFkgZHJpdmVycyB3aGljaCByZWdpc3RlciBhIHRl bXBlcmF0dXJlIHNlbnNvciBpbiB0aGUgcHJvYmUKPiA+ID4gPiA+ID4gZnVuY3Rpb24sIHdoaWNo IG1lYW5zIHRoZXkgY2FuIGJlIGFjY2Vzc2VkIGluZGVwZW5kZW50bHkgb2YgdGhlIGxpZmV0aW1l Cj4gPiA+ID4gPiA+IG9mIHRoZSBQSFkgYm91bmQgdG8gdGhlIG5ldHdvcmsgZHJpdmVyICh3aGlj aCBtYXkgb25seSBiZSB3aGlsZSB0aGUKPiA+ID4gPiA+ID4gbmV0d29yayBkZXZpY2UgaXMgInVw Ii4pICBXZSBjZXJ0YWlubHkgZG8gbm90IHdhbnQgaHdtb24gZmFpbGluZyBqdXN0Cj4gPiA+ID4g PiA+IGJlY2F1c2UgdGhlIG5ldHdvcmsgZGV2aWNlIGlzIGRvd24uCj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IFRoYXQncyBraW5kIG9mIHdvcmtlZCBhcm91bmQgZm9yIHRoZSByZXNldCBzdHVmZiwg YmVjYXVzZSB0aGVyZSBhcmUgdHdvCj4gPiA+ID4gPiA+IGxheWVycyB0byB0aGF0OiB0aGUgbWRp byBkZXZpY2UgbGF5ZXIgcmVzZXQgc3VwcG9ydCB3aGljaCBrbm93cyBub3RoaW5nCj4gPiA+ID4g PiA+IG9mIHRoZSBQSFkgYmluZGluZyBzdGF0ZSB0byB0aGUgbmV0d29yayBkcml2ZXIsIGFuZCB0 aGUgcGh5bGliIHJlc2V0Cj4gPiA+ID4gPiA+IHN1cHBvcnQsIGJ1dCBpdCBpcyBub3QgbmljZS4K PiA+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBSZWd1bGF0b3JzIGFyZSByZWZlcmVuY2Ug Y291bnRlZCBzbyBpZiB0aGUgaHdtb24gZHJpdmVyIGVuYWJsZXMgaXQKPiA+ID4gPiA+IHVzaW5n IG1kaW9fZGV2aWNlX3Bvd2VyX29uKCkgaXQgd2lsbCBzdGF5IG9uIGV2ZW4gYWZ0ZXIgdGhlIFBI WSBkcml2ZXIKPiA+ID4gPiA+IGNhbGxzIHBoeV9kZXZpY2VfcG93ZXJfb2ZmKCksIHJpZ2h0PyBB bSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+ID4gPiA+Cj4gPiA+ID4gSWYgdGhhdCBpcyB0cnVlLCB5 b3Ugd2lsbCBuZWVkIHRvIGF1ZGl0IHRoZSBQSFkgZHJpdmVycyB0byBhZGQgdGhhdC4KPiA+ID4g Pgo+ID4gPgo+ID4gPiBUaGlzIGNoYW5nZSBkb2Vzbid0IGhhdmUgYW55IGVmZmVjdCBvbiBkZXZp Y2VzIHdoaWNoIGRvbid0IGhhdmUgYQo+ID4gPiByZWd1bGF0b3IgYXNzaWduZWQgaW4gRFQgdGhv dWdoLiBUaGUgb25lIEknbSBhZGRpbmcgaW4gdGhlIGxhc3QgcGF0Y2gKPiA+ID4gaXMgdGhlIGZp cnN0IHRvIHVzZSB0aGlzLgo+ID4KPiA+IEl0J3MgcXVhbGl0eSBvZiBpbXBsZW1lbnRhdGlvbi4K PiA+Cj4gPiBTaG91bGQgd2Ugd2FpdCBmb3Igc29tZW9uZSBlbHNlIHRvIG1ha2UgdXNlIG9mIHRo ZSBuZXcgcmVndWxhdG9yCj4gPiBzdXBwb3J0IHRoYXQgaGFzIGJlZW4gYWRkZWQgd2l0aCBhIFBI WSB0aGF0IHVzZXMgaHdtb24sIGFuZCB0aGV5Cj4gPiBkb24ndCByZWFsaXNlIHRoYXQgaXQgYnJl YWtzIGh3bW9uIG9uIGl0LCBhbmQgc2V2ZXJhbCBrZXJuZWwgdmVyc2lvbnMKPiA+IGdvIGJ5IHdp dGhvdXQgaXQgYmVpbmcgbm90aWNlZC4gIEl0IHdpbGwgb25seSBiZSBhIG5vdGljYWJsZSBpc3N1 ZQo+ID4gd2hlbiB0aGUgYXNzb2NpYXRlZCBuZXR3b3JrIGRldmljZSBpcyBkb3duLCBhbmQgdGhh dCBuZXR3b3JrIGRldmljZQo+ID4gZHJpdmVyIGRldGFjaGVzIGZyb20gdGhlIFBIWSwgc28gX2lz XyBsaWtlbHkgbm90IHRvIGJlIG5vdGljZWQuCj4gPgo+ID4gT3Igc2hvdWxkIHdlIGRvIGEgc21h bGwgYW1vdW50IG9mIHdvcmsgbm93IHRvIHByb3Blcmx5IGltcGxlbWVudAo+ID4gcmVndWxhdG9y IHN1cHBvcnQsIHdoaWNoIGluY2x1ZGVzIGEgdHJpdmlhbCBncmVwIGZvciAiaHdtb24iIGFtb25n c3QKPiA+IHRoZSBQSFkgZHJpdmVycywgYW5kIGFkZCB0aGUgbmVjZXNzYXJ5IGNhbGwgdG8gYXZv aWQgdGhlIHJlZ3VsYXRvcgo+ID4gYmVpbmcgc2h1dCBvZmYuCj4gPgo+IAo+IEknbSBub3Qgc3Vy ZSB3aGF0IHRoZSBjb3JyZWN0IGFwcHJvYWNoIGlzIGhlcmUuIFByb3ZpZGUgc29tZSBoZWxwZXIK PiB0aGF0LCB3aGVuIGNhbGxlZCwgd291bGQgaW5jcmVhc2UgdGhlIHJlZ3VsYXRvcidzIHJlZmVy ZW5jZSBjb3VudCBldmVuCj4gbW9yZSB0byBrZWVwIGl0IGVuYWJsZWQgZnJvbSB0aGUgbW9tZW50 IGh3bW9uIGlzIHJlZ2lzdGVyZWQgdG8gd2hlbgo+IHRoZSBkcml2ZXIgaXMgZGV0YWNoZWQ/CgpJ IHRoaW5rIGEgUEhZIGRyaXZlciBuZWVkcyB0aGUgdXRpbGl0eSB0byBjb250cm9sIHRoaXMuICBX ZSBuZWVkIHRvIGJlCmNhcmVmdWwgaGVyZSB3aXRoIG5hbWluZywgYmVjYXVzZSBwaHlsaWIgaXMg bm90IHRoZSBvbmx5IGNvZGUgaW4gdGhlCmtlcm5lbCB0aGF0IHVzZXMgdGhlIHBoeV8gcHJlZml4 LgoKSWYgd2UgaGFkIHJ1bnRpbWUgUE0gc3VwcG9ydCBmb3IgUEhZcywgd2l0aCByZWd1bGF0b3Ig c3VwcG9ydCBob29rZWQKaW50byBydW50aW1lIFBNLCB0aGVuIHdlIGFscmVhZHkgaGF2ZSBzdGFu ZGFyZCBpbnRlcmZhY2VzIHRoYXQgZHJpdmVycwpjYW4gdXNlIHRvIGNvbnRyb2wgd2hldGhlciB0 aGUgZGV2aWNlIGdldHMgcG93ZXJlZCBkb3duLgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0 cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUh IDQwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0 ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122F7C433DF for ; Wed, 24 Jun 2020 16:59:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D925B20738 for ; Wed, 24 Jun 2020 16:59:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hsx/hY/3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ZgOTBUbP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D925B20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xG56HrEs/jGGR0W8Si1giaggoBBJHq4kwnLPYBmBP1w=; b=hsx/hY/3bJoRMUlLBJoEvCE/L QltVvzKXjiMkbuZa6hf3Pj6E8X6ZMURJ3CJZPTy+X2AwM7l/Tp3SfXuwDGILMvOCN+1x4qGsdbaou 32kRUhVRtqoM2CmFpLUdI1leKNmwGw1lUEVws3FHDzxwMENVmQlNHFbflmN4PaLCsmR1bW9YezgFS TXxE/gAY5r4LbeVFDkxfYGateL3bCSKlusxmxeARQ0ObShb1Zgz5W2NG6NIzVU43ODMDII3qJoB14 jgYtGmcbV/ehpCkvVqPsWIx3LyWQEsmKaatEkJh9fHU6JrO0NcGQytXYHJVvH1PfkjqhJDs1qeviN Yj5jdhq3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8iR-00059g-G4; Wed, 24 Jun 2020 16:57:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8iI-00057U-Ld; Wed, 24 Jun 2020 16:57:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L0BSl9Rz5P8GUkSvL7sI0fAZe5Hrhoqy7/0x3FiFW2Y=; b=ZgOTBUbPjta9cXrzFnnIAnab4 Dcm9pDc0Ejlq5vVTWRjyevo27fV7XGPaj06Z05BDeZRcenj/FWeWJut7lz1cg2jUDgZnf8MvLUdYM P+biZdJlriNMVb3RtYtqgt1B8ql+d+lgDKGM3OOj3i9TDJ3SIgG6/R4Rg8amZWPYlQq6fIY/e5RIH 39Hwa7ZromkrO1urRg88NKb0eQZfm104fYt7Wvq+tEViZGuPwfd3FP5JIhp40PZgkNtwizse0M5zD FpIcwGpyg+93AxBkRp7ezqMw7JKjDwcBW5nSjVKmWjVeWpHEex9JZNfJ7NiOhJ6zOdVKpd7uk/VBN B1UNRAHEg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59222) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jo8i8-0003ML-Ug; Wed, 24 Jun 2020 17:57:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jo8i7-00027d-Ep; Wed, 24 Jun 2020 17:57:19 +0100 Date: Wed, 24 Jun 2020 17:57:19 +0100 From: Russell King - ARM Linux admin To: Bartosz Golaszewski Subject: Re: [PATCH 14/15] net: phy: add PHY regulator support Message-ID: <20200624165719.GB1551@shell.armlinux.org.uk> References: <20200622093744.13685-1-brgl@bgdev.pl> <20200622093744.13685-15-brgl@bgdev.pl> <20200622132921.GI1551@shell.armlinux.org.uk> <20200623094252.GS1551@shell.armlinux.org.uk> <20200623095646.GT1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Tom Lendacky , Vladimir Oltean , Liam Girdwood , Fabien Parent , Iyappan Subramanian , Quan Nguyen , Frank Rowand , Florian Fainelli , Bartosz Golaszewski , Jakub Kicinski , Vivien Didelot , devicetree , Philipp Zabel , Stephane Le Provost , Keyur Chudgar , Jassi Brar , Claudiu Manoil , Mark Brown , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , Linux ARM , netdev , Ilias Apalodimas , Linux Kernel Mailing List , Rob Herring , Andrew Perepech , Pedro Tsai , "David S . Miller" , Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjMsIDIwMjAgYXQgMDY6Mjc6MDZQTSArMDIwMCwgQmFydG9zeiBHb2xhc3pl d3NraSB3cm90ZToKPiB3dC4sIDIzIGN6ZSAyMDIwIG8gMTE6NTYgUnVzc2VsbCBLaW5nIC0gQVJN IExpbnV4IGFkbWluCj4gPGxpbnV4QGFybWxpbnV4Lm9yZy51az4gbmFwaXNhxYIoYSk6Cj4gPgo+ ID4gT24gVHVlLCBKdW4gMjMsIDIwMjAgYXQgMTE6NDY6MTVBTSArMDIwMCwgQmFydG9zeiBHb2xh c3pld3NraSB3cm90ZToKPiA+ID4gd3QuLCAyMyBjemUgMjAyMCBvIDExOjQzIFJ1c3NlbGwgS2lu ZyAtIEFSTSBMaW51eCBhZG1pbgo+ID4gPiA8bGludXhAYXJtbGludXgub3JnLnVrPiBuYXBpc2HF gihhKToKPiA+ID4gPgo+ID4gPiA+IE9uIFR1ZSwgSnVuIDIzLCAyMDIwIGF0IDExOjQxOjExQU0g KzAyMDAsIEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4gPiA+ID4gPiBwb24uLCAyMiBjemUg MjAyMCBvIDE1OjI5IFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbgo+ID4gPiA+ID4gPGxp bnV4QGFybWxpbnV4Lm9yZy51az4gbmFwaXNhxYIoYSk6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gW3NuaXAhXQo+ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhpcyBp cyBsaWtlbHkgdG8gY2F1c2UgaXNzdWVzIGZvciBzb21lIFBIWSBkcml2ZXJzLiAgTm90ZSB0aGF0 IHdlIGhhdmUKPiA+ID4gPiA+ID4gc29tZSBQSFkgZHJpdmVycyB3aGljaCByZWdpc3RlciBhIHRl bXBlcmF0dXJlIHNlbnNvciBpbiB0aGUgcHJvYmUKPiA+ID4gPiA+ID4gZnVuY3Rpb24sIHdoaWNo IG1lYW5zIHRoZXkgY2FuIGJlIGFjY2Vzc2VkIGluZGVwZW5kZW50bHkgb2YgdGhlIGxpZmV0aW1l Cj4gPiA+ID4gPiA+IG9mIHRoZSBQSFkgYm91bmQgdG8gdGhlIG5ldHdvcmsgZHJpdmVyICh3aGlj aCBtYXkgb25seSBiZSB3aGlsZSB0aGUKPiA+ID4gPiA+ID4gbmV0d29yayBkZXZpY2UgaXMgInVw Ii4pICBXZSBjZXJ0YWlubHkgZG8gbm90IHdhbnQgaHdtb24gZmFpbGluZyBqdXN0Cj4gPiA+ID4g PiA+IGJlY2F1c2UgdGhlIG5ldHdvcmsgZGV2aWNlIGlzIGRvd24uCj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IFRoYXQncyBraW5kIG9mIHdvcmtlZCBhcm91bmQgZm9yIHRoZSByZXNldCBzdHVmZiwg YmVjYXVzZSB0aGVyZSBhcmUgdHdvCj4gPiA+ID4gPiA+IGxheWVycyB0byB0aGF0OiB0aGUgbWRp byBkZXZpY2UgbGF5ZXIgcmVzZXQgc3VwcG9ydCB3aGljaCBrbm93cyBub3RoaW5nCj4gPiA+ID4g PiA+IG9mIHRoZSBQSFkgYmluZGluZyBzdGF0ZSB0byB0aGUgbmV0d29yayBkcml2ZXIsIGFuZCB0 aGUgcGh5bGliIHJlc2V0Cj4gPiA+ID4gPiA+IHN1cHBvcnQsIGJ1dCBpdCBpcyBub3QgbmljZS4K PiA+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBSZWd1bGF0b3JzIGFyZSByZWZlcmVuY2Ug Y291bnRlZCBzbyBpZiB0aGUgaHdtb24gZHJpdmVyIGVuYWJsZXMgaXQKPiA+ID4gPiA+IHVzaW5n IG1kaW9fZGV2aWNlX3Bvd2VyX29uKCkgaXQgd2lsbCBzdGF5IG9uIGV2ZW4gYWZ0ZXIgdGhlIFBI WSBkcml2ZXIKPiA+ID4gPiA+IGNhbGxzIHBoeV9kZXZpY2VfcG93ZXJfb2ZmKCksIHJpZ2h0PyBB bSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+ID4gPiA+Cj4gPiA+ID4gSWYgdGhhdCBpcyB0cnVlLCB5 b3Ugd2lsbCBuZWVkIHRvIGF1ZGl0IHRoZSBQSFkgZHJpdmVycyB0byBhZGQgdGhhdC4KPiA+ID4g Pgo+ID4gPgo+ID4gPiBUaGlzIGNoYW5nZSBkb2Vzbid0IGhhdmUgYW55IGVmZmVjdCBvbiBkZXZp Y2VzIHdoaWNoIGRvbid0IGhhdmUgYQo+ID4gPiByZWd1bGF0b3IgYXNzaWduZWQgaW4gRFQgdGhv dWdoLiBUaGUgb25lIEknbSBhZGRpbmcgaW4gdGhlIGxhc3QgcGF0Y2gKPiA+ID4gaXMgdGhlIGZp cnN0IHRvIHVzZSB0aGlzLgo+ID4KPiA+IEl0J3MgcXVhbGl0eSBvZiBpbXBsZW1lbnRhdGlvbi4K PiA+Cj4gPiBTaG91bGQgd2Ugd2FpdCBmb3Igc29tZW9uZSBlbHNlIHRvIG1ha2UgdXNlIG9mIHRo ZSBuZXcgcmVndWxhdG9yCj4gPiBzdXBwb3J0IHRoYXQgaGFzIGJlZW4gYWRkZWQgd2l0aCBhIFBI WSB0aGF0IHVzZXMgaHdtb24sIGFuZCB0aGV5Cj4gPiBkb24ndCByZWFsaXNlIHRoYXQgaXQgYnJl YWtzIGh3bW9uIG9uIGl0LCBhbmQgc2V2ZXJhbCBrZXJuZWwgdmVyc2lvbnMKPiA+IGdvIGJ5IHdp dGhvdXQgaXQgYmVpbmcgbm90aWNlZC4gIEl0IHdpbGwgb25seSBiZSBhIG5vdGljYWJsZSBpc3N1 ZQo+ID4gd2hlbiB0aGUgYXNzb2NpYXRlZCBuZXR3b3JrIGRldmljZSBpcyBkb3duLCBhbmQgdGhh dCBuZXR3b3JrIGRldmljZQo+ID4gZHJpdmVyIGRldGFjaGVzIGZyb20gdGhlIFBIWSwgc28gX2lz XyBsaWtlbHkgbm90IHRvIGJlIG5vdGljZWQuCj4gPgo+ID4gT3Igc2hvdWxkIHdlIGRvIGEgc21h bGwgYW1vdW50IG9mIHdvcmsgbm93IHRvIHByb3Blcmx5IGltcGxlbWVudAo+ID4gcmVndWxhdG9y IHN1cHBvcnQsIHdoaWNoIGluY2x1ZGVzIGEgdHJpdmlhbCBncmVwIGZvciAiaHdtb24iIGFtb25n c3QKPiA+IHRoZSBQSFkgZHJpdmVycywgYW5kIGFkZCB0aGUgbmVjZXNzYXJ5IGNhbGwgdG8gYXZv aWQgdGhlIHJlZ3VsYXRvcgo+ID4gYmVpbmcgc2h1dCBvZmYuCj4gPgo+IAo+IEknbSBub3Qgc3Vy ZSB3aGF0IHRoZSBjb3JyZWN0IGFwcHJvYWNoIGlzIGhlcmUuIFByb3ZpZGUgc29tZSBoZWxwZXIK PiB0aGF0LCB3aGVuIGNhbGxlZCwgd291bGQgaW5jcmVhc2UgdGhlIHJlZ3VsYXRvcidzIHJlZmVy ZW5jZSBjb3VudCBldmVuCj4gbW9yZSB0byBrZWVwIGl0IGVuYWJsZWQgZnJvbSB0aGUgbW9tZW50 IGh3bW9uIGlzIHJlZ2lzdGVyZWQgdG8gd2hlbgo+IHRoZSBkcml2ZXIgaXMgZGV0YWNoZWQ/CgpJ IHRoaW5rIGEgUEhZIGRyaXZlciBuZWVkcyB0aGUgdXRpbGl0eSB0byBjb250cm9sIHRoaXMuICBX ZSBuZWVkIHRvIGJlCmNhcmVmdWwgaGVyZSB3aXRoIG5hbWluZywgYmVjYXVzZSBwaHlsaWIgaXMg bm90IHRoZSBvbmx5IGNvZGUgaW4gdGhlCmtlcm5lbCB0aGF0IHVzZXMgdGhlIHBoeV8gcHJlZml4 LgoKSWYgd2UgaGFkIHJ1bnRpbWUgUE0gc3VwcG9ydCBmb3IgUEhZcywgd2l0aCByZWd1bGF0b3Ig c3VwcG9ydCBob29rZWQKaW50byBydW50aW1lIFBNLCB0aGVuIHdlIGFscmVhZHkgaGF2ZSBzdGFu ZGFyZCBpbnRlcmZhY2VzIHRoYXQgZHJpdmVycwpjYW4gdXNlIHRvIGNvbnRyb2wgd2hldGhlciB0 aGUgZGV2aWNlIGdldHMgcG93ZXJlZCBkb3duLgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0 cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUh IDQwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1A6C433E0 for ; Wed, 24 Jun 2020 16:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA3520738 for ; Wed, 24 Jun 2020 16:57:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ZgOTBUbP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404173AbgFXQ5Y (ORCPT ); Wed, 24 Jun 2020 12:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404124AbgFXQ5Y (ORCPT ); Wed, 24 Jun 2020 12:57:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC4C6C061573; Wed, 24 Jun 2020 09:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L0BSl9Rz5P8GUkSvL7sI0fAZe5Hrhoqy7/0x3FiFW2Y=; b=ZgOTBUbPjta9cXrzFnnIAnab4 Dcm9pDc0Ejlq5vVTWRjyevo27fV7XGPaj06Z05BDeZRcenj/FWeWJut7lz1cg2jUDgZnf8MvLUdYM P+biZdJlriNMVb3RtYtqgt1B8ql+d+lgDKGM3OOj3i9TDJ3SIgG6/R4Rg8amZWPYlQq6fIY/e5RIH 39Hwa7ZromkrO1urRg88NKb0eQZfm104fYt7Wvq+tEViZGuPwfd3FP5JIhp40PZgkNtwizse0M5zD FpIcwGpyg+93AxBkRp7ezqMw7JKjDwcBW5nSjVKmWjVeWpHEex9JZNfJ7NiOhJ6zOdVKpd7uk/VBN B1UNRAHEg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59222) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jo8i8-0003ML-Ug; Wed, 24 Jun 2020 17:57:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jo8i7-00027d-Ep; Wed, 24 Jun 2020 17:57:19 +0100 Date: Wed, 24 Jun 2020 17:57:19 +0100 From: Russell King - ARM Linux admin To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Andrew Lunn , Alexandre Belloni , devicetree , Vladimir Oltean , Linux Kernel Mailing List , Fabien Parent , Iyappan Subramanian , Quan Nguyen , Frank Rowand , Florian Fainelli , Jakub Kicinski , Vivien Didelot , Tom Lendacky , Andrew Perepech , Stephane Le Provost , Keyur Chudgar , Jassi Brar , Claudiu Manoil , Mark Brown , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , Linux ARM , netdev , Ilias Apalodimas , Liam Girdwood , Rob Herring , Philipp Zabel , Pedro Tsai , "David S . Miller" , Heiner Kallweit Subject: Re: [PATCH 14/15] net: phy: add PHY regulator support Message-ID: <20200624165719.GB1551@shell.armlinux.org.uk> References: <20200622093744.13685-1-brgl@bgdev.pl> <20200622093744.13685-15-brgl@bgdev.pl> <20200622132921.GI1551@shell.armlinux.org.uk> <20200623094252.GS1551@shell.armlinux.org.uk> <20200623095646.GT1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 23, 2020 at 06:27:06PM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 11:56 Russell King - ARM Linux admin > napisał(a): > > > > On Tue, Jun 23, 2020 at 11:46:15AM +0200, Bartosz Golaszewski wrote: > > > wt., 23 cze 2020 o 11:43 Russell King - ARM Linux admin > > > napisał(a): > > > > > > > > On Tue, Jun 23, 2020 at 11:41:11AM +0200, Bartosz Golaszewski wrote: > > > > > pon., 22 cze 2020 o 15:29 Russell King - ARM Linux admin > > > > > napisał(a): > > > > > > > > > > > > > > > > [snip!] > > > > > > > > > > > > > > > > > This is likely to cause issues for some PHY drivers. Note that we have > > > > > > some PHY drivers which register a temperature sensor in the probe > > > > > > function, which means they can be accessed independently of the lifetime > > > > > > of the PHY bound to the network driver (which may only be while the > > > > > > network device is "up".) We certainly do not want hwmon failing just > > > > > > because the network device is down. > > > > > > > > > > > > That's kind of worked around for the reset stuff, because there are two > > > > > > layers to that: the mdio device layer reset support which knows nothing > > > > > > of the PHY binding state to the network driver, and the phylib reset > > > > > > support, but it is not nice. > > > > > > > > > > > > > > > > Regulators are reference counted so if the hwmon driver enables it > > > > > using mdio_device_power_on() it will stay on even after the PHY driver > > > > > calls phy_device_power_off(), right? Am I missing something? > > > > > > > > If that is true, you will need to audit the PHY drivers to add that. > > > > > > > > > > This change doesn't have any effect on devices which don't have a > > > regulator assigned in DT though. The one I'm adding in the last patch > > > is the first to use this. > > > > It's quality of implementation. > > > > Should we wait for someone else to make use of the new regulator > > support that has been added with a PHY that uses hwmon, and they > > don't realise that it breaks hwmon on it, and several kernel versions > > go by without it being noticed. It will only be a noticable issue > > when the associated network device is down, and that network device > > driver detaches from the PHY, so _is_ likely not to be noticed. > > > > Or should we do a small amount of work now to properly implement > > regulator support, which includes a trivial grep for "hwmon" amongst > > the PHY drivers, and add the necessary call to avoid the regulator > > being shut off. > > > > I'm not sure what the correct approach is here. Provide some helper > that, when called, would increase the regulator's reference count even > more to keep it enabled from the moment hwmon is registered to when > the driver is detached? I think a PHY driver needs the utility to control this. We need to be careful here with naming, because phylib is not the only code in the kernel that uses the phy_ prefix. If we had runtime PM support for PHYs, with regulator support hooked into runtime PM, then we already have standard interfaces that drivers can use to control whether the device gets powered down. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!